Skip to content

Commit 84c53ae

Browse files
#558: Content Types Output Style Attribute Removal
- move, rename, change severity for tests
1 parent 577f293 commit 84c53ae

File tree

3 files changed

+22
-18
lines changed

3 files changed

+22
-18
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/HtmlData.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,13 @@
3535
<data key="selector">[contains(text(), 'a class="pagebuilder-button-primary"')]</data>
3636
<data key="selectorOnFrontend">//a[@class='pagebuilder-button-primary' and @onclick=&quot;location.href = 'https://google.com';&quot;]//span[.='Duplicate Button']</data>
3737
</entity>
38-
<entity name="PageBuilderHtmlPropertyCssSpecificityBefore" type="pagebuilder_html_property">
38+
<entity name="PageBuilderHtmlPropertyCssSpecificityWithoutBodyId" type="pagebuilder_html_property">
3939
<data key="name">HTML</data>
4040
<data key="section">general</data>
4141
<data key="fieldName">html</data>
42-
<data key="value">&lt;style type=&quot;text/css&quot;&gt;.css__specificity { text-align: center; }&lt;/style&gt;</data>
42+
<data key="value">&lt;style type=&quot;text/css&quot;&gt;.css__specificity { text-align: center; }&lt;/style&gt;</data>`
4343
</entity>
44-
<entity name="PageBuilderHtmlPropertyCssSpecificityAfter" type="pagebuilder_html_property">
44+
<entity name="PageBuilderHtmlPropertyCssSpecificityWithBodyId" type="pagebuilder_html_property">
4545
<data key="name">HTML</data>
4646
<data key="section">general</data>
4747
<data key="fieldName">html</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHeadingTest/HeadingCssResponsiveStylingTest.xml renamed to app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest/AdvancedConfigurationCssResponsiveStylingTest.xml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,22 @@
66
*/
77
-->
88
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
9-
<test name="HeadingCssResponsiveStylingTest">
9+
<test name="AdvancedConfigurationCssResponsiveStylingTest">
1010
<annotations>
1111
<features value="PageBuilder"/>
12-
<stories value="Heading"/>
12+
<stories value="Advanced Configuration"/>
1313
<title value="Heading - CSS Responsive Styling"/>
1414
<description value="Internal (or external) CSS should be able to use media queries to override Page Builder styles that would previously have been inlined."/>
15-
<severity value="AVERAGE"/>
15+
<severity value="MAJOR"/>
1616
<group value="pagebuilder"/>
1717
<group value="pagebuilder-heading"/>
18+
<group value="pagebuilder-advancedConfig"/>
1819
</annotations>
1920
<before>
2021
<createData entity="_emptyCmsPage" stepKey="createCMSPage"/>
2122
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
22-
<actionGroup ref="navigateToCMSPage" stepKey="navigateToCMSPage">
23-
<argument name="CMSPage" value="$$createCMSPage$$"/>
23+
<actionGroup ref="AdminOpenCmsPageActionGroup" stepKey="goToCMSPage">
24+
<argument name="page_id" value="$$createCMSPage.id$$"/>
2425
</actionGroup>
2526
<actionGroup ref="switchToPageBuilderStage" stepKey="waitForPageBuilderDisplay"/>
2627
</before>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHeadingTest/HeadingCssSpecificityTest.xml renamed to app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest/AdvancedConfigurationCssSpecificityTest.xml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,22 @@
66
*/
77
-->
88
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
9-
<test name="HeadingCssSpecificityTest">
9+
<test name="AdvancedConfigurationCssSpecificityTest">
1010
<annotations>
1111
<features value="PageBuilder"/>
12-
<stories value="Heading"/>
12+
<stories value="Advanced Configuration"/>
1313
<title value="Heading - CSS Specificity"/>
1414
<description value="Internal (or external) CSS should be able to override Page Builder defined styles that would previously have been inlined."/>
15-
<severity value="AVERAGE"/>
15+
<severity value="MAJOR"/>
1616
<group value="pagebuilder"/>
1717
<group value="pagebuilder-heading"/>
18+
<group value="pagebuilder-advancedConfig"/>
1819
</annotations>
1920
<before>
2021
<createData entity="_emptyCmsPage" stepKey="createCMSPage"/>
2122
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
22-
<actionGroup ref="navigateToCMSPage" stepKey="navigateToCMSPage">
23-
<argument name="CMSPage" value="$$createCMSPage$$"/>
23+
<actionGroup ref="AdminOpenCmsPageActionGroup" stepKey="goToCMSPage">
24+
<argument name="page_id" value="$$createCMSPage.id$$"/>
2425
</actionGroup>
2526
<actionGroup ref="switchToPageBuilderStage" stepKey="waitForPageBuilderDisplay"/>
2627
</before>
@@ -57,7 +58,7 @@
5758
<argument name="contentType" value="PageBuilderHtmlContentType"/>
5859
</actionGroup>
5960
<actionGroup ref="fillSlideOutPanelTextArea" stepKey="enterHtmlContent">
60-
<argument name="property" value="PageBuilderHtmlPropertyCssSpecificityBefore"/>
61+
<argument name="property" value="PageBuilderHtmlPropertyCssSpecificityWithoutBodyId"/>
6162
</actionGroup>
6263
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
6364
<!-- Verify in Stage -->
@@ -76,8 +77,8 @@
7677
<argument name="cssProperty" value="textAlign"/>
7778
</actionGroup>
7879
<!-- Edit HTML Code -->
79-
<actionGroup ref="navigateToCMSPage" stepKey="navigateToCMSPage">
80-
<argument name="CMSPage" value="$$createCMSPage$$"/>
80+
<actionGroup ref="AdminOpenCmsPageActionGroup" stepKey="goToCMSPage">
81+
<argument name="page_id" value="$$createCMSPage.id$$"/>
8182
</actionGroup>
8283
<actionGroup ref="switchToPageBuilderStage" stepKey="waitForPageBuilderDisplay"/>
8384
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection2">
@@ -87,13 +88,15 @@
8788
<argument name="contentType" value="PageBuilderHtmlContentType"/>
8889
</actionGroup>
8990
<actionGroup ref="fillSlideOutPanelTextArea" stepKey="enterHtmlContent2">
90-
<argument name="property" value="PageBuilderHtmlPropertyCssSpecificityAfter"/>
91+
<argument name="property" value="PageBuilderHtmlPropertyCssSpecificityWithBodyId"/>
9192
</actionGroup>
9293
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
9394
<actionGroup ref="exitPageBuilderFullScreen" stepKey="exitPageBuilderFullScreen2"/>
9495
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage2"/>
9596
<!-- Verify in Storefront -->
96-
<magentoCLI command="cache:clean full_page" stepKey="flushCache"/>
97+
<actionGroup ref="CliCacheCleanActionGroup" stepKey="cleanCache">
98+
<argument name="tags" value="full_page"/>
99+
</actionGroup>
97100
<actionGroup ref="NavigateToStorefrontForCreatedPageActionGroup" stepKey="navigateToStoreFront2">
98101
<argument name="page" value="$$createCMSPage.identifier$$"/>
99102
</actionGroup>

0 commit comments

Comments
 (0)