Skip to content

Commit 81ee151

Browse files
committed
MC-5405: Column Minimum Height Issues
- set column to grow to maximum available height instead of inheriting height - update existing test to check expected column height
1 parent 52f5ab6 commit 81ee151

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,13 +201,9 @@
201201
</actionGroup>
202202
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightBeforeSave">
203203
<argument name="content" value="{{ColumnOnBackend.baseCSS}}"/>
204-
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
205-
<argument name="padding" value="PageBuilderPaddingProperty10"/>
206204
</actionGroup>
207205
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightAfterSave">
208206
<argument name="content" value="{{ColumnOnBackend.baseCSS}}"/>
209-
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
210-
<argument name="padding" value="PageBuilderPaddingProperty10"/>
211207
</actionGroup>
212208
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
213209
<argument name="contentType" value="PageBuilderColumnContentType"/>

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/column/_default.less

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
// _____________________________________________
99

1010
.pagebuilder-content-type.children-min-height.pagebuilder-column {
11+
display: flex;
1112
margin-right: 1px;
1213

1314
> .element-children {
14-
height: 100%;
15-
min-height: inherit;
15+
flex: 1;
1616
padding: 0;
1717
}
1818
}

0 commit comments

Comments
 (0)