Skip to content

Commit 7ed82b8

Browse files
committed
PB-266: Video background for Slide
- CR changes
1 parent 45b8f8a commit 7ed82b8

File tree

2 files changed

+8
-8
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+8
-8
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slide/preview.js

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slide/preview.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ export default class Preview extends BasePreview {
119119

120120
_.defer(() => {
121121
// Build Parallax on elements with the correct class
122-
const viewportElement = $("<div class=\"jarallax-viewport-element\"></div>") as JQuery;
122+
const viewportElement = $("<div/>").addClass("jarallax-viewport-element") as JQuery;
123123

124124
$(this.wrapper).append(
125125
$(".jarallax-viewport-element", this.wrapper).length ? "" : viewportElement,
@@ -517,13 +517,13 @@ export default class Preview extends BasePreview {
517517
}
518518
});
519519

520-
this.contentType.dataStore.subscribe(function(data: DataObject) {
520+
this.contentType.dataStore.subscribe((data: DataObject) => {
521521
this.slideName(data.slide_name);
522522

523523
if (this.shouldUpdateVideo(data)) {
524524
this.buildJarallax();
525525
}
526-
}.bind(this));
526+
});
527527

528528
events.on(`image:${this.contentType.id}:uploadAfter`, () => {
529529
this.contentType.dataStore.set("background_type", "image");

0 commit comments

Comments
 (0)