Skip to content

Commit 7dc83ba

Browse files
committed
MC-4014: PageBuilder Performance Is Bad With Minimal Content
- Fix link href issue
1 parent b43823b commit 7dc83ba

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/attribute/link-href.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/attribute/link-href.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export default class CreateValueForHref implements ConverterInterface {
6666
public toDom(name: string, data: DataObject): string {
6767
const link = data[name] as any;
6868

69-
if (typeof link === "undefined" || !link[link.type].length) {
69+
if (typeof link === "undefined" || (typeof link[link.type] === "string" && !link[link.type].length)) {
7070
return "javascript:void(0)";
7171
}
7272

0 commit comments

Comments
 (0)