MC-10871: [Sec] XSS Injection in HTML Code Content Type

davemacaulay · davemacaulay · commit 7da09b73701f · 2019-02-04T15:55:53.000+01:00
- Rename encode to decode
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/html.xml b/app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/html.xml
@@ -34,7 +34,7 @@
                         <style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
                         <attribute name="name" source="data-role"/>
                         <attribute name="appearance" source="data-appearance"/>
-                        <html name="html" converter="Magento_PageBuilder/js/converter/html/encode"/>
+                        <html name="html" converter="Magento_PageBuilder/js/converter/html/decode"/>
                         <css name="css_classes"/>
                     </element>
                 </elements>
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/html/decode.js b/app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/html/decode.js
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/html/decode.ts b/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/html/decode.ts
@@ -10,7 +10,7 @@ import ConverterInterface from "../converter-interface";
 /**
  * @api
  */
-export default class Encode implements ConverterInterface {
+export default class Decode implements ConverterInterface {
     /**
      * Convert value to internal format
      *

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ import ConverterInterface from "../converter-interface";`
`10`	`10`	`/**`
`11`	`11`	`* @api`
`12`	`12`	`*/`
`13`		`-export default class Encode implements ConverterInterface {`
	`13`	`+export default class Decode implements ConverterInterface {`
`14`	`14`	`/**`
`15`	`15`	`* Convert value to internal format`
`16`	`16`	`*`