Skip to content

Commit 7d12708

Browse files
author
Lukasz Borowiec
committed
#422: Adding Conditions Combination to Conditions Filter Will Cause Server Errors, Condition Filter to Break, & Infinite Loading Mask - Added QA fixes
1 parent e5f7c03 commit 7d12708

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeProductsActionGroup/AddConditionsCombinationToProductsActionGroup.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
<arguments>
1212
<argument name="index" defaultValue="1" type="string"/>
1313
</arguments>
14-
<comment userInput="AddConditionsCombinationToProducts" stepKey="comment"/>
1514
<waitForElementVisible selector="{{ProductsContentTypeForm.conditionsList}}" stepKey="waitForConditionsToLoad"/>
1615
<waitForElementVisible selector="{{ProductsContentTypeForm.conditionsListAddButton(index)}}" stepKey="waitForAddConditionButton"/>
1716
<click selector="{{ProductsContentTypeForm.conditionsListAddButton(index)}}" stepKey="clickAddConditionButton"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsCommonTest/ProductConditionsAddDoubleConditionsCombinationTest.xml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@
1313
<stories value="Products"/>
1414
<title value="Product conditions rule with a combination of double conditions"/>
1515
<description value="As a Content Manager I want set condition filter in Conditions Combination on a Product content type"/>
16-
<severity value="AVERAGE"/>
17-
<useCaseId value=""/>
18-
<testCaseId value=""/>
16+
<severity value="MAJOR"/>
1917
<group value="pagebuilder"/>
2018
<group value="pagebuilder-products"/>
2119
</annotations>
@@ -27,9 +25,6 @@
2725
<after>
2826
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
2927
</after>
30-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
31-
<argument name="contentType" value="PageBuilderProductsContentType"/>
32-
</actionGroup>
3328
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection">
3429
<argument name="contentType" value="PageBuilderProductsContentType"/>
3530
</actionGroup>
@@ -47,8 +42,7 @@
4742
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDropAgain">
4843
<argument name="contentType" value="PageBuilderProductsContentType"/>
4944
</actionGroup>
50-
<!-- Validate product conditions -->
51-
<comment userInput="Validate product conditions" stepKey="productConditionsValidateStage"/>
52-
<dontSeeJsError stepKey="doNotSeeAnyJSErrorsOnStage"/>
45+
<!-- Validate No JS Errors -->
46+
<doNotSeeAnyJSErrors stepKey="doNotSeeAnyJSErrorsOnStage"/>
5347
</test>
5448
</tests>

0 commit comments

Comments
 (0)