Skip to content

Commit 7d08c10

Browse files
davemacaulaydavemacaulay
committed
MC-3799: Slide poster overlay does not cover entire slide in admin when switching appearances
- Add test coverage for issue
1 parent bf61e5b commit 7d08c10

File tree

2 files changed

+83
-0
lines changed

2 files changed

+83
-0
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Data/SlideData.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,13 @@
169169
<data key="fieldName">overlay_color</data>
170170
<data key="value"/>
171171
</entity>
172+
<entity name="PageBuilderSlideItemOverlayColor_HexGreen" type="pagebuilder_slide_item_overlay_color_property">
173+
<data key="name">Overlay Color</data>
174+
<data key="section">general</data>
175+
<data key="fieldName">overlay_color</data>
176+
<data key="value">#008000</data>
177+
<data key="rgb">0, 128, 0</data>
178+
</entity>
172179
<entity name="PageBuilderSlideItemOverlayColor_HexWhite" type="pagebuilder_slide_item_overlay_color_property">
173180
<data key="name">Overlay Color</data>
174181
<data key="section">general</data>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1270,4 +1270,80 @@
12701270
<argument name="property" value="PageBuilderAppearance_Poster"/>
12711271
</actionGroup>
12721272
</test>
1273+
<test name="SliderPosterValidatePaddingOnAppearanceChange">
1274+
<annotations>
1275+
<features value="PageBuilder"/>
1276+
<stories value="Slider"/>
1277+
<title value="Poster - Validate paddings on appearance switch"/>
1278+
<description value="Validate that paddings are correctly applied to the slide within the admin when switching between appearances."/>
1279+
<severity value="MAJOR"/>
1280+
<useCaseId value="MC-3799"/>
1281+
<testCaseId value=""/>
1282+
<group value="pagebuilder"/>
1283+
<group value="pagebuilder-slider"/>
1284+
<group value="pagebuilder-sliderPoster"/>
1285+
</annotations>
1286+
<before>
1287+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1288+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
1289+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1290+
</before>
1291+
<after>
1292+
<actionGroup ref="logout" stepKey="logout"/>
1293+
</after>
1294+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
1295+
<argument name="group" value="PageBuilderSliderContentType"/>
1296+
</actionGroup>
1297+
<actionGroup ref="dragContentTypeToStageAndExpectEditPanel" stepKey="dragSliderIntoStage">
1298+
<argument name="contentType" value="PageBuilderSliderContentType"/>
1299+
</actionGroup>
1300+
<!-- Fill Out Edit Panel: Appearance Poster -->
1301+
<comment userInput="Fill Out Edit Panel: Appearance Poster" stepKey="commentFillEditPanel"/>
1302+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearancePropertyPoster">
1303+
<argument name="property" value="PageBuilderAppearance_Poster"/>
1304+
</actionGroup>
1305+
<actionGroup ref="selectSlideOutPanelField" stepKey="enterOverlayAlways">
1306+
<argument name="property" value="PageBuilderSlideItemShowOverlay_Always"/>
1307+
</actionGroup>
1308+
<actionGroup ref="fillSlideOutPanelField" stepKey="enterOverlayColor">
1309+
<argument name="property" value="PageBuilderSlideItemOverlayColor_HexGreen"/>
1310+
</actionGroup>
1311+
<actionGroup ref="fillSlideOutPanelField" stepKey="enterOverlayTransparency">
1312+
<argument name="property" value="PageBuilderSlideItemOverlayTransparency_70"/>
1313+
</actionGroup>
1314+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1315+
<!-- Validate Stage Overlay and Padding -->
1316+
<comment userInput="Validate Stage Overlay and Padding" stepKey="commentValidateOverlayPadding"/>
1317+
<seeElement selector="{{SlideOnBackend.showOverlay('1', PageBuilderSlideItemShowOverlay_Always.value)}}" stepKey="seeOverlayStateStage"/>
1318+
<seeElement selector="{{SlideOnBackend.overlayColorAndTransparency('1', PageBuilderSlideItemOverlayColor_HexGreen.rgb, PageBuilderSlideItemOverlayTransparency_70.decimal)}}" stepKey="seeOverlayColorAndTransparencyStage"/>
1319+
<seeElement selector="{{SlideOnBackend.posterPadding('1', PageBuilderSlideItemPosterPadding_Default.value)}}" stepKey="seePosterPadding" />
1320+
<dontSeeElement selector="{{SlideOnBackend.collagePadding('1', PageBuilderSlideItemPosterPadding_Default.value)}}" stepKey="dontSeeCollagePadding" />
1321+
<!-- Change Appearance to Collage Left -->
1322+
<comment userInput="Change Appearance to Collage Left" stepKey="commentChangeAppearanceCollageLeft"/>
1323+
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditMenuOnStage">
1324+
<argument name="section" value="SlideOnBackend"/>
1325+
</actionGroup>
1326+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearancePropertyCollageRight">
1327+
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
1328+
</actionGroup>
1329+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
1330+
<seeElement selector="{{SlideOnBackend.showOverlay('1', PageBuilderSlideItemShowOverlay_Always.value)}}" stepKey="seeOverlayStateStage2"/>
1331+
<seeElement selector="{{SlideOnBackend.overlayColorAndTransparency('1', PageBuilderSlideItemOverlayColor_HexGreen.rgb, PageBuilderSlideItemOverlayTransparency_70.decimal)}}" stepKey="seeOverlayColorAndTransparencyStage2"/>
1332+
<dontSeeElement selector="{{SlideOnBackend.posterPadding('1', PageBuilderSlideItemPosterPadding_Default.value)}}" stepKey="dontSeeDefaultPosterPadding" />
1333+
<!-- Change Appearance back to Poster -->
1334+
<comment userInput="Change Appearance back to Poster" stepKey="commentChangeAppearanceBackToPoster"/>
1335+
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditMenuOnStage2">
1336+
<argument name="section" value="SlideOnBackend"/>
1337+
</actionGroup>
1338+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearancePropertyPoster2">
1339+
<argument name="property" value="PageBuilderAppearance_Poster"/>
1340+
</actionGroup>
1341+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
1342+
<!-- Validate Stage Overlay and Padding after appearance change -->
1343+
<comment userInput="Validate Stage Overlay and Padding after appearance change" stepKey="commentValidateOverlayPadding2"/>
1344+
<seeElement selector="{{SlideOnBackend.showOverlay('1', PageBuilderSlideItemShowOverlay_Always.value)}}" stepKey="seeOverlayStateStage3"/>
1345+
<seeElement selector="{{SlideOnBackend.overlayColorAndTransparency('1', PageBuilderSlideItemOverlayColor_HexGreen.rgb, PageBuilderSlideItemOverlayTransparency_70.decimal)}}" stepKey="seeOverlayColorAndTransparencyStage3"/>
1346+
<seeElement selector="{{SlideOnBackend.posterPadding('1', PageBuilderSlideItemPosterPadding_Default.value)}}" stepKey="seePosterPadding2" />
1347+
<dontSeeElement selector="{{SlideOnBackend.collagePadding('1', PageBuilderSlideItemPosterPadding_Default.value)}}" stepKey="dontSeeCollagePadding2" />
1348+
</test>
12731349
</tests>

0 commit comments

Comments
 (0)