PB-500 static test fixes and MFTF fixes

Author: paras89

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest/RowDuplicateTest.xml

@@ -120,6 +120,8 @@
             <argument name="x" value="5"/>
             <argument name="y" value="5"/>
         </actionGroup>
+        <click selector="{{PageBuilderPanel.searchPanel}}" stepKey="clickAwayFromHiddenRow"/>
+
         <!-- Duplicate and Validate Stage -->
         <comment userInput="Duplicate" stepKey="commentDuplicate"/>
         <actionGroup ref="duplicateContentType" stepKey="duplicateContentType">

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/column-group/preview.js

@@ -26,7 +26,7 @@ import Resize, {
 } from "../column/resize";
 import {
     ContentTypeDroppedCreateEventParamsInterface,
-    ContentTypeRemovedEventParamsInterface
+    ContentTypeRemovedEventParamsInterface,
 } from "../content-type-events.types";
 import ObservableUpdater from "../observable-updater";
 import PreviewCollection from "../preview-collection";
@@ -39,7 +39,6 @@ import {OptionsInterface} from "Magento_PageBuilder/js/content-type-menu/option.
 import HideShowOption from "Magento_PageBuilder/js/content-type-menu/hide-show-option";
 import ContentTypeInterface from "Magento_PageBuilder/js/content-type.types";
 
-
 /**
  * @api
  */
@@ -149,7 +148,7 @@ export default class Preview extends PreviewCollection {
      */
     public onOptionEdit(): void {
         const numCols = this.contentType.getChildren()().length;
-        //count the number of non empty columns
+        // count the number of non empty columns
         let numEmptyColumns = 0;
         this.contentType.getChildren()().forEach(
             (column: ContentTypeCollectionInterface<ColumnPreview>) => {
@@ -158,13 +157,12 @@ export default class Preview extends PreviewCollection {
                 }
             });
 
-        this.contentType.dataStore.set('non_empty_column_count', numCols - numEmptyColumns);
-        this.contentType.dataStore.set('max_grid_size', getMaxGridSize());
-        this.contentType.dataStore.set('initial_grid_size', this.contentType.dataStore.get('grid_size'));
+        this.contentType.dataStore.set("non_empty_column_count", numCols - numEmptyColumns);
+        this.contentType.dataStore.set("max_grid_size", getMaxGridSize());
+        this.contentType.dataStore.set("initial_grid_size", this.contentType.dataStore.get("grid_size"));
         super.openEdit();
     }
 
-
     /**
      * Bind events
      */
@@ -181,7 +179,7 @@ export default class Preview extends PreviewCollection {
         }
 
         events.on(`form:${this.contentType.id}:saveAfter`, () => {
-            if (this.contentType.dataStore.get('grid_size') != this.contentType.dataStore.get('initial_grid_size')) {
+            if (this.contentType.dataStore.get("grid_size") !== this.contentType.dataStore.get("initial_grid_size")) {
                 this.updateGridSize();
             }
         });
@@ -191,10 +189,9 @@ export default class Preview extends PreviewCollection {
      * Set default grid size on current column group
      */
     public setDefaultGridSizeOnColumnGroup(): void {
-        this.contentType.dataStore.set('grid_size', getDefaultGridSize());
+        this.contentType.dataStore.set("grid_size", getDefaultGridSize());
     }
 
-
     /**
      * Add Columns to the current Column Group
      *
@@ -325,18 +322,6 @@ export default class Preview extends PreviewCollection {
         });
     }
 
-    /**
-     * Fire the mount event for content types
-     *
-     * @param {ContentTypeInterface[]} contentTypes
-     */
-    private fireMountEvent(...contentTypes: ContentTypeInterface[]) {
-        contentTypes.forEach((contentType) => {
-            events.trigger("contentType:mountAfter", {id: contentType.id, contentType});
-            events.trigger(contentType.config.name + ":mountAfter", {id: contentType.id, contentType});
-        });
-    }
-
     /**
      * Handle an existing column being dropped into a new column group
      *
@@ -594,6 +579,18 @@ export default class Preview extends PreviewCollection {
         }
     }
 
+    /**
+     * Fire the mount event for content types
+     *
+     * @param {ContentTypeInterface[]} contentTypes
+     */
+    private fireMountEvent(...contentTypes: ContentTypeInterface[]) {
+        contentTypes.forEach((contentType) => {
+            events.trigger("contentType:mountAfter", {id: contentType.id, contentType});
+            events.trigger(contentType.config.name + ":mountAfter", {id: contentType.id, contentType});
+        });
+    }
+
     /**
      * Set columns in the group as resizing
      *

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/column/preview.js

@@ -21,7 +21,7 @@ import {
     ContentTypeDroppedCreateEventParamsInterface, ContentTypeDuplicateEventParamsInterface,
     ContentTypeMountEventParamsInterface,
     ContentTypeMoveEventParamsInterface,
-    ContentTypeRemovedEventParamsInterface
+    ContentTypeRemovedEventParamsInterface,
 } from "../content-type-events.types";
 import ObservableUpdater from "../observable-updater";
 import PreviewCollection from "../preview-collection";
@@ -293,26 +293,26 @@ export default class Preview extends PreviewCollection {
     }
 
     /**
-     * Reset remove option on all columns in a column-group parentContentType depending on the number of remaining child columns
+     * Reset remove option on all columns within a column-group depending on the number of remaining child columns
      * @param parentContentType
      */
     public resetRemoveOnLastColumn(parentContentType: ContentTypeCollectionInterface) {
         if (!parentContentType) {
-            //can happen if the column is moved within the same column group
+            // can happen if the column is moved within the same column group
             return;
         }
         const siblings = parentContentType.children();
         if (siblings.length < 1) {
             return;
         }
-        if (siblings.length == 1) {
+        if (siblings.length === 1) {
             const lastColumn = siblings[0];
             const options = lastColumn.preview.getOptions();
-            options.getOption('remove').isDisabled(true)
+            options.getOption("remove").isDisabled(true);
             return;
         }
-        siblings.forEach( function(column) {
-            const removeOption = column.preview.getOptions().getOption('remove');
+        siblings.forEach((column) => {
+            const removeOption = column.preview.getOptions().getOption("remove");
             removeOption.isDisabled(false);
         });
     }