Skip to content

Commit 7af690d

Browse files
MC-3735: Allow inline WYSIWYG editing of slides
- On small width (less than 410px) do not show the "Upload Image | Select from Gallery" buttons on hover
1 parent e1f3753 commit 7af690d

File tree

3 files changed

+41
-5
lines changed

3 files changed

+41
-5
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slider/_default.less

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,14 @@
3030
width: 100%;
3131
}
3232
}
33+
34+
.slider-small-width {
35+
.pagebuilder-image-uploader-container {
36+
.pagebuilder-options {
37+
display: none;
38+
}
39+
}
40+
}
3341
}
3442

3543
&.pagebuilder-content-type-active {

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 16 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export default class Preview extends PreviewCollection {
4040
protected events: DataObject = {
4141
columnWidthChangeAfter: "onColumnResize",
4242
};
43-
private element: Element;
43+
private element: HTMLElement;
4444
private childSubscribe: KnockoutSubscription;
4545
private contentTypeHeightReset: boolean;
4646

@@ -177,7 +177,7 @@ export default class Preview extends PreviewCollection {
177177
*/
178178
public onFocusOut(data: PreviewCollection, event: JQueryEventObject) {
179179
if (_.isNull(event.relatedTarget) ||
180-
event.relatedTarget && !$.contains(event.currentTarget as Element, event.relatedTarget)
180+
event.relatedTarget && !$.contains(event.currentTarget as HTMLElement, event.relatedTarget)
181181
) {
182182
this.setFocusedSlide(null);
183183
}
@@ -199,11 +199,12 @@ export default class Preview extends PreviewCollection {
199199
/**
200200
* After child render record element
201201
*
202-
* @param {Element} element
202+
* @param {HTMLElement} element
203203
*/
204-
public afterChildrenRender(element: Element): void {
204+
public afterChildrenRender(element: HTMLElement): void {
205205
super.afterChildrenRender(element);
206206
this.element = element;
207+
this.checkWidth();
207208
}
208209

209210
/**
@@ -418,6 +419,18 @@ export default class Preview extends PreviewCollection {
418419
private onColumnResize(params: any) {
419420
setTimeout(() => {
420421
$(this.element).slick("setPosition");
422+
this.checkWidth();
421423
}, 250);
422424
}
425+
426+
/**
427+
* Check width and add class that marks element as small
428+
*/
429+
private checkWidth() {
430+
if (this.element.offsetWidth < 410) {
431+
this.element.classList.add("slider-small-width");
432+
} else {
433+
this.element.classList.remove("slider-small-width");
434+
}
435+
}
423436
}

0 commit comments

Comments
 (0)