MC-14937: Complete Page Builder Analytics data collection

davemacaulay · davemacaulay · commit 797b9d6db581 · 2019-03-06T11:20:47.000+01:00
- Resolve CR comments
diff --git a/app/code/Magento/PageBuilderAnalytics/Model/ContentTypeUsageReportProvider.php b/app/code/Magento/PageBuilderAnalytics/Model/ContentTypeUsageReportProvider.php
@@ -51,7 +51,7 @@ public function __construct(
         Config $config,
         QueryFactory $queryFactory,
         ConnectionFactory $connectionFactory,
-        $batchSize = 1000
+        $batchSize = 5000
     ) {
         $this->config = $config;
         $this->queryFactory = $queryFactory;
@@ -101,11 +101,9 @@ public function getReport($name) : \IteratorIterator
             }
         }
 
-        $total = 0;
         $reportData[] = ['Content Type', 'Count'];
         foreach ($contentTypes as $type) {
             $reportData[] = [$type['name'], $typeCounts[$type['name']]];
-            $total = $total + $typeCounts[$type['name']];
         }
 
         return new \IteratorIterator(
diff --git a/app/code/Magento/PageBuilderAnalytics/etc/di.xml b/app/code/Magento/PageBuilderAnalytics/etc/di.xml
@@ -16,9 +16,4 @@
             </argument>
         </arguments>
     </type>
-    <type name="Magento\PageBuilderAnalytics\Model\ContentTypeUsageReportProvider">
-        <arguments>
-            <argument name="batchSize" xsi:type="number">5000</argument>
-        </arguments>
-    </type>
 </config>

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function __construct(`
`51`	`51`	`Config $config,`
`52`	`52`	`QueryFactory $queryFactory,`
`53`	`53`	`ConnectionFactory $connectionFactory,`
`54`		`- $batchSize = 1000`
	`54`	`+ $batchSize = 5000`
`55`	`55`	`) {`
`56`	`56`	`$this->config = $config;`
`57`	`57`	`$this->queryFactory = $queryFactory;`
`@@ -101,11 +101,9 @@ public function getReport($name) : \IteratorIterator`
`101`	`101`	`}`
`102`	`102`	`}`
`103`	`103`
`104`		`- $total = 0;`
`105`	`104`	`$reportData[] = ['Content Type', 'Count'];`
`106`	`105`	`foreach ($contentTypes as $type) {`
`107`	`106`	`$reportData[] = [$type['name'], $typeCounts[$type['name']]];`
`108`		`- $total = $total + $typeCounts[$type['name']];`
`109`	`107`	`}`
`110`	`108`
`111`	`109`	`return new \IteratorIterator(`