MC-401: Advanced Attributes Not Removing From Preview

- fix converters to return empty string for default values

Author: krissyhiserote

app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/style/border-style.js

@@ -28,7 +28,7 @@ export default class BorderStyleDefault implements ConverterInterface {
      * @returns {string}
      */
     public toDom(name: string, data: DataObject): string {
-        if (data[name]) {
+        if (data[name] && data[name] !== "_default") {
             return data[name].toString();
         }
     }

app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/style/border-width.js

@@ -24,6 +24,8 @@ export default class BorderWidth implements ConverterInterface {
      * @returns {string | object}
      */
     public toDom(name: string, data: object): string | object {
-        return data[name] + "px";
+        if (data[name]) {
+            return data[name] + "px";
+        }
     }
 }

app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/style/margins-and-paddings.js

@@ -48,16 +48,16 @@ export default class MarginsAndPaddings implements ConverterInterface {
         }
         if (value) {
             if (undefined !== value.margin) {
-                result.marginLeft = value.margin.left + "px";
-                result.marginTop = value.margin.top + "px";
-                result.marginRight = value.margin.right + "px";
-                result.marginBottom = value.margin.bottom + "px";
+                result.marginLeft = value.margin.left ? value.margin.left + "px" : "";
+                result.marginTop = value.margin.top ? value.margin.top + "px" : "";
+                result.marginRight = value.margin.right ? value.margin.right + "px" : "";
+                result.marginBottom = value.margin.bottom ? value.margin.bottom + "px" : "";
             }
             if (undefined !== value.padding) {
-                result.paddingLeft = value.padding.left + "px";
-                result.paddingTop = value.padding.top + "px";
-                result.paddingRight = value.padding.right + "px";
-                result.paddingBottom = value.padding.bottom + "px";
+                result.paddingLeft = value.padding.left ? value.padding.left + "px" : "";
+                result.paddingTop = value.padding.top ? value.padding.top + "px" : "";
+                result.paddingRight = value.padding.right ? value.padding.right + "px" : "";
+                result.paddingBottom = value.padding.bottom ? value.padding.bottom + "px" : "";
             }
         }
         return result;

app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/style/margins.js

@@ -39,10 +39,10 @@ export default class Margins implements ConverterInterface {
             value = JSON.parse(value);
         }
         if (value && undefined !== value.margin) {
-            result.marginLeft = value.margin.left + "px";
-            result.marginTop = value.margin.top + "px";
-            result.marginRight = value.margin.right + "px";
-            result.marginBottom = value.margin.bottom + "px";
+            result.marginLeft = value.margin.left ? value.margin.left + "px" : "";
+            result.marginTop = value.margin.top ? value.margin.top + "px" : "";
+            result.marginRight = value.margin.right ? value.margin.right + "px" : "";
+            result.marginBottom = value.margin.bottom ? value.margin.bottom + "px" : "";
         }
         return result;
     }

app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/style/paddings.js

@@ -39,10 +39,10 @@ export default class Paddings implements ConverterInterface {
             value = JSON.parse(value);
         }
         if (value && undefined !== value.padding) {
-            result.paddingLeft = value.padding.left + "px";
-            result.paddingTop = value.padding.top + "px";
-            result.paddingRight = value.padding.right + "px";
-            result.paddingBottom = value.padding.bottom + "px";
+            result.paddingLeft = value.padding.left ? value.padding.left + "px" : "";
+            result.paddingTop = value.padding.top ? value.padding.top + "px" : "";
+            result.paddingRight = value.padding.right ? value.padding.right + "px" : "";
+            result.paddingBottom = value.padding.bottom ? value.padding.bottom + "px" : "";
         }
         return result;
     }