Skip to content

Commit 7692030

Browse files
committed
MAGETWO-92021: [Tech debt] Improving dev experience for Products content type
- Build stabilization
1 parent 0cb853d commit 7692030

File tree

2 files changed

+6
-4
lines changed
  • app/code/Magento/PageBuilder/Controller/Adminhtml/Form/Element/ProductConditions
  • dev/tests/js/jasmine/tests/app/code/PageBuilder/view/adminhtml/web/js/content-type/products/mass-converter

2 files changed

+6
-4
lines changed

app/code/Magento/PageBuilder/Controller/Adminhtml/Form/Element/ProductConditions/Child.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class Child extends \Magento\CatalogWidget\Controller\Adminhtml\Product\Widget
1818
/**
1919
* @var \Magento\CatalogWidget\Model\Rule
2020
*/
21-
protected $rule;
21+
private $rule;
2222

2323
/**
2424
* @param \Magento\Backend\App\Action\Context $context

dev/tests/js/jasmine/tests/app/code/PageBuilder/view/adminhtml/web/js/content-type/products/mass-converter/widget-directive.test.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,11 @@ define([
134134
config = {
135135
html_variable: 'myhtml'
136136
},
137-
attributes = '{{widget ' +
138-
'products_count="123" ' +
139-
'conditions_encoded="^[`1`:^[`type`:`My||Type`,`aggregator`:`all`^]^]"}}',
137+
attributes = {
138+
myhtml: '{{widget ' +
139+
'products_count="123" ' +
140+
'conditions_encoded="^[`1`:^[`type`:`My||Type`,`aggregator`:`all`^]^]"}}'
141+
},
140142
result = model.fromDom(attributes, config);
141143

142144
expect(result.products_count).toBe(expected.products_count);

0 commit comments

Comments
 (0)