Skip to content

Commit 764d874

Browse files
committed
PB-413: Remove Deprecated Page Builder MFTF Tests, Entities, Action Groups
- fix values for paddingTop and paddingBottom
1 parent 5c1204e commit 764d874

File tree

6 files changed

+18
-18
lines changed

6 files changed

+18
-18
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTest/BlockRenderRowContainedAppearanceWithParallaxThroughBlockContentTypeTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@
130130
</actionGroup>
131131
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateRowHeightCMSBlockStage">
132132
<argument name="content" value="{{RowOnStage.baseCSS}}"/>
133-
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.value}}"/>
134-
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.value}}"/>
133+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.paddingTop}}"/>
134+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.paddingBottom}}"/>
135135
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500.value}}"/>
136136
</actionGroup>
137137
<actionGroup ref="validateDividerWidthPercentage" stepKey="validateDividerWidthCMSBlockStage">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTest/BlockRenderRowFullWidthAppearanceThroughBlockContentTypeTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@
4343
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateRowHeightCMSBlockStage">
4444
<argument name="content" value="{{RowOnStage.baseCSS}}"/>
4545
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500.value}}"/>
46-
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.value}}"/>
47-
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.value}}"/>
46+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.paddingTop}}"/>
47+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.paddingBottom}}"/>
4848
</actionGroup>
4949
<comment userInput="---merging to remove step---" stepKey="validateParallaxBackgroundCMSBlockStage"/>
5050
<actionGroup ref="validateBackgroundImageContainer" stepKey="validateBackgroundImageCMSBlockStage">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTest/BlockRenderRowFullWidthAppearanceWithParallaxThroughBlockContentTypeTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@
4545
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateRowHeightCMSBlockStage">
4646
<argument name="content" value="{{RowOnStage.baseCSS}}"/>
4747
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500.value}}"/>
48-
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.value}}"/>
49-
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.value}}"/>
48+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.paddingTop}}"/>
49+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.paddingBottom}}"/>
5050
</actionGroup>
5151
<actionGroup ref="validateRowParallaxBackgroundAttributes" stepKey="validateRowParallaxBackgroundCMSPageStage">
5252
<argument name="page" value="RowOnStorefront_FullWidth_FullBleed"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTest/BlockRenderTabsThroughBlockContentTypeTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,8 @@
176176
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateTab1MinHeightCMSBlockStage">
177177
<argument name="content" value="{{TabOnStage.tabContentCSS}}"/>
178178
<argument name="minHeight" value="{{PageBuilderTabMinimumHeight200Property.value}}"/>
179-
<argument name="paddingTop" value="{{PageBuilderPaddingProperty40.value}}"/>
180-
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty40.value}}"/>
179+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty40.paddingTop}}"/>
180+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty40.paddingBottom}}"/>
181181
<argument name="borderWidth" value="{{PageBuilderAdvancedBorderWidthPropertyDefault.value}}"/>
182182
<argument name="index" value="1"/>
183183
</actionGroup>
@@ -219,8 +219,8 @@
219219
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateTab2MinHeightCMSPageStage">
220220
<argument name="content" value="{{TabOnStorefront.tabContentCSS}}"/>
221221
<argument name="minHeight" value="{{PageBuilderTabMinHeight0Property.value}}"/>
222-
<argument name="paddingTop" value="{{PageBuilderPaddingProperty40.value}}"/>
223-
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty40.value}}"/>
222+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty40.paddingTop}}"/>
223+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty40.paddingBottom}}"/>
224224
<argument name="index" value="2"/>
225225
</actionGroup>
226226
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowLayoutTest/RowWithBordersAndPaddingEqualToMinHeightTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@
5757
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightBeforeSave">
5858
<argument name="content" value="{{RowOnStage.baseCSS}}"/>
5959
<argument name="borderWidth" value="{{PageBuilderAdvancedBorderWidthProperty10.value}}"/>
60-
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.value}}"/>
61-
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.value}}"/>
60+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.paddingTop}}"/>
61+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.paddingBottom}}"/>
6262
</actionGroup>
6363
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
6464
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
@@ -67,8 +67,8 @@
6767
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightAfterSave">
6868
<argument name="content" value="{{RowOnStage.baseCSS}}"/>
6969
<argument name="borderWidth" value="{{PageBuilderAdvancedBorderWidthProperty10.value}}"/>
70-
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.value}}"/>
71-
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.value}}"/>
70+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.paddingTop}}"/>
71+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.paddingBottom}}"/>
7272
</actionGroup>
7373
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
7474
<argument name="contentType" value="PageBuilderRowContentType"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemLayoutTest/TabItemWithBordersAndPaddingEqualToMinHeightTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@
3535
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightBeforeSave">
3636
<argument name="content" value="{{TabOnStage.tabContentCSS}}"/>
3737
<argument name="borderWidth" value="{{PageBuilderAdvancedBorderWidthProperty10.value}}"/>
38-
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.value}}"/>
39-
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.value}}"/>
38+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.paddingTop}}"/>
39+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.paddingBottom}}"/>
4040
</actionGroup>
4141
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightAfterSave">
4242
<argument name="content" value="{{TabOnStage.tabContentCSS}}"/>
4343
<argument name="borderWidth" value="{{PageBuilderAdvancedBorderWidthProperty10.value}}"/>
44-
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.value}}"/>
45-
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.value}}"/>
44+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.paddingTop}}"/>
45+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.paddingBottom}}"/>
4646
</actionGroup>
4747
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
4848
<argument name="contentType" value="PageBuilderTabsContentType"/>

0 commit comments

Comments
 (0)