MC-3926: Slide Content Does Not Render After Page Load If Slide Is In Non-Default Tab

danmooney2 · danmooney2 · commit 74f225d8ecb7 · 2018-09-28T10:52:37.000-05:00
Fix determination of slider containment
diff --git a/app/code/Magento/PageBuilder/view/base/web/js/content-type/slider/appearance/default/widget.js b/app/code/Magento/PageBuilder/view/base/web/js/content-type/slider/appearance/default/widget.js
@@ -31,7 +31,7 @@ define([
 
         // Redraw slide after content type gets redrawn
         events.on('contentType:redrawAfter', function (args) {
-            if ($.contains(args.element, sliderElement)) {
+            if ($element.closest(args.element).length) {
                 $element.slick('setPosition');
             }
         });

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ define([`
`31`	`31`
`32`	`32`	`// Redraw slide after content type gets redrawn`
`33`	`33`	`events.on('contentType:redrawAfter', function (args) {`
`34`		`- if ($.contains(args.element, sliderElement)) {`
	`34`	`+ if ($element.closest(args.element).length) {`
`35`	`35`	`$element.slick('setPosition');`
`36`	`36`	`}`
`37`	`37`	`});`