Skip to content

Commit 74dbf4d

Browse files
committed
MC-4294: Cannot Activate Tab Item After Moving Tabs or Slider to New Parent Container
Address CR feedback
1 parent 8a20a70 commit 74dbf4d

File tree

1 file changed

+20
-8
lines changed

1 file changed

+20
-8
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabGroupTests.xml

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1175,7 +1175,7 @@
11751175
<test name="TabsMovesTabs">
11761176
<annotations>
11771177
<features value="PageBuilder"/>
1178-
<stories value="Tab"/>
1178+
<stories value="Tabs"/>
11791179
<title value="Tab Group - Validate Proper Rendering and Interactivity After Moving To Different Container"/>
11801180
<description value="Validate that tabs renders itself properly and retains its interactivity after moving to a different parent container."/>
11811181
<severity value="MAJOR"/>
@@ -1214,9 +1214,11 @@
12141214
<argument name="contentTypeIndex" value="1"/>
12151215
<argument name="containerTargetIndex" value="2"/>
12161216
</actionGroup>
1217-
<actionGroup ref="dragContentTypeToStageByIndex" stepKey="dragColumnContentTypeToSecondRowContentTypeOnStage">
1217+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragColumnContentTypeToFirstRowContentTypeOnStage">
12181218
<argument name="contentType" value="PageBuilderColumnContentType"/>
1219-
<argument name="contentTypeNumber" value="1"/>
1219+
<argument name="contentTypeIndex" value="1"/>
1220+
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
1221+
<argument name="containerTargetIndex" value="1"/>
12201222
</actionGroup>
12211223
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="loseFocus"/>
12221224
<actionGroup ref="moveContentTypeToContainer" stepKey="moveTabsIntoFirstColumn">
@@ -1231,33 +1233,43 @@
12311233
<argument name="contentTypeIndex" value="1"/>
12321234
<argument name="containerTargetIndex" value="1"/>
12331235
</actionGroup>
1234-
<waitForElementVisible selector="{{TabOnStage.tabHeaderItemActive('1')}}" stepKey="seeFirstTabAsActive"/>
1236+
<seeElement selector="{{TabOnStage.tabHeaderItemActive('1')}}" stepKey="seeFirstTabAsActive"/>
12351237
<actionGroup ref="duplicateSmallContentType" stepKey="duplicateSmallContentType">
12361238
<argument name="section" value="TabOnStage"/>
12371239
<argument name="targetIndex" value="1"/>
12381240
</actionGroup>
1239-
<waitForElementVisible selector="{{TabOnStage.tabHeaderItemActive('2')}}" stepKey="seeSecondTabAsActiveAfterDuplicating"/>
1241+
<seeElement selector="{{TabOnStage.tabHeaderItemActive('2')}}" stepKey="seeSecondTabAsActiveAfterDuplicating"/>
12401242
<!-- Change appearance of row and re-evaluate -->
12411243
<comment userInput="Change appearance of row and re-evaluate" stepKey="commentChangeAppearanceOfRowAndReevaluate"/>
12421244
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="loseFocus2"/>
1243-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStageForFirstRow">
1245+
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStageForFirstRow">
12441246
<argument name="contentType" value="PageBuilderRowContentType"/>
1247+
<argument name="contentTypeIndex" value="1"/>
1248+
<argument name="contentTypeXCoordinate" value="10"/>
1249+
<argument name="contentTypeYCoordinate" value="0"/>
12451250
</actionGroup>
12461251
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceRow1">
12471252
<argument name="property" value="PageBuilderRowAppearance_FullWidth"/>
12481253
</actionGroup>
12491254
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettingsRow1"/>
1250-
<waitForElementVisible selector="{{TabOnStage.tabHeaderItemActive('2')}}" stepKey="seeSecondTabAsActiveAfterChangingRowAppearance"/>
1255+
<seeElement selector="{{TabOnStage.tabHeaderItemActive('2')}}" stepKey="seeSecondTabAsActiveAfterChangingRowAppearance"/>
12511256
<actionGroup ref="switchTabs" stepKey="switchTabsStage">
12521257
<argument name="section" value="TabOnStage"/>
12531258
<argument name="from" value="2"/>
12541259
<argument name="to" value="1"/>
12551260
</actionGroup>
12561261
<actionGroup ref="saveCmsPage" stepKey="saveCmsPage"/>
1262+
<!-- Validate Storefront -->
1263+
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
12571264
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
12581265
<argument name="contentType" value="PageBuilderTabsContentType"/>
12591266
</actionGroup>
1260-
<waitForPageLoad stepKey="waitForPageLoadStoreFront" time="30"/>
1267+
<actionGroup ref="validateContentTypeInsideContainerStorefront" stepKey="validateTabsInsideFirstColumnOnStorefront">
1268+
<argument name="contentType" value="PageBuilderTabsContentType"/>
1269+
<argument name="contentTypeIndex" value="1"/>
1270+
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
1271+
<argument name="containerTargetIndex" value="1"/>
1272+
</actionGroup>
12611273
<actionGroup ref="switchTabs" stepKey="switchTabsStorefront">
12621274
<argument name="section" value="TabOnStorefront"/>
12631275
<argument name="from" value="1"/>

0 commit comments

Comments
 (0)