Skip to content

Commit 738af75

Browse files
author
Michael Yu
committed
MC-3031: MFTF Test Updates
- Fixed typos in tests - Updated validation to use action groups
1 parent 5872d64 commit 738af75

File tree

2 files changed

+22
-12
lines changed

2 files changed

+22
-12
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest.xml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1551,12 +1551,20 @@
15511551
<actionGroup ref="dragContentTypeToStage" stepKey="dragColumnIntoStage">
15521552
<argument name="contentType" value="PageBuilderColumnContentType"/>
15531553
</actionGroup>
1554-
<!-- Add row to Column -->
1554+
<!-- Drag column into a column -->
15551555
<actionGroup ref="dragContentTypeToContainer" stepKey="dragRowOntoColumn">
15561556
<argument name="contentType" value="PageBuilderColumnContentType"/>
15571557
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
15581558
<argument name="containerTargetIndex" value="2" />
15591559
</actionGroup>
1560-
<seeNumberOfElements selector="{{PageBuilderColumnSection.allColumns}}" userInput="2" stepKey="seeOnlyTwoElementColumns"/>
1560+
<!-- Validate Stage -->
1561+
<comment userInput="User dont see column displayed in column on Stage" stepKey="confirmNoColumnInColumn"/>
1562+
<actionGroup ref="validateContentTypeNotInsideContainerStage" stepKey="checkContentTypeNotInContainerStage">
1563+
<argument name="contentType" value="PageBuilderColumnContentType"/>
1564+
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
1565+
<argument name="contentTypeIndex" value="1"/>
1566+
<argument name="containerTargetIndex" value="2"/>
1567+
</actionGroup>
1568+
<seeNumberOfElements selector="{{PageBuilderColumnSection.allColumns}}" userInput="3" stepKey="seesThreeElementColumns"/>
15611569
</test>
15621570
</tests>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderVideoTest.xml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -706,12 +706,13 @@
706706
<argument name="property" value="PageBuilderVideoWidth_500"/>
707707
</actionGroup>
708708
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
709-
<!-- Verify Video in Tab on stage -->
710-
<comment userInput="View video on stage" stepKey="viewTabOnStage"/>
711-
<actionGroup ref="validateVideo" stepKey="validateStage">
712-
<argument name="page" value="VideoOnStage"/>
713-
<argument name="url" value="PageBuilderVideoUrl_YouTube"/>
714-
<argument name="width" value="PageBuilderVideoWidth_500"/>
709+
<!-- Validate Stage -->
710+
<comment userInput="User sees video displayed in tab on Stage" stepKey="confirmVideoOnStage"/>
711+
<actionGroup ref="validateContentTypeInsideContainerStage" stepKey="checkContentTypeInContainerStage">
712+
<argument name="contentType" value="PageBuilderVideoContentType"/>
713+
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
714+
<argument name="contentTypeIndex" value="1"/>
715+
<argument name="containerTargetIndex" value="1"/>
715716
</actionGroup>
716717
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
717718
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
@@ -728,10 +729,11 @@
728729
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
729730
<argument name="contentType" value="PageBuilderVideoContentType"/>
730731
</actionGroup>
731-
<actionGroup ref="validateVideo" stepKey="validateStorefront">
732-
<argument name="page" value="VideoOnStorefront"/>
733-
<argument name="url" value="PageBuilderVideoUrl_YouTube"/>
734-
<argument name="width" value="PageBuilderVideoWidth_500"/>
732+
<actionGroup ref="validateContentTypeInsideContainerStorefront" stepKey="checkContentTypeInContainerStorefront">
733+
<argument name="contentType" value="PageBuilderVideoContentType"/>
734+
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
735+
<argument name="contentTypeIndex" value="1"/>
736+
<argument name="containerTargetIndex" value="1"/>
735737
</actionGroup>
736738
</test>
737739
</tests>

0 commit comments

Comments
 (0)