Skip to content

Commit 717f89d

Browse files
committed
#544: Configurable Page Builder Full Screen Mode
- Code Review Feedback/Amends - Adding `VerifyFullScreen` Action Group - Stabilising Tests
1 parent 6d47ca5 commit 717f89d

File tree

5 files changed

+22
-3
lines changed

5 files changed

+22
-3
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup/OpenPageBuilderFullScreenActionGroup.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
8+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
109
<actionGroup name="openPageBuilderFullScreen">
1110
<waitForElementVisible selector="{{PageBuilderStage.openFullScreen}}" stepKey="waitForFullScreenButton"/>
1211
<click selector="{{PageBuilderStage.openFullScreen}}" stepKey="clickFullScreenButton"/>

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup/ValidatePageBuilderPreviewActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
</arguments>
1616
<waitForElementVisible selector="{{pageBuilderArea}}{{PageBuilderStage.editWithPageBuilderButton}}" stepKey="waitForEditWithPageBuilderButton"/>
1717
<see userInput="Edit with Page Builder" selector="{{pageBuilderArea}}{{PageBuilderStage.editWithPageBuilderButton}}" stepKey="seeEditWithPageBuilderButton"/>
18-
<seeElementInDOM selector="{{pageBuilderArea}}{{PageBuilderStage.stageSnapshot}}" stepKey="seeStageSnapshot"/>
18+
<waitForElementVisible selector="{{pageBuilderArea}}{{PageBuilderStage.stageSnapshot}}" stepKey="seeStageSnapshot"/>
1919
<dontSeeElement selector="{{PageBuilderPanel.leftPanel}}" stepKey="dontSeePageBuilderContentTypePanel"/>
2020
<dontSeeElementInDOM selector="{{pageBuilderArea}}{{PageBuilderStage.applyTemplateButton}}" stepKey="dontSeePageBuilderApplyTemplateButton"/>
2121
<dontSeeElementInDOM selector="{{pageBuilderArea}}{{PageBuilderStage.saveAsTemplateButton}}" stepKey="dontSeePageBuilderSaveAsTemplateButton"/>
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
9+
<actionGroup name="VerifyFullScreen">
10+
<waitForElementVisible selector="{{PageBuilderStage.editWithPageBuilderButton}}" stepKey="waitForEditWithPageBuilderButton"/>
11+
<click selector="{{PageBuilderStage.editWithPageBuilderButton}}" stepKey="clickEditWithPageBuilderButton"/>
12+
<waitForPageLoad stepKey="waitForFullScreenAnimation"/>
13+
<seeElement selector="{{PageBuilderStage.stageWrapperFullScreen}}" stepKey="seeStageFullScreen"/>
14+
<seeElement selector="{{PageBuilderStage.exitFullScreen}}" stepKey="seeExitFullScreenButton"/>
15+
</actionGroup>
16+
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCatalogCategoryDisablePageBuilderTest/PageBuilderCategoryDisablePageBuilderStageTest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@
3838
</actionGroup>
3939
<reloadPage stepKey="reloadPage"/>
4040
<waitForPageLoad stepKey="waitForPageLoad"/>
41+
<actionGroup ref="ExpandAdminProductSectionActionGroup" stepKey="expandAdminProductSection"/>
4142
<dontSeeElementInDOM selector="{{PageBuilderStage.stageSnapshot}}" stepKey="dontSeeStageSnapshot"/>
43+
<actionGroup ref="VerifyFullScreen" stepKey="verifyFullScreen"/>
4244
</test>
4345
</tests>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCatalogProductDisablePageBuilderTest/PageBuilderProductDisablePageBuilderStageTest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@
4242
</actionGroup>
4343
<reloadPage stepKey="reloadPage"/>
4444
<waitForPageLoad stepKey="waitForPageLoad"/>
45+
<actionGroup ref="ExpandAdminProductSectionActionGroup" stepKey="expandAdminProductSection"/>
4546
<dontSeeElementInDOM selector="{{PageBuilderStage.stageSnapshot}}" stepKey="dontSeeStageSnapshot"/>
47+
<actionGroup ref="VerifyFullScreen" stepKey="verifyFullScreen"/>
4648
</test>
4749
</tests>

0 commit comments

Comments
 (0)