AC-11662 CSP - improve script rendering

tranthienbinh1989 · tranthienbinh1989 · commit 7110c7ea6925 · 2024-03-25T14:40:25.000-05:00
diff --git a/app/code/Magento/PageBuilder/view/base/templates/googlemaps.phtml b/app/code/Magento/PageBuilder/view/base/templates/googlemaps.phtml
@@ -32,7 +32,7 @@ $script = <<<SCRIPT
         }
     });
 SCRIPT;
-echo $secureRenderer->renderTag('script', [], $script, false);
+echo /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false);
 ?>
 
 <?php
@@ -48,6 +48,6 @@ if ($block->shouldIncludeGoogleMapsLibrary()) {
         }
     });
 SCRIPT;
-echo $secureRenderer->renderTag('script', [], $script, false);
+    echo /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false);
 }
 ?>

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ $script = <<<SCRIPT`
`32`	`32`	`}`
`33`	`33`	`});`
`34`	`34`	`SCRIPT;`
`35`		`-echo $secureRenderer->renderTag('script', [], $script, false);`
	`35`	`+echo /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false);`
`36`	`36`	`?>`
`37`	`37`
`38`	`38`	`<?php`
`@@ -48,6 +48,6 @@ if ($block->shouldIncludeGoogleMapsLibrary()) {`
`48`	`48`	`}`
`49`	`49`	`});`
`50`	`50`	`SCRIPT;`
`51`		`-echo $secureRenderer->renderTag('script', [], $script, false);`
	`51`	`+ echo /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false);`
`52`	`52`	`}`
`53`	`53`	`?>`