Skip to content

Commit 71010ff

Browse files
committed
PB-95: Video background for Row
1 parent d0208c0 commit 71010ff

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/BackgroundFormData.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -550,24 +550,24 @@
550550
<data key="section">background</data>
551551
<data key="fieldName">video_lazy_load</data>
552552
<data key="value">true</data>
553-
<data key="helperText">Preload videos only when it is visible on the screen.</data>
553+
<data key="helperText">Preload video only when it is visible on the screen.</data>
554554
</entity>
555555
<entity name="PageBuilderVideoBackgroundLazyLoad_Disabled" type="pagebuilder_video_background_lazy_load">
556556
<data key="name">Lazy Load</data>
557557
<data key="section">background</data>
558558
<data key="fieldName">video_lazy_load</data>
559559
<data key="value">false</data>
560560
</entity>
561-
<!-- Video: Play Only Visible -->
561+
<!-- Video: Play Only When Visible -->
562562
<entity name="PageBuilderVideoBackgroundPlayOnlyVisible_Enabled" type="pagebuilder_video_background_play_only_visible">
563-
<data key="name">Play Only Visible</data>
563+
<data key="name">Play Only When Visible</data>
564564
<data key="section">background</data>
565565
<data key="fieldName">video_play_only_visible</data>
566566
<data key="value">true</data>
567567
<data key="helperText">Video will play only when it is visible on the screen.</data>
568568
</entity>
569569
<entity name="PageBuilderVideoBackgroundPlayOnlyVisible_Disabled" type="pagebuilder_video_background_play_only_visible">
570-
<data key="name">Play Only Visible</data>
570+
<data key="name">Play Only When Visible</data>
571571
<data key="section">background</data>
572572
<data key="fieldName">video_play_only_visible</data>
573573
<data key="value">false</data>

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_base_form_with_background_video.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@
162162
<imports>
163163
<link name="visible">${$.parentName}.background_type:videoVisible</link>
164164
</imports>
165-
<notice translate="true">Preload videos only when it is visible on the screen.</notice>
165+
<notice translate="true">Preload video only when it is visible on the screen.</notice>
166166
</settings>
167167
<formElements>
168168
<checkbox>
@@ -185,7 +185,7 @@
185185
<settings>
186186
<visible>false</visible>
187187
<dataType>boolean</dataType>
188-
<label translate="true">Play Only Visible</label>
188+
<label translate="true">Play Only When Visible</label>
189189
<dataScope>video_play_only_visible</dataScope>
190190
<notice translate="true">Video will play only when it is visible on the screen.</notice>
191191
<imports>

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/video/converter/attribute/src.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/video/converter/attribute/src.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export default class Src implements ConverterInterface {
4040
"(?:youtu\\.be\/|youtube\\.com\/(?:embed\/|v\/|watch\\?v=|watch\\?.+&v=))([\\w-]{11})(?![\\w-])");
4141
const vimeoRegExp = new RegExp("https?:\/\/(?:www\\.|player\\.)?vimeo.com\/(?:channels\/" +
4242
"(?:\\w+\/)?|groups\/([^\/]*)\/videos\/|album\/(\\d+)\/video\/|video\/|)(\\d+)(?:$|\/|\\?)");
43-
const fileRegExp = new RegExp("^(?:https:)?\\/\\/.*[\\\\\\/].+\\.(webm|mp4|ogv)(?!\w)");
43+
const fileRegExp = new RegExp("^(?:https:|http:)?\\/\\/.*[\\\\\\/].+\\.(webm|mp4|ogv)(?!\w)");
4444

4545
if (youtubeRegExp.test(value)) {
4646
return "https://www.youtube.com/embed/" + youtubeRegExp.exec(value)[1];

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/types/jarallax.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ interface JarallaxOptions {
113113
videoPlayOnlyVisible?: boolean;
114114

115115
/**
116-
* Preload videos only when it is visible on the screen.
116+
* Preload video only when it is visible on the screen.
117117
*/
118118
videoLazyLoading?: boolean;
119119

0 commit comments

Comments
 (0)