Skip to content

Commit 70ae787

Browse files
committed
MC-4014: PageBuilder Performance Is Bad With Minimal Content
- Update filter to use find for performance improvements
1 parent 405cdfd commit 70ae787

File tree

2 files changed

+13
-7
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+13
-7
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slide/preview.js

Lines changed: 6 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slide/preview.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,10 @@ export default class Preview extends BasePreview {
166166
},
167167
() => this.element.classList.contains("mce-edit-focus"),
168168
10,
169-
));
169+
)).catch((error) => {
170+
// If there's an error with init of WYSIWYG editor push into the console to aid support
171+
console.error(error);
172+
});
170173
});
171174
} else {
172175
activate();
@@ -418,9 +421,9 @@ export default class Preview extends BasePreview {
418421
*/
419422
private findTextNode(element: JQuery, text: string): HTMLElement {
420423
if (text && text.trim().length > 0) {
421-
return element.contents().filter(function() {
422-
return this.nodeType === Node.TEXT_NODE && text === this.nodeValue;
423-
})[0];
424+
return element.contents().toArray().find((node: HTMLElement) => {
425+
return node.nodeType === Node.TEXT_NODE && text === node.nodeValue;
426+
});
424427
}
425428
}
426429
}

0 commit comments

Comments
 (0)