Skip to content

Commit 70972df

Browse files
committed
PB-366: Templates Lower Level Test Coverage
- Fix issue with grid sorting - Fix issue
1 parent a678d4b commit 70972df

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

app/code/Magento/PageBuilder/Controller/Adminhtml/Template/Save.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,16 +185,15 @@ public function execute()
185185
*/
186186
private function validate(RequestInterface $request)
187187
{
188+
$name = trim($request->getParam(TemplateInterface::KEY_NAME, ""));
188189
// If we're missing required data return an error
189-
if (trim($request->getParam(TemplateInterface::KEY_NAME, "")) === ""
190-
|| !$request->getParam(TemplateInterface::KEY_TEMPLATE)
191-
) {
190+
if ($name === "" || !$request->getParam(TemplateInterface::KEY_TEMPLATE)) {
192191
throw new LocalizedException(__('A required field is missing.'));
193192
}
194193

195194
// Verify a template of the same name does not already exist
196195
$searchCriteria = $this->searchCriteriaBuilder
197-
->addFilter(TemplateInterface::KEY_NAME, $request->getParam(TemplateInterface::KEY_NAME))
196+
->addFilter(TemplateInterface::KEY_NAME, $name)
198197
->create();
199198
$results = $this->templateRepository->getList($searchCriteria);
200199
if ($results->getTotalCount() > 0) {

app/code/Magento/PageBuilder/Ui/Component/Template/DataProvider.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
namespace Magento\PageBuilder\Ui\Component\Template;
1010

11+
use Magento\Cms\Ui\Component\AddFilterInterface;
1112
use Magento\Framework\Api\Filter;
1213
use Magento\Framework\Api\FilterBuilder;
1314
use Magento\Framework\Api\Search\SearchCriteriaBuilder;

app/code/Magento/PageBuilder/etc/adminhtml/di.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -522,10 +522,10 @@
522522
<item name="html_display_content_type" xsi:type="string">html</item>
523523
<item name="template_types" xsi:type="array">
524524
<item name="any" xsi:type="string">Any</item>
525-
<item name="cms_page" xsi:type="string">Page</item>
526-
<item name="catalog_product" xsi:type="string">Product</item>
527-
<item name="catalog_category" xsi:type="string">Category</item>
528-
<item name="cms_block" xsi:type="string">Block</item>
525+
<item name="page" xsi:type="string">Page</item>
526+
<item name="product" xsi:type="string">Product</item>
527+
<item name="category" xsi:type="string">Category</item>
528+
<item name="block" xsi:type="string">Block</item>
529529
<item name="dynamic_block" xsi:type="string">Dynamic Block</item>
530530
</item>
531531
</argument>

0 commit comments

Comments
 (0)