MC-3095: Display TypeScript errors within local build process

- Resolve further TypeScript issues

Author: davemacaulay

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/appearance-config.js

@@ -5,7 +5,7 @@
 
 import events from "uiEvents";
 import ContentTypeInterface from "../content-type";
-import DataStore from "../data-store";
+import DataStore, {DataObject} from "../data-store";
 
 export default class Edit {
     private instance: ContentTypeInterface;
@@ -27,12 +27,12 @@ export default class Edit {
      * Open the modal
      */
     public open(): void {
-        const contentTypeData = this.dataStore.get();
+        const contentTypeData = this.dataStore.get() as DataObject;
         let formNamespace = this.instance.config.form;
 
         // Use the default form unless a custom one is defined
-        if (undefined !== this.instance.config.appearances[contentTypeData.appearance].form) {
-            formNamespace = this.instance.config.appearances[contentTypeData.appearance].form;
+        if (undefined !== this.instance.config.appearances[contentTypeData.appearance as string].form) {
+            formNamespace = this.instance.config.appearances[contentTypeData.appearance as string].form;
         }
 
         events.trigger("form:renderAfter", {

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/master-factory.js

@@ -3,11 +3,11 @@
  * See COPYING.txt for license details.
  */
 
+import ValueInterface from "./value.d";
+
 /**
  * @api
  */
-import ValueInterface from "./value.d";
-
 export interface OptionInterface {
     key: string;
     type: string;

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/observable-updater.js

@@ -5,7 +5,7 @@
 /**
  * @api
  */
-export interface ValueInterface {
+export default interface ValueInterface {
     value: string;
     label: string;
     icon: string;

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/preview-converter-resolver.js

@@ -4,18 +4,22 @@
  */
 
 import Config from "../config";
+import {ContentTypeConfigAppearanceInterface} from "../content-type-config";
 
 /**
  * Get config for appearance
  *
  * @param {string} contentType
  * @param {string} appearance
- * @returns {Object}
+ * @returns {ContentTypeConfigAppearanceInterface}
  * @api
  */
-export default function getAppearanceConfig(contentType: string, appearance: string): object {
+export default function getAppearanceConfig(
+    contentType: string,
+    appearance: string,
+): ContentTypeConfigAppearanceInterface {
     const contentTypeConfig = Config.getContentTypeConfig(contentType);
-    let config = {};
+    let config: ContentTypeConfigAppearanceInterface;
     if (contentTypeConfig.appearances !== undefined) {
         if (!appearance) {
             for (const key in contentTypeConfig.appearances) {

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/preview-factory.js

@@ -7,6 +7,8 @@ import loadModule from "Magento_PageBuilder/js/utils/loader";
 import ContentTypeConfigInterface from "../content-type-config.d";
 import ContentTypeInterface from "../content-type.d";
 import converterResolver from "./converter-resolver";
+import Master from "./master";
+import MasterCollection from "./master-collection";
 import observableUpdaterFactory from "./observable-updater-factory";
 
 /**
@@ -20,12 +22,12 @@ import observableUpdaterFactory from "./observable-updater-factory";
 export default function create(
     contentType: ContentTypeInterface,
     config: ContentTypeConfigInterface,
-): Promise<ContentTypeInterface> {
+): Promise<typeof Master | typeof MasterCollection> {
     return new Promise((resolve: (masterComponent: any) => void) => {
         observableUpdaterFactory(config, converterResolver).then((observableUpdater) => {
-            loadModule([config.master_component], (ContentComponent) => {
+            loadModule([config.master_component], (contentComponent: typeof Master | typeof MasterCollection) => {
                 resolve(
-                    new ContentComponent(
+                    new contentComponent(
                         contentType,
                         observableUpdater,
                     ),