Skip to content

Commit 6dd33b0

Browse files
paras89paras89
committed
PB-500 test coverage cleanup - added test case ids and post test clean up
1 parent 56d882c commit 6dd33b0

File tree

4 files changed

+33
-24
lines changed

4 files changed

+33
-24
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnGroupTest/ColumnGroupDuplicateAndHideTest.xml

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Columns"/>
14-
<title value="Test Column Groups can be duplicated and hidden"/>
14+
<title value="[Columns] Verify that user can hide and duplicate Column Group"/>
1515
<description value="A user should be able to duplicate and hide column groups"/>
1616
<severity value="MAJOR"/>
17-
<useCaseId value=""/>
18-
<testCaseId value=""/>
17+
<testCaseId value="PB-1202"/>
1918
<group value="pagebuilder"/>
2019
<group value="pagebuilder-column"/>
2120
<group value="pagebuilder-column-group"/>
@@ -29,6 +28,20 @@
2928
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
3029
</before>
3130
<after>
31+
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
32+
<actionGroup ref="NavigateToMediaGalleryActionGroup" stepKey="navigateToMediaGallery"/>
33+
<actionGroup ref="NavigateToMediaFolderActionGroup" stepKey="NavigateToFolder">
34+
<argument name="FolderName" value="{{PageBuilderColumnGroupDesktopImage_PNG.path}}"/>
35+
</actionGroup>
36+
<actionGroup ref="DeleteImageFromStorageActionGroup" stepKey="DeleteDesktopImageFromStorage">
37+
<argument name="Image" value="PageBuilderColumnGroupDesktopImage_PNG"/>
38+
</actionGroup>
39+
<actionGroup ref="DeleteImageFromStorageActionGroup" stepKey="DeleteColumnGroupMobileImageFromStorage">
40+
<argument name="Image" value="PageBuilderColumnGroupMobileImage_PNG"/>
41+
</actionGroup>
42+
<actionGroup ref="DeleteImageFromStorageActionGroup" stepKey="DeleteColumnOneDesktopImageFromStorage">
43+
<argument name="Image" value="PageBuilderColumnOneDesktopImage_PNG"/>
44+
</actionGroup>
3245
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
3346
</after>
3447
<actionGroup ref="dragContentTypeToStage" stepKey="dragColumnsToRootContainer">

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnGroupTest/ColumnGroupEditSettingsAndVerifyTest.xml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Columns"/>
14-
<title value="Edit existing Column Group and Column content type settings and verify"/>
15-
<description value="A user should be able edit Column and Column Group content type settings"/>
14+
<title value="[Columns] Edit/Update Column Group with two columns and verify on Storefront"/>
15+
<description value="A user should be able edit Column and Column Group content type settings and see the changes on Storefront"/>
1616
<severity value="MAJOR"/>
17-
<useCaseId value=""/>
18-
<testCaseId value=""/>
17+
<testCaseId value="PB-1198"/>
1918
<group value="pagebuilder"/>
2019
<group value="pagebuilder-column"/>
2120
<group value="pagebuilder-column-group"/>
@@ -100,8 +99,8 @@
10099
<actionGroup ref="AdminSaveAndContinueEditCmsPageActionGroup" stepKey="saveSecondTimeAndContinueEditCmsPage"/>
101100
<actionGroup ref="switchToPageBuilderStage" stepKey="switchSecondTimeToPageBuilderStage"/>
102101
<!-- Verify Storefront -->
103-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
104-
<argument name="contentType" value="PageBuilderColumnGroupContentType"/>
102+
<actionGroup ref="NavigateToStorefrontForCreatedPageActionGroup" stepKey="navigateToStoreFront">
103+
<argument name="page" value="$$createCMSPage.identifier$$"/>
105104
</actionGroup>
106105
<!-- Verify Column One -->
107106
<actionGroup ref="ValidateAllBackgroundAttributesActionGroup" stepKey="validateColumnOneBackgroundOnStorefront">

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnGroupTest/ColumnGroupSettingsFrontendTest.xml

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,17 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Columns"/>
14-
<title value="Test Column groups and Column content type settings on the front-end"/>
15-
<description value="A user should be able to see column group settings changes on the front-end"/>
14+
<title value="[Columns] Verify Column Group with two columns on Storefront"/>
15+
<description value="A user should be able to see effects of column and column group settings changes on the front-end"/>
1616
<severity value="MAJOR"/>
17-
<useCaseId value=""/>
18-
<testCaseId value=""/>
17+
<testCaseId value="PB-1197"/>
1918
<group value="pagebuilder"/>
2019
<group value="pagebuilder-column"/>
2120
<group value="pagebuilder-column-group"/>
2221
</annotations>
23-
<after>
24-
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop" before="logout"/>
25-
</after>
2622
<!-- Verify Storefront -->
27-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
28-
<argument name="contentType" value="PageBuilderColumnGroupContentType"/>
23+
<actionGroup ref="NavigateToStorefrontForCreatedPageActionGroup" stepKey="navigateToStoreFront">
24+
<argument name="page" value="$$createCMSPage.identifier$$"/>
2925
</actionGroup>
3026
<!-- Verify Column Group -->
3127
<seeNumberOfElements selector="{{ColumnOnFrontend.allColumns}}" userInput="2" stepKey="seeNumberOfColumns2"/>
@@ -146,5 +142,6 @@
146142
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachment_Scroll"/>
147143
<argument name="index" value="2"/>
148144
</actionGroup>
145+
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop"/>
149146
</test>
150147
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnGroupTest/ColumnGroupSettingsTest.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,24 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Columns"/>
14-
<title value="Test Column groups and Column content type settings"/>
14+
<title value="[Columns] Create Column Group with two columns and check in Admin Panel"/>
1515
<description value="A user should be able to change settings for a column group and its columns"/>
1616
<severity value="MAJOR"/>
17-
<useCaseId value=""/>
18-
<testCaseId value=""/>
17+
<testCaseId value="PB-1196"/>
1918
<group value="pagebuilder"/>
2019
<group value="pagebuilder-column"/>
2120
<group value="pagebuilder-column-group"/>
2221
</annotations>
2322
<before>
23+
<createData entity="_emptyCmsPage" stepKey="createCMSPage"/>
2424
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
25-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
26-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
27-
<argument name="contentType" value="PageBuilderColumnGroupContentType"/>
25+
<actionGroup ref="navigateToCMSPage" stepKey="navigateToCMSPage">
26+
<argument name="CMSPage" value="$$createCMSPage$$"/>
2827
</actionGroup>
2928
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
3029
</before>
3130
<after>
31+
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
3232
<actionGroup ref="NavigateToMediaGalleryActionGroup" stepKey="navigateToMediaGallery"/>
3333
<actionGroup ref="NavigateToMediaFolderActionGroup" stepKey="NavigateToFolder">
3434
<argument name="FolderName" value="{{PageBuilderColumnGroupDesktopImage_PNG.path}}"/>

0 commit comments

Comments
 (0)