Skip to content

Commit 6d192d0

Browse files
author
Hwashiang Yu
committed
MC-4290: Alignment Doesn't Work For Slide, Banners, & Text Placeholders & for Slide Content & Banner Poster Content
- Updated slider inheritance tests groups - Added testing for slider and banner button alignment inheritance - Updated test severity - Added alignment section for start
1 parent 977921c commit 6d192d0

12 files changed

+94
-13
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Data/AdvancedData.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@
1616
<data key="value"/>
1717
<data key="optionsList">[Default, Left, Center, Right]</data>
1818
</entity>
19+
<entity name="PageBuilderAdvancedAlignmentPropertyStart" type="pagebuilder_advanced_alignment_property">
20+
<data key="name">Alignment</data>
21+
<data key="section">advanced</data>
22+
<data key="fieldName">text_align</data>
23+
<data key="value">start</data>
24+
</entity>
1925
<entity name="PageBuilderAdvancedAlignmentPropertyLeft" type="pagebuilder_advanced_alignment_property">
2026
<data key="name">Alignment</data>
2127
<data key="section">advanced</data>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1347,7 +1347,7 @@
13471347
<stories value="Banner"/>
13481348
<title value="Collage Center - Alignment Inherits"/>
13491349
<description value="A user should be able to have a parent container content type pass its alignment to its children"/>
1350-
<severity value="CRITICAL"/>
1350+
<severity value="MAJOR"/>
13511351
<useCaseId value="MC-4290"/>
13521352
<testCaseId value="MC-6018"/>
13531353
<group value="pagebuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1369,7 +1369,7 @@
13691369
<stories value="Banner"/>
13701370
<title value="Collage Left - Alignment Inherits"/>
13711371
<description value="A user should be able to have a parent container content type pass its alignment to its children"/>
1372-
<severity value="CRITICAL"/>
1372+
<severity value="MAJOR"/>
13731373
<useCaseId value="MC-4290"/>
13741374
<testCaseId value="MC-6017"/>
13751375
<group value="pagebuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageRightAppearanceTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1251,7 +1251,7 @@
12511251
<stories value="Banner"/>
12521252
<title value="Collage Right - Alignment Inherits"/>
12531253
<description value="A user should be able to have a parent container content type pass its alignment to its children"/>
1254-
<severity value="CRITICAL"/>
1254+
<severity value="MAJOR"/>
12551255
<useCaseId value="MC-4290"/>
12561256
<testCaseId value="MC-6016"/>
12571257
<group value="pagebuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 35 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1783,7 +1783,7 @@
17831783
<stories value="Banner"/>
17841784
<title value="Poster - Alignment Inherits"/>
17851785
<description value="A user should be able to have a parent container content type pass its alignment to its children"/>
1786-
<severity value="CRITICAL"/>
1786+
<severity value="MAJOR"/>
17871787
<useCaseId value="MC-4290"/>
17881788
<testCaseId value="MC-6015"/>
17891789
<group value="pagebuilder"/>
@@ -1821,10 +1821,29 @@
18211821
<argument name="property" value="PageBuilderBannerMessageProperty"/>
18221822
<argument name="section" value="BannerOnConfigurationPanel"/>
18231823
</actionGroup>
1824+
<actionGroup ref="selectSlideOutPanelField" stepKey="selectShowButton">
1825+
<argument name="property" value="PageBuilderBannerShowButtonAlwaysProperty"/>
1826+
</actionGroup>
1827+
<actionGroup ref="selectSlideOutPanelField" stepKey="selectButtonType">
1828+
<argument name="property" value="PageBuilderBannerButtonTypePrimaryProperty"/>
1829+
</actionGroup>
1830+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterButtonText">
1831+
<argument name="property" value="PageBuilderBannerButtonTextProperty"/>
1832+
</actionGroup>
18241833
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAlignmentDefault">
18251834
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyDefault"/>
18261835
</actionGroup>
18271836
<actionGroup ref="saveEditPanelSettings" stepKey="saveBannerEditPanelSettings"/>
1837+
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{BannerOnBackend.button('1')}}&quot;, document.body).iterateNext()).textAlign" stepKey="grabDefaultButtonComputedTextAlign"/>
1838+
<assertEquals stepKey="assertDefaultButtonComputedTextAlign">
1839+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyStart.value}}</expectedResult>
1840+
<actualResult type="variable">grabDefaultButtonComputedTextAlign</actualResult>
1841+
</assertEquals>
1842+
<executeJS function="return window.getComputedStyle({{BannerOnBackend.wrapperJS('1')}}).textAlign" stepKey="grabDefaultComputedTextAlign"/>
1843+
<assertEquals stepKey="assertDefaultComputedTextAlign">
1844+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyStart.value}}</expectedResult>
1845+
<actualResult type="variable">grabDefaultComputedTextAlign</actualResult>
1846+
</assertEquals>
18281847
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusBannerEditor"/>
18291848
<!-- Fill Out Row Edit Panel -->
18301849
<comment userInput="Fill Out Row Edit Panel" stepKey="commentFillRowEditPanel"/>
@@ -1839,6 +1858,11 @@
18391858
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusRowEditor"/>
18401859
<!-- Validate Stage -->
18411860
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
1861+
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{BannerOnBackend.button('1')}}&quot;, document.body).iterateNext()).textAlign" stepKey="grabButtonComputedTextAlign"/>
1862+
<assertEquals stepKey="assertButtonComputedTextAlign">
1863+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>
1864+
<actualResult type="variable">grabButtonComputedTextAlign</actualResult>
1865+
</assertEquals>
18421866
<executeJS function="return window.getComputedStyle({{BannerOnBackend.wrapperJS('1')}}).textAlign" stepKey="grabComputedTextAlign"/>
18431867
<assertEquals stepKey="assertComputedTextAlign">
18441868
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>
@@ -1848,6 +1872,11 @@
18481872
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
18491873
<!-- Validate Stage After Save -->
18501874
<comment userInput="Validate Stage After Save" stepKey="commentValidateStageAfterSave"/>
1875+
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{BannerOnBackend.button('1')}}&quot;, document.body).iterateNext()).textAlign" stepKey="grabButtonComputedTextAlignAfterSave"/>
1876+
<assertEquals stepKey="assertButtonComputedTextAlignAfterSave">
1877+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>
1878+
<actualResult type="variable">grabButtonComputedTextAlignAfterSave</actualResult>
1879+
</assertEquals>
18511880
<executeJS function="return window.getComputedStyle({{BannerOnBackend.wrapperJS('1')}}).textAlign" stepKey="grabComputedTextAlignAfterSave"/>
18521881
<assertEquals stepKey="assertComputedTextAlignAfterSave">
18531882
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>
@@ -1858,6 +1887,11 @@
18581887
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
18591888
<argument name="contentType" value="PageBuilderBannerContentType"/>
18601889
</actionGroup>
1890+
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{BannerOnFrontend.button('1')}}&quot;, document.body).iterateNext()).textAlign" stepKey="grabButtonComputedTextAlignStoreFront"/>
1891+
<assertEquals stepKey="assertButtonComputedTextAlignStoreFront">
1892+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>
1893+
<actualResult type="variable">grabButtonComputedTextAlignStoreFront</actualResult>
1894+
</assertEquals>
18611895
<executeJS function="return window.getComputedStyle({{BannerOnFrontend.wrapperJS('1')}}).textAlign" stepKey="grabComputedTextAlignStoreFront"/>
18621896
<assertEquals stepKey="assertComputedTextAlignStoreFront">
18631897
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageCenterTests.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -659,11 +659,11 @@
659659
<stories value="Slider"/>
660660
<title value="Collage Center - Alignment Inherits"/>
661661
<description value="A user should be able to have a parent container content type pass its alignment to its children"/>
662-
<severity value="CRITICAL"/>
662+
<severity value="MAJOR"/>
663663
<useCaseId value="MC-4290"/>
664664
<testCaseId value="MC-6025"/>
665665
<group value="pagebuilder"/>
666-
<group value="pagebuilder-slider"/>
666+
<group value="pagebuilder-slide"/>
667667
<group value="pagebuilder-sliderCollageCenter"/>
668668
</annotations>
669669
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageLeftTests.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -583,11 +583,11 @@
583583
<stories value="Slider"/>
584584
<title value="Collage Left - Alignment Inherits"/>
585585
<description value="A user should be able to have a parent container content type pass its alignment to its children"/>
586-
<severity value="CRITICAL"/>
586+
<severity value="MAJOR"/>
587587
<useCaseId value="MC-4290"/>
588588
<testCaseId value="MC-6024"/>
589589
<group value="pagebuilder"/>
590-
<group value="pagebuilder-slider"/>
590+
<group value="pagebuilder-slide"/>
591591
<group value="pagebuilder-sliderCollageLeft"/>
592592
</annotations>
593593
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageRightTests.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -433,11 +433,11 @@
433433
<stories value="Slider"/>
434434
<title value="Collage Right - Alignment Inherits"/>
435435
<description value="A user should be able to have a parent container content type pass its alignment to its children"/>
436-
<severity value="CRITICAL"/>
436+
<severity value="MAJOR"/>
437437
<useCaseId value="MC-4290"/>
438438
<testCaseId value="MC-6023"/>
439439
<group value="pagebuilder"/>
440-
<group value="pagebuilder-slider"/>
440+
<group value="pagebuilder-slide"/>
441441
<group value="pagebuilder-sliderCollageRight"/>
442442
</annotations>
443443
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 36 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1511,11 +1511,11 @@
15111511
<stories value="Slider"/>
15121512
<title value="Poster - Alignment Inherits"/>
15131513
<description value="A user should be able to have a parent container content type pass its alignment to its children"/>
1514-
<severity value="CRITICAL"/>
1514+
<severity value="MAJOR"/>
15151515
<useCaseId value="MC-4290"/>
15161516
<testCaseId value="MC-6014"/>
15171517
<group value="pagebuilder"/>
1518-
<group value="pagebuilder-slider"/>
1518+
<group value="pagebuilder-slide"/>
15191519
<group value="pagebuilder-sliderPoster"/>
15201520
</annotations>
15211521
<before>
@@ -1549,10 +1549,29 @@
15491549
<argument name="property" value="PageBuilderSlideItemContent_Slide1"/>
15501550
<argument name="section" value="SlideOnConfigurationPanel"/>
15511551
</actionGroup>
1552+
<actionGroup ref="selectSlideOutPanelField" stepKey="selectShowButton">
1553+
<argument name="property" value="PageBuilderSlideItemShowButton_Always"/>
1554+
</actionGroup>
1555+
<actionGroup ref="selectSlideOutPanelField" stepKey="selectButtonType">
1556+
<argument name="property" value="PageBuilderSlideItemButtonType_Primary"/>
1557+
</actionGroup>
1558+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterButtonText">
1559+
<argument name="property" value="PageBuilderSlideItemButtonText_Common"/>
1560+
</actionGroup>
15521561
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAlignmentDefault">
15531562
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyDefault"/>
15541563
</actionGroup>
15551564
<actionGroup ref="saveEditPanelSettings" stepKey="saveSlideItemEditPanelSettings"/>
1565+
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{SlideOnBackend.button('1')}}&quot;, document.body).iterateNext()).textAlign" stepKey="grabDefaultButtonComputedTextAlign"/>
1566+
<assertEquals stepKey="assertDefaultButtonComputedTextAlign">
1567+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyStart.value}}</expectedResult>
1568+
<actualResult type="variable">grabDefaultButtonComputedTextAlign</actualResult>
1569+
</assertEquals>
1570+
<executeJS function="return window.getComputedStyle({{SlideOnBackend.contentJS('1')}}).textAlign" stepKey="grabDefaultComputedTextAlign"/>
1571+
<assertEquals stepKey="assertDefaultComputedTextAlign">
1572+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyStart.value}}</expectedResult>
1573+
<actualResult type="variable">grabDefaultComputedTextAlign</actualResult>
1574+
</assertEquals>
15561575
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusSlideItemEditor"/>
15571576
<!-- Fill Out Row Edit Panel -->
15581577
<comment userInput="Fill Out Row Edit Panel" stepKey="commentFillRowEditPanel"/>
@@ -1567,6 +1586,11 @@
15671586
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusRowEditor"/>
15681587
<!-- Validate Stage -->
15691588
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
1589+
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{SlideOnBackend.button('1')}}&quot;, document.body).iterateNext()).textAlign" stepKey="grabButtonComputedTextAlign"/>
1590+
<assertEquals stepKey="assertButtonComputedTextAlign">
1591+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>
1592+
<actualResult type="variable">grabButtonComputedTextAlign</actualResult>
1593+
</assertEquals>
15701594
<executeJS function="return window.getComputedStyle({{SlideOnBackend.contentJS('1')}}).textAlign" stepKey="grabComputedTextAlign"/>
15711595
<assertEquals stepKey="assertComputedTextAlign">
15721596
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>
@@ -1576,6 +1600,11 @@
15761600
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
15771601
<!-- Validate Stage After Save -->
15781602
<comment userInput="Validate Stage After Save" stepKey="commentValidateStageAfterSave"/>
1603+
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{SlideOnBackend.button('1')}}&quot;, document.body).iterateNext()).textAlign" stepKey="grabButtonComputedTextAlignAfterSave"/>
1604+
<assertEquals stepKey="assertButtonComputedTextAlignAfterSave">
1605+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>
1606+
<actualResult type="variable">grabButtonComputedTextAlignAfterSave</actualResult>
1607+
</assertEquals>
15791608
<executeJS function="return window.getComputedStyle({{SlideOnBackend.contentJS('1')}}).textAlign" stepKey="grabComputedTextAlignAfterSave"/>
15801609
<assertEquals stepKey="assertComputedTextAlignAfterSave">
15811610
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>
@@ -1586,6 +1615,11 @@
15861615
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
15871616
<argument name="contentType" value="PageBuilderSliderContentType"/>
15881617
</actionGroup>
1618+
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{SlideOnFrontend.button('1')}}&quot;, document.body).iterateNext()).textAlign" stepKey="grabButtonComputedTextAlignStoreFront"/>
1619+
<assertEquals stepKey="assertButtonComputedTextAlignStoreFront">
1620+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>
1621+
<actualResult type="variable">grabButtonComputedTextAlignStoreFront</actualResult>
1622+
</assertEquals>
15891623
<executeJS function="return window.getComputedStyle({{SlideOnFrontend.contentJS('1')}}).textAlign" stepKey="grabComputedTextAlignStoreFront"/>
15901624
<assertEquals stepKey="assertComputedTextAlignStoreFront">
15911625
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyRight.value}}</expectedResult>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2615,7 +2615,7 @@
26152615
<stories value="Text"/>
26162616
<title value="Text - Alignment Inherits"/>
26172617
<description value="A user should be able to have a parent container content type pass its alignment to its children"/>
2618-
<severity value="CRITICAL"/>
2618+
<severity value="MAJOR"/>
26192619
<useCaseId value="MC-4290"/>
26202620
<testCaseId value="MC-6019"/>
26212621
<group value="pagebuilder"/>
@@ -2653,6 +2653,11 @@
26532653
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyDefault"/>
26542654
</actionGroup>
26552655
<actionGroup ref="saveEditPanelSettings" stepKey="saveTextEditPanelSettings"/>
2656+
<executeJS function="return window.getComputedStyle({{TextOnStage.contentJS('1')}}).textAlign" stepKey="grabDefaultComputedTextAlign"/>
2657+
<assertEquals stepKey="assertDefaultComputedTextAlign">
2658+
<expectedResult type="string">{{PageBuilderAdvancedAlignmentPropertyStart.value}}</expectedResult>
2659+
<actualResult type="variable">grabDefaultComputedTextAlign</actualResult>
2660+
</assertEquals>
26562661
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusTextEditor2"/>
26572662
<!-- Fill Out Row Edit Panel -->
26582663
<comment userInput="Fill Out Row Edit Panel" stepKey="commentFillRowEditPanel"/>

0 commit comments

Comments
 (0)