Skip to content

Commit 6cee3ed

Browse files
committed
Merge remote-tracking branch 'origin/MC-1438' into MC-1438
# Conflicts: # app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml
2 parents 7ca9901 + 8cb75af commit 6cee3ed

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/TextData.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<data key="fieldName">text</data>
1616
<data key="cmsPageLinkName" unique="suffix">cms-page-link-</data>
1717
<data key="value">test string</data>
18+
<data key="minHeight">50px</data>
1819
</entity>
1920
<entity name="PageBuilderTextContentTypeDefault" type="pagebuilder_text_property">
2021
<data key="name">Text</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
<executeJS function="return jQuery('.inline-wysiwyg-textarea').css('min-height');" stepKey="height"/>
4747
<assertEquals stepKey="assertMinHeight">
4848
<actualResult type="variable">height</actualResult>
49-
<expectedResult type="string">50px</expectedResult>
49+
<expectedResult type="string">{{PageBuilderTextProperty.minHeight}}</expectedResult>
5050
</assertEquals>
5151
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>
5252
<!--Verify empty content type on storefront-->
@@ -142,14 +142,12 @@
142142
</annotations>
143143
<before>
144144
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
145-
<actionGroup ref="EnabledWYSIWYG" stepKey="enableWYSIWYG"/>
146145
<magentoCLI command="config:set cms/wysiwyg/editor Magento_Tinymce3/tinymce3Adapter" stepKey="enableTinyMCE3"/>
147146
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
148147
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
149148
</before>
150149
<after>
151150
<actionGroup ref="SwitchToVersion4ActionGroup" stepKey="switchToTinyMCE4" />
152-
<actionGroup ref="DisabledWYSIWYG" stepKey="disableWYSIWYG"/>
153151
<actionGroup ref="logout" stepKey="logout"/>
154152
</after>
155153
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
@@ -171,7 +169,7 @@
171169
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
172170
<argument name="contentType" value="PageBuilderTextContentType"/>
173171
</actionGroup>
174-
<!--<waitForElementVisible selector="{{TinyMCESection.TinyMCE3}}" stepKey="waitForTinyMCE3" />-->
172+
<waitForElementVisible selector="{{TinyMCESection.TinyMCE3}}" stepKey="waitForTinyMCE3" />
175173
<switchToIFrame selector="{{TextOnConfiguration.tinyMCEIFrame}}" stepKey="switchToIFrame1"/>
176174
<!-- Verify inputed text is carried out to slideout -->
177175
<comment userInput="Verify inputed text is carried out to slideout" stepKey="comment1"/>
@@ -196,7 +194,6 @@
196194
</actionGroup>
197195
<!-- Validate Storefront -->
198196
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
199-
<!--<waitForElementVisible selector="{{TextOnStorefront.textAreaWidget('1', '{{_ENV.MAGENTO_BASE_URL}}', PageBuilderPageTitle.pageName)}}" stepKey="waitForTextStorefront"/>-->
200197
<waitForElementVisible selector="{{TextOnStorefront.textAreaText('1', '$grabBaseURL')}}" stepKey="waitForVariableStorefront"/>
201198
</test>
202199
<test name="TextAddWYSIWYGContentTypeToTabOnStage">
@@ -1499,11 +1496,11 @@
14991496
<testCaseId value="MC-3670"/>
15001497
<group value="pagebuilder"/>
15011498
<group value="pagebuilder-text"/>
1502-
<!--<group value="pagebuilder-customBeforeAfter"/>-->
1499+
<group value="pagebuilder-customBeforeAfter"/>
15031500
</annotations>
15041501
<before>
15051502
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1506-
<actionGroup ref="DisabledWYSIWYG" stepKey="disableWYSIWYG"/>
1503+
<actionGroup ref="EnabledWYSIWYG" stepKey="enableWYSIWYG"/>
15071504
<actionGroup ref="enablePageBuilderSetting" stepKey="enablePageBuilderSetting"/>
15081505
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
15091506
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
@@ -1513,7 +1510,7 @@
15131510
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
15141511
</before>
15151512
<after>
1516-
<actionGroup ref="DisabledWYSIWYG" stepKey="disableWYSIWYG"/>
1513+
<actionGroup ref="en" stepKey="disableWYSIWYG"/>
15171514
<actionGroup ref="logout" stepKey="logout"/>
15181515
</after>
15191516
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">

0 commit comments

Comments
 (0)