#544: Configurable Page Builder Full Screen Mode

- Code Review Feedback/Amends

Author: bluemwhitew

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderStoreConfigurationSection.xml

@@ -12,7 +12,8 @@
         <element name="CheckIfPageBuilderTabExpanded" type="button" selector="#cms_pagebuilder-head:not(.open)"/>
         <element name="EnablePageBuilderSystemValue" type="button" selector="#cms_pagebuilder_enabled_inherit"/>
         <element name="EnablePageBuilder" type="button" selector="#cms_pagebuilder_enabled"/>
-        <element name="EnablePageBuilderContentPreview" type="button" selector="#cms_pagebuilder_enable_content_preview"/>
+        <element name="enablePageBuilderContentPreview" type="button" selector="#cms_pagebuilder_enable_content_preview"/>
+        <element name="enablePageBuilderContentPreviewComment" type="text" selector="#row_cms_pagebuilder_enable_content_preview .value .note span"/>
         <element name="DisclaimerMessage" type="text" selector="//aside[@data-type='popup']//div[@class='modal-inner-wrap']"/>
         <element name="CancelBtn" type="button" selector=".action-pagebuilder-cancel"/>
         <element name="TurnOffBtn" type="button" selector=".action-accept"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminStoreConfigurationPageBuilderEnableTest.xml

@@ -39,13 +39,9 @@
             <actualResult type="variable">grabTextFromDisclaimerMsg</actualResult>
             <expectedResult type="string">Includes advanced tools to design page layouts, add Magento content (Product and Category data, CMS content and Blocks), and format text.\n\nFor Product Attributes — Page Builder can be selected as the “input type” to design layouts and create content.</expectedResult>
         </assertEquals>
-        <seeOptionIsSelected selector="{{ContentManagementSection.EnablePageBuilderContentPreview}}" userInput="Yes" stepKey="seeEnablePageBuilderContentPreview"/>
-        <grabTextFrom selector="//tr[@id='row_cms_pagebuilder_enable_content_preview']/td[@class='value']//span" stepKey="grabTextFromEnablePageBuilderContentPreviewComment"/>
-        <assertEquals message="pass" stepKey="assertEquals3">
-            <actualResult type="variable">grabTextFromEnablePageBuilderContentPreviewComment</actualResult>
-            <expectedResult type="string">Preview Page Builder content on product and category editing pages. Setting to "No" can improve performance in case several attributes are editable by Page Builder.</expectedResult>
-        </assertEquals>
-        <!--Disable PageBuilder-->
+        <seeOptionIsSelected selector="{{ContentManagementSection.enablePageBuilderContentPreview}}" userInput="Yes" stepKey="seeEnablePageBuilderContentPreview"/>
+        <waitForText selector="{{ContentManagementSection.enablePageBuilderContentPreviewComment}}" userInput='Preview Page Builder content on product and category editing pages. Setting to "No" can improve performance in case several attributes are editable by Page Builder.' stepKey="waitForTextEnablePageBuilderContentPreviewComment"/>
+        <!-- Disable Page Builder -->
         <comment userInput="Disable PageBuilder" stepKey="commentDisablePageBuilder"/>
         <selectOption selector="{{ContentManagementSection.EnablePageBuilder}}" userInput="No" stepKey="selectNO1"/>
         <waitForElementVisible selector="{{ContentManagementSection.DisclaimerMessage}}"  stepKey="waitForPopUpMsg1" />
@@ -57,10 +53,9 @@
         <waitForElementVisible selector="{{ContentManagementSection.DisclaimerMessage}}" stepKey="waitForPopUpMsg2"/>
         <click selector="{{ContentManagementSection.TurnOffBtn}}" stepKey="selectTurnOff" />
         <dontSee selector="{{ContentManagementSection.DisclaimerMessage}}" stepKey="popupClose2"/>
-        <dontSee selector="{{ContentManagementSection.EnablePageBuilderContentPreview}}" stepKey="dontSeeEnablePageBuilderContentPreview"/>
+        <dontSee selector="{{ContentManagementSection.enablePageBuilderContentPreview}}" stepKey="dontSeeEnablePageBuilderContentPreview"/>
         <seeOptionIsSelected selector="{{ContentManagementSection.EnablePageBuilder}}" userInput="No" stepKey="seeNoIsSelected" />
         <click selector="{{ContentManagementSection.Save}}" stepKey="saveConfig" />
-        <!-- I switch between NO -> YES - > NO without saving the Config, Then: Warning message will not appear on page-->
         <comment userInput="Switch between NO -> YES - > NO" stepKey="commentTestSwitchingAfterSave"/>
         <selectOption selector="{{ContentManagementSection.EnablePageBuilder}}" userInput="No" stepKey="selectNO3"/>
         <selectOption selector="{{ContentManagementSection.EnablePageBuilder}}" userInput="Yes" stepKey="selectYes"/>