MC-10833: Resolve TypeScript errors

- Remove collapse feature

Author: davemacaulay

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderStageSection.xml

@@ -45,9 +45,6 @@
     <section name="PageBuilderPanel">
         <element name="searchField" type="input" selector='//*[@id="pagebuilder-panel"]/div[1]/a'/>
         <element name="clearSearch" type="button" selector='//*[@id="pagebuilder-panel"]/div[1]/a'/>
-        <element name="collapsePanel" type="button" selector='//div[contains(@class, "panel-controls")]//a[contains(@class, "collapse")]'/>
-        <element name="panelCollapsed" type="button" selector='(//div[contains(@class, "pagebuilder-stage") and contains(@class, "panel-collapsed")])'/>
-        <element name="expandPanel" type="button" selector='//div[contains(@class, "expand")]//a'/>
         <element name="firstSection" type="button" selector='//*[@id="pagebuilder-panel-groups"]/li[1]' timeout="30"/>
         <element name="allPanelGroups" type="button" selector="#pagebuilder-panel-groups .group-title"/>
         <element name="allGroupContentTypes" type="button" selector="#pagebuilder-panel-groups #group-{{arg1}} .pagebuilder-draggable-content-type" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderPanelTest.xml

@@ -231,50 +231,6 @@
         </actionGroup>
         <dontSeeJsError stepKey="dontSeeJsError"/>
     </test>
-    <test name="PanelExpandAndCollapseAndAddToStage">
-        <annotations>
-            <features value="PageBuilder"/>
-            <stories value="Panel"/>
-            <title value="Collapse and Expand search panel and still able to search and add to stage"/>
-            <description value="After expand and collapse search panel I can search and drop content blocks onto the stage"/>
-            <severity value="CRITICAL"/>
-            <useCaseId value="MAGETWO-92004"/>
-            <testCaseId value="MC-2752"/>
-            <group value="pagebuilder"/>
-            <group value="pagebuilder-panel"/>
-        </annotations>
-        <before>
-            <actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
-            <actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
-            <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
-        </before>
-        <after>
-            <actionGroup ref="logout" stepKey="logout"/>
-        </after>
-        <actionGroup ref="dragContentTypeToStage" stepKey="dragColumnToStage">
-            <argument name="contentType" value="PageBuilderColumnContentType"/>
-        </actionGroup>
-        <comment userInput="Collapse and Expand panel then drag Tabs to Column" stepKey="commentDragTabs"/>
-        <waitForElementVisible selector="{{PageBuilderStage.stageWrapper}}" stepKey="waitForStage"/>
-        <waitForElementVisible selector="{{PageBuilderPanel.collapsePanel}}" stepKey="waitForCollapseButton"/>
-        <click selector="{{PageBuilderPanel.collapsePanel}}" stepKey="clickCollapseButton"/>
-        <waitForElementVisible selector="{{PageBuilderPanel.expandPanel}}" stepKey="waitForExpandButton"/>
-        <waitForElementVisible selector="{{PageBuilderPanel.panelCollapsed}}" stepKey="waitForPanelCollapsed"/>
-        <waitForElementNotVisible selector="{{PageBuilderPanel.collapsePanel}}" stepKey="waitForCollapsePanelButtonNotVisible"/>
-        <waitForElementNotVisible selector="{{PageBuilderPanel.searchPanel}}" stepKey="waitForSearchFieldNotVisible"/>
-        <click selector="{{PageBuilderPanel.expandPanel}}" stepKey="clickExpandButton"/>
-        <waitForElementNotVisible selector="{{PageBuilderPanel.panelCollapsed}}" stepKey="waitForPanelCollapsedNotVisible"/>
-        <waitForElementNotVisible selector="{{PageBuilderPanel.expandPanel}}" stepKey="waitForExpandButtonNotVisible"/>
-        <waitForElementVisible selector="{{PageBuilderPanel.collapsePanel}}" stepKey="waitForCollapseButtonVisible"/>
-        <waitForElementVisible selector="{{PageBuilderPanel.searchPanel}}" stepKey="waitForSearchField"/>
-        <fillField selector="{{PageBuilderPanel.searchPanel}}" userInput="ta" stepKey="fillSearchFieldTa"/>
-        <actionGroup ref="dragContentTypeToContainer" stepKey="dragTabsIntoFirstColumn">
-            <argument name="contentType" value="PageBuilderTabsContentType"/>
-            <argument name="containerTargetType" value="PageBuilderColumnContentType"/>
-            <argument name="containerTargetIndex" value="1"/>
-        </actionGroup>
-        <dontSeeJsError stepKey="dontSeeJsError"/>
-    </test>
     <test name="ValidatePanelContentTypesGroupedCorrectly">
         <annotations>
             <features value="PageBuilder"/>

app/code/Magento/PageBuilder/view/adminhtml/web/js/panel.js

@@ -50,11 +50,5 @@ <h4 translate="label"></h4>
                 </div>
             </li>
         </ul>
-        <div class="panel-controls">
-            <a class="collapse" click="collapse" data-bind="i18n: 'Collapse'"></a>
-        </div>
-    </div>
-    <div class="expand" visible="isCollapsed">
-        <a click="collapse"></a>
     </div>
 </div>

app/code/Magento/PageBuilder/view/adminhtml/web/template/panel.html

@@ -24,7 +24,6 @@ import {supportsPositionSticky} from "./utils/position-sticky";
 export default class Panel {
     public groups: KnockoutObservableArray<any> = ko.observableArray([]);
     public searchResults: KnockoutObservableArray<any> = ko.observableArray([]);
-    public isCollapsed: KnockoutObservable<boolean> = ko.observable(false);
     public isVisible: KnockoutObservable<boolean> = ko.observable(false);
     public isStickyBottom: KnockoutObservable<boolean> = ko.observable(false);
     public isStickyTop: KnockoutObservable<boolean> = ko.observable(false);
@@ -106,13 +105,6 @@ export default class Panel {
         }
     }
 
-    /**
-     * Collapse the panel into the side of the UI
-     */
-    public collapse(): void {
-        this.isCollapsed(!this.isCollapsed());
-    }
-
     /**
      * Clear Search Results
      */