Skip to content

Commit 682925b

Browse files
author
Hwashiang Yu
committed
MC-5383: Option Menus, Heading Inline Editor & tinyMCE Inline Editor Are Cut Off on Full Screen View
- Moved full screen tests to heading and text test files - Updated heading viewport selectors to be parameterized - Updated tests name and annotations - Removed uneeded waits in tests - Changed toggling fullscreen stage to use newly created action group
1 parent 47d3d44 commit 682925b

File tree

5 files changed

+305
-293
lines changed

5 files changed

+305
-293
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup.xml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,19 @@
88

99
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="openPageBuilderFullScreen">
12+
<waitForElementVisible selector="{{PageBuilderStage.openFullScreen}}" stepKey="waitForFullScreenButton"/>
13+
<click selector="{{PageBuilderStage.openFullScreen}}" stepKey="clickFullScreenButton"/>
14+
<waitForPageLoad stepKey="waitForFullScreenAnimation"/>
15+
<seeElement selector="{{PageBuilderStage.stageWrapperFullScreen}}" stepKey="seeStageFullScreen"/>
16+
<seeElement selector="{{PageBuilderStage.exitFullScreen}}" stepKey="seeExitFullScreenButton"/>
17+
</actionGroup>
18+
<actionGroup name="exitPageBuilderFullScreen">
19+
<waitForElementVisible selector="{{PageBuilderStage.exitFullScreen}}" stepKey="waitForExitPageBuilderFullScreenButton"/>
20+
<click selector="{{PageBuilderStage.exitFullScreen}}" stepKey="exitPageBuilderFullScreen"/>
21+
<waitForPageLoad stepKey="waitForExitFullScreen"/>
22+
<dontSeeElementInDOM selector="{{PageBuilderStage.exitFullScreen}}" stepKey="dontSeeExitPageBuilderFullScreenButton"/>
23+
</actionGroup>
1124
<actionGroup name="validateContentTypeHeightOnStage">
1225
<arguments>
1326
<argument name="contentType"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderHeadingSection.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
<element name="headingTextAlignToolbar" type="button" selector="(//div[contains(@class,'pagebuilder-heading')])[{{arg1}}]//i[contains(@class,'icon-pagebuilder-align-{{arg2}}')]" parameterized="true"/>
2626
<element name="headingTextAlignToolbarSelected" type="button" selector="(//div[contains(@class,'pagebuilder-heading')])[{{arg1}}]//a[contains(@class, 'toolbar-active')]//i[contains(@class,'icon-pagebuilder-align-{{arg2}}')]" parameterized="true"/>
2727
<element name="headingToolbarButtonViewportPositionTop" type="button" selector="return document.querySelector('.pagebuilder-toolbar-options-wrapper ul:{{arg1}}-child li:{{arg1}}-child').getBoundingClientRect().top;" parameterized="true"/>
28-
<element name="headingToolbarViewportPositionTop" type="button" selector="return document.querySelector('.pagebuilder-toolbar-options-wrapper').getBoundingClientRect().top;"/>
29-
<element name="headingToolbarViewportPositionBottom" type="button" selector="return document.querySelector('.pagebuilder-toolbar-options-wrapper').getBoundingClientRect().bottom;"/>
30-
<element name="allViewportPositionTop" type="button" selector="return document.querySelector('.pagebuilder-heading').getBoundingClientRect().top;"/>
31-
<element name="allViewportPositionBottom" type="button" selector="return document.querySelector('.pagebuilder-heading').getBoundingClientRect().bottom;"/>
28+
<element name="headingToolbarViewportPositionTop" type="button" selector="return document.querySelectorAll('.pagebuilder-heading .pagebuilder-toolbar-options-wrapper')[{{arg1}}].getBoundingClientRect().top;" parameterized="true"/>
29+
<element name="headingToolbarViewportPositionBottom" type="button" selector="return document.querySelectorAll('.pagebuilder-heading .pagebuilder-toolbar-options-wrapper')[{{arg1}}].getBoundingClientRect().bottom;" parameterized="true"/>
30+
<element name="headingContentTypeViewportPositionTop" type="button" selector="return document.querySelectorAll('.pagebuilder-heading')[{{arg1}}].getBoundingClientRect().top;" parameterized="true"/>
31+
<element name="headingContentTypeViewportPositionBottom" type="button" selector="return document.querySelectorAll('.pagebuilder-heading')[{{arg1}}].getBoundingClientRect().bottom;" parameterized="true"/>
3232
<!-- Advanced Configuration -->
3333
<element name="alignment" type="text" selector="(//div[contains(@class,'pagebuilder-heading')]//{{arg1}})[{{arg2}}][contains(@style,'text-align: {{arg3}};')]" parameterized="true"/>
3434
<element name="noAlignment" type="text" selector="(//{{arg1}})[{{arg2}}][not(contains(@style,'text-align:'))]" parameterized="true"/>

0 commit comments

Comments
 (0)