Skip to content

Commit 65db3af

Browse files
committed
MC-3386: Update tests to reloadPage after navigating back to the admin when using tabs
- Resolve issues with testst that used tabs
1 parent ca55d9b commit 65db3af

File tree

5 files changed

+23
-20
lines changed

5 files changed

+23
-20
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@
5858
<group value="pagebuilder"/>
5959
<group value="pagebuilder-banner"/>
6060
<group value="pagebuilder-bannerCommon"/>
61-
<!-- Skipped due to form key issues MC-3386 -->
62-
<group value="skip" />
6361
</annotations>
6462
<before>
6563
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -798,8 +796,6 @@
798796
<group value="pagebuilder"/>
799797
<group value="pagebuilder-banner"/>
800798
<group value="pagebuilder-bannerCommon"/>
801-
<!-- Skipped due to form key issues MC-3386 -->
802-
<group value="skip" />
803799
</annotations>
804800
<before>
805801
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -937,15 +937,14 @@
937937
<testCaseId value="MC-2401"/>
938938
<group value="pagebuilder"/>
939939
<group value="pagebuilder-column"/>
940-
<!-- Skipped due to form key issues MC-3386 -->
941-
<group value="skip" />
942940
</annotations>
943941
<before>
944942
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
945943
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
946944
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
947945
</before>
948946
<after>
947+
<closeTab stepKey="closeTab" />
949948
<actionGroup ref="logout" stepKey="logout"/>
950949
</after>
951950
<actionGroup ref="dragContentTypeToContainer" stepKey="dragFirstColumn">
@@ -1020,6 +1019,7 @@
10201019
<seeElement selector="{{ColumnOnFrontend.column3Appearance}}" stepKey="seeColumn3AppearanceApplied"/>
10211020
<seeElement selector="{{ColumnOnFrontend.column3BackgroundColorGrey}}" stepKey="seeColumn3BackgroundColorApplied"/>
10221021
<switchToPreviousTab stepKey="switchToPreviousTab"/>
1022+
<reloadPage stepKey="reloadPage"/>
10231023
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
10241024
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditPanelForSecondColumn1">
10251025
<argument name="contentType" value="PageBuilderColumnContentType"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapGoogleMapsSettingsTests.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -584,8 +584,9 @@
584584
<group value="pagebuilder"/>
585585
<group value="pagebuilder-map"/>
586586
<group value="pagebuilder-googleMapsStyle"/>
587-
<!-- Skipped due to form key issues MC-3386 -->
588-
<group value="skip" />
587+
<skip>
588+
<issueId value="MC-3413" />
589+
</skip>
589590
</annotations>
590591
<before>
591592
<magentoCLI command="config:set cms/pagebuilder/google_maps_style ''" stepKey="setEmptyGoogleMapsStyle"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapPinTest.xml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -319,8 +319,9 @@
319319
<group value="pagebuilder"/>
320320
<group value="pagebuilder-map"/>
321321
<group value="pagebuilder-mapPinTests"/>
322-
<!-- Skipped due to form key issues MC-3386 -->
323-
<group value="skip" />
322+
<skip>
323+
<issueId value="MC-3413" />
324+
</skip>
324325
</annotations>
325326
<before>
326327
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -459,8 +460,9 @@
459460
<group value="pagebuilder"/>
460461
<group value="pagebuilder-map"/>
461462
<group value="pagebuilder-mapPinTests"/>
462-
<!-- Skipped due to form key issues MC-3386 -->
463-
<group value="skip" />
463+
<skip>
464+
<issueId value="MC-3413" />
465+
</skip>
464466
</annotations>
465467
<before>
466468
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -585,8 +587,9 @@
585587
<group value="pagebuilder"/>
586588
<group value="pagebuilder-map"/>
587589
<group value="pagebuilder-mapPinTests"/>
588-
<!-- Skipped due to form key issues MC-3386 -->
589-
<group value="skip" />
590+
<skip>
591+
<issueId value="MC-3413" />
592+
</skip>
590593
</annotations>
591594
<before>
592595
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -709,8 +712,9 @@
709712
<group value="pagebuilder"/>
710713
<group value="pagebuilder-map"/>
711714
<group value="pagebuilder-mapPinTests"/>
712-
<!-- Skipped due to form key issues MC-3386 -->
713-
<group value="skip" />
715+
<skip>
716+
<issueId value="MC-3413" />
717+
</skip>
714718
</annotations>
715719
<before>
716720
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideCommonTest.xml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -934,8 +934,6 @@
934934
<group value="pagebuilder"/>
935935
<group value="pagebuilder-slider"/>
936936
<group value="pagebuilder-sliderCommon"/>
937-
<!-- Skipped due to form key issues MC-3386 -->
938-
<group value="skip" />
939937
</annotations>
940938
<before>
941939
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -997,6 +995,8 @@
997995
<!-- Change button type value to secondary -->
998996
<comment userInput="Change Button Type to Secondary in admin" stepKey="secondary"/>
999997
<switchToPreviousTab stepKey="switchToPreviousTab"/>
998+
<reloadPage stepKey="reloadPage" />
999+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
10001000
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditPanel1">
10011001
<argument name="section" value="SlideOnBackend"/>
10021002
</actionGroup>
@@ -1005,7 +1005,7 @@
10051005
</actionGroup>
10061006
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
10071007
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>
1008-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
1008+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage3"/>
10091009
<!-- Validate Stage 2 -->
10101010
<comment userInput="Validate Stage 2" stepKey="commentValidateStage2"/>
10111011
<waitForElementVisible time="2" selector="{{SlideOnBackend.poster}}" stepKey="waitForPosterInAdmin3" />
@@ -1023,6 +1023,8 @@
10231023
<!-- Change button type value to link -->
10241024
<comment userInput="Change Button Type to Link in admin" stepKey="link"/>
10251025
<switchToPreviousTab stepKey="switchToPreviousTab2"/>
1026+
<reloadPage stepKey="reloadPage1" />
1027+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage5"/>
10261028
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditPanel2">
10271029
<argument name="section" value="SlideOnBackend"/>
10281030
</actionGroup>
@@ -1031,7 +1033,7 @@
10311033
</actionGroup>
10321034
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
10331035
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage3"/>
1034-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage3"/>
1036+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage4"/>
10351037
<!-- Validate Stage 3 -->
10361038
<comment userInput="Validate Stage 3" stepKey="commentValidateStage3"/>
10371039
<waitForElementVisible time="2" selector="{{SlideOnBackend.poster}}" stepKey="waitForPosterInAdmin5" />

0 commit comments

Comments
 (0)