Skip to content

Commit 65db346

Browse files
committed
MC-3870: Background does not conform to border radius for banner, image, contained row & video
Fix test generation issues from merge
1 parent c636ce7 commit 65db346

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeImageActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<attachFile userInput="{{property.value}}" selector="{{ImageOnStageWithoutImageUploaded.attachImageBtn}}" stepKey="attachImageFileOnStage"/>
1616
<waitForPageLoad stepKey="waitForPageLoad"/>
1717
<waitForElementVisible selector="{{ImageOnStageWithoutImageUploaded.imagePreview}}" stepKey="waitForImagePreview"/>
18-
<waitForElementVisible selector="{{ImageOnStageWithoutImageUploaded.imageSourceOnStage(property.fileName)}}" stepKey="waitForImageSource"/>
18+
<waitForElementVisible selector="{{ImageOnStageWithoutImageUploaded.imageSource(property.fileName)}}" stepKey="waitForImageSource"/>
1919
</actionGroup>
2020
<actionGroup name="verifyImageOnSlideout">
2121
<arguments>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderImageTest.xml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
<comment userInput="Attach image A to PageBuilder stage" stepKey="attachImageToStage"/>
4545
<actionGroup ref="uploadImageToContentTypeFromStage" stepKey="addImageToStage">
4646
<argument name="property" value="PageBuilderImageProperty_StageJPG"/>
47-
<argument name="section" value="ImageOnStage"/>
47+
<argument name="section" value="ImageOnStageWithoutImageUploaded"/>
4848
</actionGroup>
4949
<!-- Go to Media Storage from stage-->
5050
<comment userInput="Go to Media Storage from stage" stepKey="commentGoToMediaStorageFromStage"/>
@@ -60,7 +60,7 @@
6060
<!-- Assert don't see deleted image on stage -->
6161
<comment userInput="Assert don't see deleted image on stage" stepKey="assertNotToSeeImage"/>
6262
<seeElementInDOM selector="{{ImageOnStageWithoutImageUploaded.imageEmptyPreview}}" stepKey="dontSeeImageOnStage1"/>
63-
<dontSeeElementInDOM selector="{{ImageOnStageWithoutImageUploaded.imageSourceOnStage(PageBuilderImageProperty_StageJPG.fileName)}}" stepKey="dontSeeImageInDOM1"/>
63+
<dontSeeElementInDOM selector="{{ImageOnStageWithoutImageUploaded.imageSource(PageBuilderImageProperty_StageJPG.fileName)}}" stepKey="dontSeeImageInDOM1"/>
6464
<!-- Attach image C to Image slideout form -->
6565
<comment userInput="Attach image C to Image slideout form" stepKey="attachImageToSlideOut"/>
6666
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage1">
@@ -125,7 +125,7 @@
125125
<!-- Assert not to see image on stage -->
126126
<comment userInput="Assert not to see image on stage" stepKey="commentVerifyImageStage" />
127127
<seeElementInDOM selector="{{ImageOnStageWithoutImageUploaded.imageEmptyPreview}}" stepKey="dontSeeImageOnStage3"/>
128-
<dontSeeElementInDOM selector="{{ImageOnStageWithoutImageUploaded.imageSourceOnStage(PageBuilderImageProperty_StageJPG.fileName)}}" stepKey="dontSeeImageInDOM2"/>
128+
<dontSeeElementInDOM selector="{{ImageOnStageWithoutImageUploaded.imageSource(PageBuilderImageProperty_StageJPG.fileName)}}" stepKey="dontSeeImageInDOM2"/>
129129
</test>
130130
<test name="ImageAddImageIntoPageBuilderStage">
131131
<annotations>
@@ -1115,8 +1115,6 @@
11151115
<dontSeeElement selector="{{PageBuilderStage.onHoverSelectFromGalleryButton(PageBuilderImageContentType.role, '1')}}" stepKey="dontSeeSelectFromGallery"/>
11161116
<waitForElementNotVisible selector="{{ImageOnStageWithoutImageUploaded.uploadImageInput('1')}}" stepKey="waitForUploadInputNotVisible"/>
11171117
<dontSeeElement selector="{{ImageOnStageWithoutImageUploaded.uploadImageInput('1')}}" stepKey="dontSeeUploadImageInput"/>
1118-
<waitForElementNotVisible selector="{{ImageOnStage.uploadImageInput('1')}}" stepKey="waitForUploadInputNotVisible"/>
1119-
<dontSeeElement selector="{{ImageOnStage.uploadImageInput('1')}}" stepKey="dontSeeUploadImageInput"/>
11201118
</test>
11211119
<test name="DuplicateRowWithImage">
11221120
<annotations>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemContentTests.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,8 @@
229229
<!-- Attach image A to PageBuilder stage-->
230230
<attachFile userInput="{{PageBuilderImageProperty_StageJPG.value}}" selector="{{ImageOnStageWithoutImageUploaded.attachImageBtn}}" stepKey="attachImageFileOnStage"/>
231231
<waitForElementVisible selector="{{ImageOnStageWithoutImageUploaded.imagePreview}}" stepKey="waitForImagePreview"/>
232-
<waitForElementVisible selector="{{ImageOnStageWithoutImageUploaded.imageSourceOnStage('magentoStage')}}" stepKey="waitForImageSource"/>
233-
<seeElement selector="{{ImageOnStageWithoutImageUploaded.imageSourceOnStage('magentoStage')}}" stepKey="seeImageSourceOnStage" />
232+
<waitForElementVisible selector="{{ImageOnStageWithoutImageUploaded.imageSource('magentoStage')}}" stepKey="waitForImageSource"/>
233+
<seeElement selector="{{ImageOnStageWithoutImageUploaded.imageSource('magentoStage')}}" stepKey="seeImageSourceOnStage" />
234234
<seeElement selector="{{ImageOnStageWithoutImageUploaded.imageSourceByIndex('1', PageBuilderImageProperty_StageJPG.fileName)}}" stepKey="seeImageOnStage"/>
235235
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
236236
<!-- Verify Image in Tab on storefront -->

0 commit comments

Comments
 (0)