Skip to content

Commit 6512aac

Browse files
committed
MC-4129: Edit Panel Opens After Dragging & Dropping Content Types
- Resolve CR feedback
1 parent a9cb20a commit 6512aac

File tree

5 files changed

+0
-48
lines changed

5 files changed

+0
-48
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockTest.xml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,6 @@
3939
<actionGroup ref="dragContentTypeToStage" stepKey="dragBlockIntoStage">
4040
<argument name="contentType" value="PageBuilderBlockContentType"/>
4141
</actionGroup>
42-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
43-
<argument name="contentType" value="PageBuilderBlockContentType"/>
44-
</actionGroup>
45-
<actionGroup ref="closeEditPanelSettings" stepKey="closeSlideEditPanel"/>
4642
<waitForElementVisible selector="{{BlockOnStage.status('1', 'Empty Block')}}" stepKey="seeEmptyBlockPlaceHolder"/>
4743
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
4844
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
@@ -85,7 +81,6 @@
8581
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
8682
<argument name="contentType" value="PageBuilderBlockContentType"/>
8783
</actionGroup>
88-
<waitForElementVisible selector="{{BlockOnForm.title('Not Selected')}}" stepKey="seeNotSelectedBlock"/>
8984
<actionGroup ref="searchBlockInGrid" stepKey="searchBlockInGrid">
9085
<argument name="block" value="$$createPreReqBlock$$"/>
9186
</actionGroup>
@@ -142,7 +137,6 @@
142137
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
143138
<argument name="contentType" value="PageBuilderBlockContentType"/>
144139
</actionGroup>
145-
<waitForElementVisible selector="{{BlockOnForm.title('Not Selected')}}" stepKey="seeNotSelectedBlock"/>
146140
<actionGroup ref="searchBlockInGrid" stepKey="searchBlockInGrid">
147141
<argument name="block" value="$$createPreReqBlock$$"/>
148142
</actionGroup>
@@ -223,7 +217,6 @@
223217
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
224218
<argument name="contentType" value="PageBuilderBlockContentType"/>
225219
</actionGroup>
226-
<waitForElementVisible selector="{{BlockOnForm.title('Not Selected')}}" stepKey="seeNotSelectedBlock"/>
227220
<actionGroup ref="searchBlockInGrid" stepKey="searchBlockInGrid">
228221
<argument name="block" value="$$createPreReqBlock$$"/>
229222
</actionGroup>
@@ -795,10 +788,6 @@
795788
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
796789
<argument name="containerTargetIndex" value="2" />
797790
</actionGroup>
798-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
799-
<argument name="contentType" value="PageBuilderBlockContentType"/>
800-
</actionGroup>
801-
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanel"/>
802791
<!-- Validate Stage -->
803792
<comment userInput="User sees Block displayed in column on Stage" stepKey="confirmBlockOnStage"/>
804793
<actionGroup ref="validateContentTypeInsideContainerStage" stepKey="checkContentTypeInContainerStage">
@@ -904,7 +893,6 @@
904893
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
905894
<argument name="contentType" value="PageBuilderBlockContentType"/>
906895
</actionGroup>
907-
<waitForElementVisible selector="{{BlockOnForm.title('Not Selected')}}" stepKey="seeNotSelectedBlock"/>
908896
<actionGroup ref="searchBlockInGrid" stepKey="searchBlockInGrid">
909897
<argument name="block" value="$$createPreReqBlock$$"/>
910898
</actionGroup>
@@ -979,7 +967,6 @@
979967
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
980968
<argument name="contentType" value="PageBuilderBlockContentType"/>
981969
</actionGroup>
982-
<waitForElementVisible selector="{{BlockOnForm.title('Not Selected')}}" stepKey="seeNotSelectedBlock"/>
983970
<actionGroup ref="searchBlockInGrid" stepKey="searchBlockInGrid">
984971
<argument name="block" value="$$createPreReqBlock$$"/>
985972
</actionGroup>
@@ -1101,7 +1088,6 @@
11011088
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
11021089
<argument name="contentType" value="PageBuilderBlockContentType"/>
11031090
</actionGroup>
1104-
<waitForElementVisible selector="{{BlockOnForm.title('Not Selected')}}" stepKey="seeNotSelectedBlock"/>
11051091
<actionGroup ref="searchBlockInGrid" stepKey="searchBlockInGrid">
11061092
<argument name="block" value="$$createPreReqBlock$$"/>
11071093
</actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapCommonComponentTest.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -218,10 +218,6 @@
218218
<actionGroup ref="dragContentTypeToStage" stepKey="dragContentTypeIntoStage">
219219
<argument name="contentType" value="PageBuilderMapContentType"/>
220220
</actionGroup>
221-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
222-
<argument name="contentType" value="PageBuilderMapContentType"/>
223-
</actionGroup>
224-
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
225221
<actionGroup ref="validateOnHoverOptionMenu" stepKey="validateOnHoverOptionMenu">
226222
<argument name="contentType" value="PageBuilderMapContentType"/>
227223
</actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapGoogleMapsSettingsTests.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -724,10 +724,6 @@
724724
<actionGroup ref="dragContentTypeToStage" stepKey="dragContentTypeIntoStage">
725725
<argument name="contentType" value="PageBuilderMapContentType"/>
726726
</actionGroup>
727-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
728-
<argument name="contentType" value="PageBuilderMapContentType"/>
729-
</actionGroup>
730-
<actionGroup ref="closeEditPanelSettings" stepKey="saveEditPanelSettings"/>
731727
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
732728
<!--Set Google Maps Style -->
733729
<comment userInput="Set Google Maps Style" stepKey="commentSetStyle"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1527,10 +1527,6 @@
15271527
<actionGroup ref="dragContentTypeToStage" stepKey="dragSliderIntoStage">
15281528
<argument name="contentType" value="PageBuilderSliderContentType"/>
15291529
</actionGroup>
1530-
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditPanelAfterDrop">
1531-
<argument name="section" value="SlideOnBackend"/>
1532-
</actionGroup>
1533-
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
15341530
<!-- Check that user can drag column when inline mode active -->
15351531
<comment userInput="Check that user can drag column when inline mode active" stepKey="commentDragColumnIntoStage"/>
15361532
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroupForColumn">

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/video/preview.js

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)