Skip to content

Commit 642b714

Browse files
committed
MC-3091: Improve MFTF tests for Block Configuration
1 parent 82ace51 commit 642b714

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeBlockActionGroup.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727
<actionGroup name="verifyBlockOnStage">
2828
<arguments>
2929
<argument name="block"/>
30-
<argument name="index"/>
30+
<argument name="index" defaultValue="1" type="string"/>
3131
</arguments>
3232
<moveMouseOver selector="{{PageBuilderStage.contentTypeInStage(PageBuilderBlockContentType.role)}}" stepKey="onMouseOverContentTypeStage"/>
3333
<waitForPageLoad stepKey="waitForPageLoad"/>
34-
<waitForElementVisible selector="{{BlockOnStage.title('1', block.title)}}" stepKey="wait"/>
35-
<seeElement selector="{{BlockOnStage.title('1',block.title)}}" stepKey="seeOptionMenuTitle"/>
36-
<see userInput="{{block.content}}" stepKey="seeBlockContentOnStage"/>
34+
<waitForElementVisible selector="{{BlockOnStage.title(index, block.title)}}" stepKey="wait"/>
35+
<seeElement selector="{{BlockOnStage.title(index,block.title)}}" stepKey="seeOptionMenuTitle"/>
36+
<see selector="{{BlockOnStage.content(index)}}" userInput="{{block.content}}" stepKey="seeBlockContentOnStage"/>
3737
</actionGroup>
3838
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderBlockSection.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<element name="title" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]//div[contains(@class,'pagebuilder-options-wrapper')]//div[contains(@class,'option-title') and text()='{{arg}}']" parameterized="true"/>
1616
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]" parameterized="true"/>
1717
<element name="hr" type="button" selector="((//div[contains(@class,'pagebuilder-block')])[{{arg1}}]//div[@data-identifier])[{{arg2}}]//hr" parameterized="true"/>
18+
<element name="content" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]//div[contains(@class,'block-static-block')]" parameterized="true"/>
1819
<!-- Advanced Configuration -->
1920
<element name="alignment" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]//div[contains(@style,'text-align: {{arg2}};')]" parameterized="true"/>
2021
<element name="noAlignment" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]//div[not(contains(@style,'text-align:'))]" parameterized="true"/>
@@ -42,7 +43,7 @@
4243
<element name="html" type="text" selector="(//div[@data-role='html'])[{{arg1}}]//a[contains(@class,'pagebuilder-button-primary')]" parameterized="true"/>
4344
<element name="base" type="text" selector="(//div[@data-role='row']/div)[{{arg1}}]" parameterized="true"/>
4445
<element name="hr" type="button" selector="(//div[@data-role='row']/div)[{{arg1}}]/hr" parameterized="true"/>
45-
<element name="empty" type="text" selector="//div[@data-role='block'][not(*)]"/>
46+
<element name="empty" type="text" selector="//div[@data-role='block'][{{arg1}}][not(*)]" parameterized="true"/>
4647
<!-- Advanced Configuration -->
4748
<element name="alignment" type="text" selector="(//div[@data-role='row']/div)[{{arg1}}][contains(@style,'text-align: {{arg2}};')]" parameterized="true"/>
4849
<element name="noAlignment" type="text" selector="(//div[@data-role='row']/div)[{{arg1}}][not(contains(@style,'text-align:'))]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@
4646
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
4747
<amOnPage url="$$createCMSPage.identifier$$" stepKey="amOnPageTestPage"/>
4848
<waitForPageLoad stepKey="waitForPageLoad"/>
49-
<waitForElement selector="{{BlockOnStorefront.empty}}" stepKey="waitForSeeElement"/>
50-
<seeElementInDOM selector="{{BlockOnStorefront.empty}}" stepKey="seeBlockContentOnCmsStage"/>
49+
<waitForElement selector="{{BlockOnStorefront.empty('1')}}" stepKey="waitForSeeElement"/>
50+
<seeElementInDOM selector="{{BlockOnStorefront.empty('1')}}" stepKey="seeBlockContentOnCmsStage"/>
5151
</test>
5252
<test name="AddBlockToCmsPage">
5353
<annotations>
@@ -277,7 +277,7 @@
277277
<actionGroup ref="removeEmptyContentTypeFromStage" stepKey="removeEmptyContentTypeFromStage">
278278
<argument name="contentType" value="PageBuilderBlockContentType"/>
279279
</actionGroup>
280-
<dontSeeElement selector="{{PageBuilderStage.contentTypeInStage(PageBuilderBlockContentType.role)}}" stepKey="dontSeeContentTypeInStage"/>
280+
<dontSeeElementInDOM selector="{{PageBuilderStage.contentTypeInStage(PageBuilderBlockContentType.role)}}" stepKey="dontSeeContentTypeInStage"/>
281281
</test>
282282
<test name="DisplayingDeletedBlockOnStage">
283283
<annotations>

0 commit comments

Comments
 (0)