Skip to content

Commit 62d6fd3

Browse files
committed
MC-14937: Complete Page Builder Analytics data collection
- use factory in integration test
1 parent b691ea3 commit 62d6fd3

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

app/code/Magento/PageBuilderAnalytics/Model/ContentTypeUsageReportProvider.php

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@
88

99
namespace Magento\PageBuilderAnalytics\Model;
1010

11-
use Magento\Analytics\ReportXml\QueryFactory;
1211
use Magento\Analytics\ReportXml\ConnectionFactory;
13-
use Magento\PageBuilder\Model\Config;
12+
use Magento\Analytics\ReportXml\IteratorFactory;
1413
use Magento\Analytics\ReportXml\Query;
14+
use Magento\Analytics\ReportXml\QueryFactory;
1515
use Magento\Framework\DB\Adapter\AdapterInterface;
16+
use Magento\PageBuilder\Model\Config;
1617

1718
/**
1819
* Provides content type usage data report
@@ -29,6 +30,11 @@ class ContentTypeUsageReportProvider
2930
*/
3031
private $queryFactory;
3132

33+
/**
34+
* @var IteratorFactory
35+
*/
36+
private $iteratorFactory;
37+
3238
/**
3339
* @var ConnectionFactory
3440
*/
@@ -50,11 +56,13 @@ class ContentTypeUsageReportProvider
5056
public function __construct(
5157
Config $config,
5258
QueryFactory $queryFactory,
59+
IteratorFactory $iteratorFactory,
5360
ConnectionFactory $connectionFactory,
5461
$batchSize = 5000
5562
) {
5663
$this->config = $config;
5764
$this->queryFactory = $queryFactory;
65+
$this->iteratorFactory = $iteratorFactory;
5866
$this->connectionFactory = $connectionFactory;
5967
$this->batchSize = $batchSize;
6068
}
@@ -106,9 +114,7 @@ public function getReport($name) : \IteratorIterator
106114
$reportData[] = [$type['name'], $typeCounts[$type['name']]];
107115
}
108116

109-
return new \IteratorIterator(
110-
new \ArrayIterator($reportData)
111-
);
117+
return $this->iteratorFactory->create($reportData);
112118
}
113119

114120
/**

0 commit comments

Comments
 (0)