Skip to content

Commit 617bd01

Browse files
author
Hwashiang Yu
committed
MC-4234: Missing validation message for 'Number of Products to Display' on Product Content Type
- Changed product count to a required field - Updated test to change above
1 parent 69c0408 commit 617bd01

File tree

3 files changed

+17
-1
lines changed

3 files changed

+17
-1
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/ProductsData.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
<data key="fieldName">products_count</data>
2727
<data key="value">999</data>
2828
</entity>
29+
2930
<entity name="PageBuilderProductsInvalidMinCountProperty" type="pagebuilder_content_type">
3031
<data key="name">Number of Products to Display</data>
3132
<data key="section">general</data>
@@ -47,6 +48,13 @@
4748
<data key="value">Invalid</data>
4849
<data key="errorMessage">Please enter a valid number in this field.</data>
4950
</entity>
51+
<entity name="PageBuilderProductsInvalidEmptyCountProperty" type="pagebuilder_content_type">
52+
<data key="name">Number of Products to Display</data>
53+
<data key="section">general</data>
54+
<data key="fieldName">products_count</data>
55+
<data key="value"/>
56+
<data key="errorMessage">This is a required field.</data>
57+
</entity>
5058
<entity name="PageBuilderProductsSubCategory" type="category">
5159
<data key="name" unique="suffix">PageBuilderProductsSubCategory</data>
5260
<data key="is_active">true</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsTest.xml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@
140140
<testCaseId value="MC-4028"/>
141141
<group value="pagebuilder"/>
142142
<group value="pagebuilder-products"/>
143+
<group value="m"/>
143144
</annotations>
144145
<before>
145146
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -160,12 +161,12 @@
160161
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
161162
</before>
162163
<after>
163-
<closeTab stepKey="closeTab"/>
164164
<deleteData createDataKey="createPreReqProduct1" stepKey="deletePreReqProduct1"/>
165165
<deleteData createDataKey="createPreReqProduct2" stepKey="deletePreReqProduct2"/>
166166
<deleteData createDataKey="createPreReqProduct3" stepKey="deletePreReqProduct3"/>
167167
<deleteData createDataKey="createPreReqProduct4" stepKey="deletePreReqProduct4"/>
168168
<deleteData createDataKey="createPreReqCategory" stepKey="deletePreReqCategory"/>
169+
<closeTab stepKey="closeTab"/>
169170
<actionGroup ref="logout" stepKey="logout"/>
170171
</after>
171172
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
@@ -192,6 +193,12 @@
192193
<actionGroup ref="saveEditPanelAndValidateFieldErrorGeneralSection" stepKey="validateInvalidMinCount">
193194
<argument name="property" value="PageBuilderProductsInvalidMinCountProperty"/>
194195
</actionGroup>
196+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterInvalidEmptyProductsCount">
197+
<argument name="property" value="PageBuilderProductsInvalidEmptyCountProperty"/>
198+
</actionGroup>
199+
<actionGroup ref="saveEditPanelAndValidateFieldErrorGeneralSection" stepKey="validateInvalidEmptyCount">
200+
<argument name="property" value="PageBuilderProductsInvalidEmptyCountProperty"/>
201+
</actionGroup>
195202
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterInvalidMaxProductsCount">
196203
<argument name="property" value="PageBuilderProductsInvalidMaxCountProperty"/>
197204
</actionGroup>

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_products_form.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@
103103
</additionalClasses>
104104
<dataScope>products_count</dataScope>
105105
<validation>
106+
<rule name="required-entry" xsi:type="boolean">true</rule>
106107
<rule name="validate-number" xsi:type="boolean">true</rule>
107108
<rule name="less-than-equals-to" xsi:type="number">999</rule>
108109
<rule name="greater-than-equals-to" xsi:type="number">1</rule>

0 commit comments

Comments
 (0)