Skip to content

Commit 5e46efb

Browse files
committed
MC-3870: Background does not conform to border radius for banner, image, contained row & video
Use/add ImageOnStage selectors for Validate Advanced Config (Image)
1 parent 3996b85 commit 5e46efb

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderImageSection.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,15 @@
3838
<section name="ImageOnStage">
3939
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]" parameterized="true"/>
4040
<!-- Advanced Configuration -->
41+
<element name="noAlignment" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]//figure[not(contains(@style,'text-align:'))]" parameterized="true"/>
4142
<element name="alignment" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]//figure[contains(@style,'text-align: {{arg2}};')]" parameterized="true"/>
4243
<element name="border" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]//img[contains(@style,'border-style: {{arg2}};')]" parameterized="true"/>
4344
<element name="borderColor" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]//img[contains(@style,'border-color: {{arg2}};')]" parameterized="true"/>
4445
<element name="noBorderColor" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]//img[not(contains(@style,'border-color:'))]" parameterized="true"/>
4546
<element name="borderWidth" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]//img[contains(@style,'border-width: {{arg2}}px;')]" parameterized="true"/>
4647
<element name="borderRadius" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]//img[contains(@style,'border-radius: {{arg2}}px;')]" parameterized="true"/>
4748
<element name="cssClasses" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]//figure[contains(@class,'{{arg2}}')]" parameterized="true"/>
49+
<element name="noCssClasses" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]//figure[not(@class)]" parameterized="true"/>
4850
<element name="margins" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]//figure[contains(@style,'margin: {{arg2}}px;')]" parameterized="true"/>
4951
<element name="padding" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]//figure[contains(@style,'padding: {{arg2}}px;')]" parameterized="true"/>
5052
</section>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderImageTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@
572572
<!-- Validate Stage -->
573573
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
574574
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage">
575-
<argument name="page" value="ImageOnStageWithoutImageUploaded"/>
575+
<argument name="page" value="ImageOnStage"/>
576576
<argument name="border" value="PageBuilderAdvancedBorderPropertyNone"/>
577577
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
578578
<argument name="borderRadius" value="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
@@ -585,7 +585,7 @@
585585
<!-- Validate Stage After Save -->
586586
<comment userInput="Validate Stage After Save" stepKey="commentValidateStage2"/>
587587
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage2">
588-
<argument name="page" value="ImageOnStageWithoutImageUploaded"/>
588+
<argument name="page" value="ImageOnStage"/>
589589
<argument name="border" value="PageBuilderAdvancedBorderPropertyNone"/>
590590
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
591591
<argument name="borderRadius" value="PageBuilderAdvancedBorderRadiusDefaultProperty"/>

0 commit comments

Comments
 (0)