MC-3095: Display TypeScript errors within local build process

- Use TSC directly to remove node output
- Fix error message formatting

Author: davemacaulay

gulpfile.js

@@ -38,7 +38,7 @@ gulp.task('default', ['build', 'watch']);
 /**
  * Check for any new errors introduced since last build
  */
-gulp.task('errors', shell.task("npm run-script ts:errors"));
+gulp.task('errors', shell.task("node_modules/typescript/bin/tsc --noEmit | node ts-error-stopgap.js"));
 
 /**
  * Build the TypeScript files into production JS

ts-error-stopgap.js

@@ -78,8 +78,8 @@ process.stdin.on('end', () => {
     }
 
     console.log(
-        chalk.red(`${newErrors.length} new TypeScript errors were introduced to the code base with your changes. \n`) +
-        chalk.white.bgRed('You' , chalk.white.bgRed('must') , 'resolve all new TypeScript errors before merging a PR.')
+        chalk.red(`${newErrors.length} new TypeScript error(s) were introduced to the code base with your changes. \n`) +
+        chalk.white.bgRed('You must resolve all new TypeScript errors before merging a PR.')
     );
 
     newErrors.forEach(err => {
@@ -91,7 +91,7 @@ process.stdin.on('end', () => {
 
     console.log(
         "\n" +
-        chalk.red(`${newErrors.length} new TypeScript errors were introduced to the code base with your changes. \n`) +
-        chalk.white.bgRed('You' , chalk.white.bgRed('must') , 'resolve all new TypeScript errors before merging a PR.')
+        chalk.red(`${newErrors.length} new TypeScript error(s) were introduced to the code base with your changes. \n`) +
+        chalk.white.bgRed('You must resolve all new TypeScript errors before merging a PR.')
     );
 });