Skip to content

Commit 5b4410f

Browse files
committed
Alt text for Images, Banners and Slides for better accessibility and SEO
1 parent 60d2cbb commit 5b4410f

File tree

4 files changed

+70
-0
lines changed

4 files changed

+70
-0
lines changed

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/banner.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
<attribute name="virtual_link_href" storage_key="link_url" source="href" converter="Magento_PageBuilder/js/converter/attribute/link-href" persistence_mode="write"/>
4242
<attribute name="virtual_link_target" storage_key="link_url" source="target" converter="Magento_PageBuilder/js/converter/attribute/link-target" persistence_mode="write"/>
4343
<attribute name="virtual_link_type" storage_key="link_url" source="data-link-type" converter="Magento_PageBuilder/js/converter/attribute/link-type" persistence_mode="write"/>
44+
<attribute name="title_attribute" source="title"/>
4445
</element>
4546
<element name="empty_link"/>
4647
<element name="wrapper">
@@ -64,6 +65,8 @@
6465
<attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
6566
<attribute name="video_lazy_load" source="data-video-lazy-load"/>
6667
<attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
68+
<attribute name="alt" source="alt"/>
69+
<attribute name="title_attribute" source="title"/>
6770
</element>
6871
<element name="overlay">
6972
<style name="overlay_color" source="background_color" converter="Magento_PageBuilder/js/content-type/banner/converter/style/overlay-background-color" persistence_mode="write"/>
@@ -126,6 +129,7 @@
126129
<attribute name="virtual_link_href" storage_key="link_url" source="href" converter="Magento_PageBuilder/js/converter/attribute/link-href" persistence_mode="write"/>
127130
<attribute name="virtual_link_target" storage_key="link_url" source="target" converter="Magento_PageBuilder/js/converter/attribute/link-target" persistence_mode="write"/>
128131
<attribute name="virtual_link_type" storage_key="link_url" source="data-link-type" converter="Magento_PageBuilder/js/converter/attribute/link-type" persistence_mode="write"/>
132+
<attribute name="title_attribute" source="title"/>
129133
</element>
130134
<element name="empty_link"/>
131135
<element name="wrapper">
@@ -149,6 +153,8 @@
149153
<attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
150154
<attribute name="video_lazy_load" source="data-video-lazy-load"/>
151155
<attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
156+
<attribute name="alt" source="alt"/>
157+
<attribute name="title_attribute" source="title"/>
152158
</element>
153159
<element name="overlay">
154160
<style name="overlay_color" source="background_color" converter="Magento_PageBuilder/js/content-type/banner/converter/style/overlay-background-color" persistence_mode="write"/>
@@ -211,6 +217,7 @@
211217
<attribute name="virtual_link_href" storage_key="link_url" source="href" converter="Magento_PageBuilder/js/converter/attribute/link-href" persistence_mode="write"/>
212218
<attribute name="virtual_link_target" storage_key="link_url" source="target" converter="Magento_PageBuilder/js/converter/attribute/link-target" persistence_mode="write"/>
213219
<attribute name="virtual_link_type" storage_key="link_url" source="data-link-type" converter="Magento_PageBuilder/js/converter/attribute/link-type" persistence_mode="write"/>
220+
<attribute name="title_attribute" source="title"/>
214221
</element>
215222
<element name="empty_link"/>
216223
<element name="wrapper">
@@ -234,6 +241,8 @@
234241
<attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
235242
<attribute name="video_lazy_load" source="data-video-lazy-load"/>
236243
<attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
244+
<attribute name="alt" source="alt"/>
245+
<attribute name="title_attribute" source="title"/>
237246
</element>
238247
<element name="overlay">
239248
<style name="overlay_color" source="background_color" converter="Magento_PageBuilder/js/content-type/banner/converter/style/overlay-background-color" persistence_mode="write"/>
@@ -297,6 +306,7 @@
297306
<attribute name="virtual_link_href" storage_key="link_url" source="href" converter="Magento_PageBuilder/js/converter/attribute/link-href" persistence_mode="write"/>
298307
<attribute name="virtual_link_target" storage_key="link_url" source="target" converter="Magento_PageBuilder/js/converter/attribute/link-target" persistence_mode="write"/>
299308
<attribute name="virtual_link_type" storage_key="link_url" source="data-link-type" converter="Magento_PageBuilder/js/converter/attribute/link-type" persistence_mode="write"/>
309+
<attribute name="title_attribute" source="title"/>
300310
</element>
301311
<element name="empty_link"/>
302312
<element name="wrapper">
@@ -318,6 +328,8 @@
318328
<attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
319329
<attribute name="video_lazy_load" source="data-video-lazy-load"/>
320330
<attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
331+
<attribute name="alt" source="alt"/>
332+
<attribute name="title_attribute" source="title"/>
321333
</element>
322334
<element name="overlay">
323335
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/overlay-border-radius" persistence_mode="write"/>

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/slide.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
<attribute name="virtual_link_href" storage_key="link_url" source="href" converter="Magento_PageBuilder/js/converter/attribute/link-href" persistence_mode="write"/>
4545
<attribute name="virtual_link_target" storage_key="link_url" source="target" converter="Magento_PageBuilder/js/converter/attribute/link-target" persistence_mode="write"/>
4646
<attribute name="virtual_link_type" storage_key="link_url" source="data-link-type" converter="Magento_PageBuilder/js/converter/attribute/link-type" persistence_mode="write"/>
47+
<attribute name="title_attribute" source="title"/>
4748
</element>
4849
<element name="empty_link"/>
4950
<element name="overlay">
@@ -70,6 +71,8 @@
7071
<attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
7172
<attribute name="video_lazy_load" source="data-video-lazy-load"/>
7273
<attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
74+
<attribute name="alt" source="alt"/>
75+
<attribute name="title_attribute" source="title"/>
7376
</element>
7477
<element name="content">
7578
<html name="content" preview_converter="Magento_PageBuilder/js/converter/html/directive"/>
@@ -128,6 +131,7 @@
128131
<attribute name="virtual_link_href" storage_key="link_url" source="href" converter="Magento_PageBuilder/js/converter/attribute/link-href" persistence_mode="write"/>
129132
<attribute name="virtual_link_target" storage_key="link_url" source="target" converter="Magento_PageBuilder/js/converter/attribute/link-target" persistence_mode="write"/>
130133
<attribute name="virtual_link_type" storage_key="link_url" source="data-link-type" converter="Magento_PageBuilder/js/converter/attribute/link-type" persistence_mode="write"/>
134+
<attribute name="title_attribute" source="title"/>
131135
</element>
132136
<element name="empty_link"/>
133137
<element name="overlay">
@@ -154,6 +158,8 @@
154158
<attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
155159
<attribute name="video_lazy_load" source="data-video-lazy-load"/>
156160
<attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
161+
<attribute name="alt" source="alt"/>
162+
<attribute name="title_attribute" source="title"/>
157163
</element>
158164
<element name="content">
159165
<html name="content" preview_converter="Magento_PageBuilder/js/converter/html/directive"/>
@@ -212,6 +218,7 @@
212218
<attribute name="virtual_link_href" storage_key="link_url" source="href" converter="Magento_PageBuilder/js/converter/attribute/link-href" persistence_mode="write"/>
213219
<attribute name="virtual_link_target" storage_key="link_url" source="target" converter="Magento_PageBuilder/js/converter/attribute/link-target" persistence_mode="write"/>
214220
<attribute name="virtual_link_type" storage_key="link_url" source="data-link-type" converter="Magento_PageBuilder/js/converter/attribute/link-type" persistence_mode="write"/>
221+
<attribute name="title_attribute" source="title"/>
215222
</element>
216223
<element name="empty_link"/>
217224
<element name="overlay">
@@ -238,6 +245,8 @@
238245
<attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
239246
<attribute name="video_lazy_load" source="data-video-lazy-load"/>
240247
<attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
248+
<attribute name="alt" source="alt"/>
249+
<attribute name="title_attribute" source="title"/>
241250
</element>
242251
<element name="content">
243252
<html name="content" preview_converter="Magento_PageBuilder/js/converter/html/directive"/>
@@ -297,6 +306,7 @@
297306
<attribute name="virtual_link_href" storage_key="link_url" source="href" converter="Magento_PageBuilder/js/converter/attribute/link-href" persistence_mode="write"/>
298307
<attribute name="virtual_link_target" storage_key="link_url" source="target" converter="Magento_PageBuilder/js/converter/attribute/link-target" persistence_mode="write"/>
299308
<attribute name="virtual_link_type" storage_key="link_url" source="data-link-type" converter="Magento_PageBuilder/js/converter/attribute/link-type" persistence_mode="write"/>
309+
<attribute name="title_attribute" source="title"/>
300310
</element>
301311
<element name="empty_link"/>
302312
<element name="overlay">
@@ -324,6 +334,8 @@
324334
<attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
325335
<attribute name="video_lazy_load" source="data-video-lazy-load"/>
326336
<attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
337+
<attribute name="alt" source="alt"/>
338+
<attribute name="title_attribute" source="title"/>
327339
</element>
328340
<element name="content">
329341
<html name="content" preview_converter="Magento_PageBuilder/js/converter/html/directive"/>

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_banner_form.xml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,4 +291,27 @@
291291
</formElements>
292292
</field>
293293
</fieldset>
294+
<fieldset name="seo" sortOrder="40">
295+
<settings>
296+
<label translate="true">Search Engine Optimization</label>
297+
<collapsible>true</collapsible>
298+
<opened>true</opened>
299+
</settings>
300+
<field name="alt" sortOrder="10" formElement="input">
301+
<settings>
302+
<label translate="true">Alternative Text</label>
303+
<validation>
304+
<rule name="validate-string" xsi:type="boolean">true</rule>
305+
</validation>
306+
</settings>
307+
</field>
308+
<field name="title_attribute" sortOrder="20" formElement="input">
309+
<settings>
310+
<label translate="true">Title Attribute</label>
311+
<validation>
312+
<rule name="validate-string" xsi:type="boolean">true</rule>
313+
</validation>
314+
</settings>
315+
</field>
316+
</fieldset>
294317
</form>

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_slide_form.xml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,4 +310,27 @@
310310
</formElements>
311311
</field>
312312
</fieldset>
313+
<fieldset name="seo" sortOrder="50">
314+
<settings>
315+
<label translate="true">Search Engine Optimization</label>
316+
<collapsible>true</collapsible>
317+
<opened>true</opened>
318+
</settings>
319+
<field name="alt" sortOrder="10" formElement="input">
320+
<settings>
321+
<label translate="true">Alternative Text</label>
322+
<validation>
323+
<rule name="validate-string" xsi:type="boolean">true</rule>
324+
</validation>
325+
</settings>
326+
</field>
327+
<field name="title_attribute" sortOrder="20" formElement="input">
328+
<settings>
329+
<label translate="true">Title Attribute</label>
330+
<validation>
331+
<rule name="validate-string" xsi:type="boolean">true</rule>
332+
</validation>
333+
</settings>
334+
</field>
335+
</fieldset>
313336
</form>

0 commit comments

Comments
 (0)