Skip to content

Commit 58aa534

Browse files
omiroshnichenkoomiroshnichenko
committed
PB-55: Row Full Width Contents Are Horizontally Positioned Incorrectly In Desktop Viewport
- fix functional tests
1 parent 5a2c560 commit 58aa534

File tree

3 files changed

+33
-3
lines changed

3 files changed

+33
-3
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderRowSection.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,17 @@
7070
<element name="base" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}]//div[@data-element='inner']" parameterized="true"/>
7171
<element name="baseJS" type="text" selector="(document.querySelectorAll('[data-content-type=row]')[{{arg1}} - 1]).querySelector('[data-element=inner]')" parameterized="true"/>
7272
</section>
73+
<section name="RowOnStage_FullWidth">
74+
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}]" parameterized="true"/>
75+
<element name="alignment" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}][contains(@style,'text-align: {{arg2}};')]" parameterized="true"/>
76+
<element name="border" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}][contains(@style,'border-style: {{arg2}};')]" parameterized="true"/>
77+
<element name="borderColor" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}][contains(@style,'border-color: {{arg2}};')]" parameterized="true"/>
78+
<element name="borderWidth" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}][contains(@style,'border-width: {{arg2}}px;')]" parameterized="true"/>
79+
<element name="borderRadius" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}][contains(@style,'border-radius: {{arg2}}px;')]" parameterized="true"/>
80+
<element name="cssClasses" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}][contains(@class,'{{arg2}}')]" parameterized="true"/>
81+
<element name="margins" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}][contains(@style,'margin: {{arg2}}px;')]" parameterized="true"/>
82+
<element name="padding" type="text" selector="(//div[contains(@class, 'pagebuilder-row')])[{{arg1}}]//div[contains(@class, 'element-children') and contains(@class, 'row-container')][contains(@style,'padding: {{arg2}}px;')]" parameterized="true"/>
83+
</section>
7384
<section name="RowOnStage_Contained_Invalid">
7485
<element name="border" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}][contains(@style,'border-style: {{arg2}};')]" parameterized="true"/>
7586
<element name="borderColor" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}][contains(@style,'border-color: {{arg2}};')]" parameterized="true"/>
@@ -121,6 +132,17 @@
121132
<element name="margins" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}]/div[contains(@style,'margin: {{arg2}}px;')]" parameterized="true"/>
122133
<element name="padding" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}]/div[contains(@style,'padding: {{arg2}}px;')]" parameterized="true"/>
123134
</section>
135+
<section name="RowOnStorefront_FullWidth">
136+
<element name="base" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}]" parameterized="true"/>
137+
<element name="alignment" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}][contains(@style,'text-align: {{arg2}};')]" parameterized="true"/>
138+
<element name="border" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}][contains(@style,'border-style: {{arg2}};')]" parameterized="true"/>
139+
<element name="borderColor" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}][contains(@style,'border-color: {{arg2}};')]" parameterized="true"/>
140+
<element name="borderWidth" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}][contains(@style,'border-width: {{arg2}}px;')]" parameterized="true"/>
141+
<element name="borderRadius" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}][contains(@style,'border-radius: {{arg2}}px;')]" parameterized="true"/>
142+
<element name="cssClasses" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}][contains(@class,'{{arg2}}')]" parameterized="true"/>
143+
<element name="margins" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}][contains(@style,'margin: {{arg2}}px;')]" parameterized="true"/>
144+
<element name="padding" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}]//div[contains(@class, 'row-full-width-inner')][contains(@style,'padding: {{arg2}}px;')]" parameterized="true"/>
145+
</section>
124146
<section name="RowOnStorefront_FullWidth_FullBleed">
125147
<element name="base" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}]" parameterized="true"/>
126148
<element name="baseJS" type="text" selector="document.querySelectorAll('[data-content-type=row]')[{{arg1}} - 1]" parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTests.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -603,6 +603,10 @@
603603
<argument name="backgroundRepeat" value="PageBuilderBackgroundRepeat_Enabled"/>
604604
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachment_Fixed"/>
605605
</actionGroup>
606+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateRowHeightCMSBlockStage">
607+
<argument name="content" value="{{RowOnStage.baseCSS}}"/>
608+
<argument name="height" value="PageBuilderMinHeightProperty_500"/>
609+
</actionGroup>
606610
<actionGroup ref="validateRowParallaxBackgroundAttributes" stepKey="validateRowParallaxBackgroundCMSPageStage">
607611
<argument name="page" value="RowOnStorefront_FullWidth_FullBleed"/>
608612
<argument name="index" value="2"/>
@@ -860,6 +864,10 @@
860864
<argument name="backgroundRepeat" value="PageBuilderBackgroundRepeat_Enabled"/>
861865
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachment_Fixed"/>
862866
</actionGroup>
867+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateRowHeightCMSBlockStage">
868+
<argument name="content" value="{{RowOnStage.baseCSS}}"/>
869+
<argument name="height" value="PageBuilderMinHeightProperty_500"/>
870+
</actionGroup>
863871
<comment userInput="---merging to remove step---" stepKey="validateParallaxBackgroundCMSBlockStage"/>
864872
<actionGroup ref="validateBackgroundImageContainer" stepKey="validateBackgroundImageCMSBlockStage">
865873
<argument name="section" value="RowOnStage"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -925,7 +925,7 @@
925925
<argument name="verticalAlignContainer" value="PageBuilderVerticalAlignmentPropertyCenter"/>
926926
</actionGroup>
927927
<actionGroup ref="validateAdvancedStyleWithAllUpdated" stepKey="validateAllAdvancedStage">
928-
<argument name="page" value="RowOnStage"/>
928+
<argument name="page" value="RowOnStage_FullWidth"/>
929929
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
930930
<argument name="border" value="PageBuilderAdvancedBorderPropertyDouble"/>
931931
<argument name="borderColor" value="PageBuilderAdvancedBorderColorProperty_green"/>
@@ -1035,7 +1035,7 @@
10351035
<argument name="verticalAlignContainer" value="PageBuilderVerticalAlignmentPropertyCenter"/>
10361036
</actionGroup>
10371037
<actionGroup ref="validateAdvancedStyleWithAllUpdated" stepKey="validateAllAdvancedStage2">
1038-
<argument name="page" value="RowOnStage"/>
1038+
<argument name="page" value="RowOnStage_FullWidth"/>
10391039
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
10401040
<argument name="border" value="PageBuilderAdvancedBorderPropertyDouble"/>
10411041
<argument name="borderColor" value="PageBuilderAdvancedBorderColorProperty_green"/>
@@ -1145,7 +1145,7 @@
11451145
<argument name="verticalAlignContainer" value="PageBuilderVerticalAlignmentPropertyCenter"/>
11461146
</actionGroup>
11471147
<actionGroup ref="validateAdvancedStyleWithAllUpdated" stepKey="validateAllAdvancedStorefront">
1148-
<argument name="page" value="RowOnStorefront_FullWidth_FullBleed"/>
1148+
<argument name="page" value="RowOnStorefront_FullWidth"/>
11491149
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
11501150
<argument name="border" value="PageBuilderAdvancedBorderPropertyDouble"/>
11511151
<argument name="borderColor" value="PageBuilderAdvancedBorderColorProperty_green"/>

0 commit comments

Comments
 (0)