Skip to content

Commit 57adbd0

Browse files
committed
PB-378: Full height Banner
- Adding MFTF tests for full height banner
1 parent d96c5c4 commit 57adbd0

9 files changed

+850
-376
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/BannerData.xml

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -9,61 +9,49 @@
99
<entities xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:DataGenerator/etc/dataProfileSchema.xsd">
1111
<!-- Appearance -->
12-
<entity name="PageBuilderBannerAppearanceDefaultProperty" type="pagebuilder_banner_appearance_property">
12+
<entity name="PageBuilderBannerAppearanceDefaultProperty" type="pagebuilder_banner_appearance_property" deprecated="true">
1313
<data key="name">Appearance</data>
1414
<data key="section">appearance_fieldset</data>
1515
<data key="fieldName">appearance</data>
1616
<data key="value">poster</data>
1717
</entity>
18-
<entity name="PageBuilderBannerAppearance_Poster" type="pagebuilder_banner_appearance_property">
18+
<entity name="PageBuilderBannerAppearance_Poster" type="pagebuilder_banner_appearance_property" deprecated="true">
1919
<data key="name">Appearance</data>
2020
<data key="section">appearance_fieldset</data>
2121
<data key="fieldName">appearance</data>
2222
<data key="value">poster</data>
2323
</entity>
24-
<entity name="PageBuilderBannerCollageLeftProperty" type="pagebuilder_banner_appearance_property">
24+
<entity name="PageBuilderBannerCollageLeftProperty" type="pagebuilder_banner_appearance_property" deprecated="true">
2525
<data key="name">Appearance</data>
2626
<data key="section">appearance_fieldset</data>
2727
<data key="fieldName">appearance</data>
2828
<data key="value">collage-left</data>
2929
</entity>
30-
<entity name="PageBuilderBannerCollageRightProperty" type="pagebuilder_banner_appearance_property">
30+
<entity name="PageBuilderBannerCollageRightProperty" type="pagebuilder_banner_appearance_property" deprecated="true">
3131
<data key="name">Appearance</data>
3232
<data key="section">appearance_fieldset</data>
3333
<data key="fieldName">appearance</data>
3434
<data key="value">collage-right</data>
3535
</entity>
36-
<entity name="PageBuilderBannerCollageCenteredProperty" type="pagebuilder_banner_appearance_property">
36+
<entity name="PageBuilderBannerCollageCenteredProperty" type="pagebuilder_banner_appearance_property" deprecated="true">
3737
<data key="name">Appearance</data>
3838
<data key="section">appearance_fieldset</data>
3939
<data key="fieldName">appearance</data>
4040
<data key="value">collage-centered</data>
4141
</entity>
4242
<!-- Minimum Height -->
43-
<entity name="PageBuilderBannerMinimumHeightProperty" type="pagebuilder_banner_minimumHeight_property">
43+
<entity name="PageBuilderBannerMinimumHeightProperty" type="pagebuilder_banner_minimumHeight_property" deprecated="true">
4444
<data key="name">Minimum Height</data>
4545
<data key="section">appearance_fieldset</data>
4646
<data key="fieldName">min_height</data>
4747
<data key="value">500</data>
4848
</entity>
49-
<entity name="PageBuilderBannerMinimumHeightPxProperty" type="pagebuilder_banner_minimumHeight_property">
50-
<data key="name">Minimum Height</data>
51-
<data key="section">appearance_fieldset</data>
52-
<data key="fieldName">min_height</data>
53-
<data key="value">500px</data>
54-
</entity>
55-
<entity name="PageBuilderBannerMinimumHeightDefaultProperty" type="pagebuilder_banner_minimumHeightDefault_property">
49+
<entity name="PageBuilderBannerMinimumHeightDefaultProperty" type="pagebuilder_banner_minimumHeightDefault_property" deprecated="true">
5650
<data key="name">Minimum Height</data>
5751
<data key="section">appearance_fieldset</data>
5852
<data key="fieldName">min_height</data>
5953
<data key="value">300</data>
6054
</entity>
61-
<entity name="PageBuilderBannerMinimumHeightDefaultPxProperty" type="pagebuilder_banner_minimumHeightDefault_property">
62-
<data key="name">Minimum Height</data>
63-
<data key="section">appearance_fieldset</data>
64-
<data key="fieldName">min_height</data>
65-
<data key="value">300px</data>
66-
</entity>
6755
<!-- Message Text -->
6856
<entity name="PageBuilderBannerMessageDefaultProperty" type="pagebuilder_banner_message_property">
6957
<data key="name">Message Text</data>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderBannerSection.xml

Lines changed: 105 additions & 103 deletions
Large diffs are not rendered by default.

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 51 additions & 51 deletions
Large diffs are not rendered by default.

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 52 additions & 52 deletions
Large diffs are not rendered by default.

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageRightAppearanceTest.xml

Lines changed: 51 additions & 51 deletions
Large diffs are not rendered by default.

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 37 additions & 31 deletions
Large diffs are not rendered by default.

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 255 additions & 49 deletions
Large diffs are not rendered by default.

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@
155155
<argument name="property" value="PageBuilderAppearance_Poster"/>
156156
</actionGroup>
157157
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerMinHeight">
158-
<argument name="property" value="PageBuilderBannerMinimumHeightPxProperty"/>
158+
<argument name="property" value="PageBuilderMinHeightProperty_500px"/>
159159
</actionGroup>
160160
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBackgroundColor">
161161
<argument name="property" value="PageBuilderBackgroundColor_Plaintext_Green"/>

0 commit comments

Comments
 (0)