Skip to content

Commit 56bebde

Browse files
danmooney2danmooney2
committed
MC-3870: Background does not conform to border radius for banner, image, contained row & video
Add BannerOverlayDoesNotHaveBorderRadiusAppliedOnCollageLeftAppearance, BannerOverlayDoesNotHaveBorderRadiusAppliedOnCollageCenteredAppearance, BannerOverlayDoesNotHaveBorderRadiusAppliedOnCollageRightAppearance, BannerOverlayHasConvertedBorderRadiusAppliedOnPosterAppearance
1 parent ad9c4ad commit 56bebde

File tree

1 file changed

+239
-0
lines changed

1 file changed

+239
-0
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 239 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2263,4 +2263,243 @@
22632263
<seeElement selector="{{BannerOnFrontend.messageContentTextAreaTextWidget('1', _ENV.MAGENTO_BASE_URL, $$createCMSPageB.identifier$$)}}" stepKey="seeWidgetStorefront"/>
22642264
<click selector="{{BannerOnFrontend.messageContentTextAreaTextWidget('1', _ENV.MAGENTO_BASE_URL, $$createCMSPageB.identifier$$)}}" stepKey="clickWidgetStorefront"/>
22652265
</test>
2266+
<test name="BannerOverlayDoesNotHaveBorderRadiusAppliedOnCollageLeftAppearance" extends="BannerOverlayHasConvertedBorderRadiusAppliedOnPosterAppearance">
2267+
<annotations>
2268+
<features value="PageBuilder"/>
2269+
<stories value="Banner"/>
2270+
<title value="Banner - Overlay does not have border radius applied on collage left appearance"/>
2271+
<description value="As a content creator I do not want border radius of banner overlay with collage left appearance to have a border radius applied to it so that I may be able to style it independently"/>
2272+
<severity value="MAJOR"/>
2273+
<useCaseId value="MC-3870"/>
2274+
<testCaseId value="MC-5254"/>
2275+
<group value="pagebuilder"/>
2276+
<group value="pagebuilder-banner"/>
2277+
<group value="pagebuilder-bannerCommon"/>
2278+
</annotations>
2279+
<before>
2280+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2281+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
2282+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
2283+
</before>
2284+
<after>
2285+
<closeTab stepKey="closeTab"/>
2286+
<actionGroup ref="logout" stepKey="logout"/>
2287+
</after>
2288+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
2289+
<argument name="property" value="PageBuilderBannerCollageLeftProperty"/>
2290+
</actionGroup>
2291+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidth">
2292+
<expectedResult type="int">0</expectedResult>
2293+
<actualResult type="variable">$overlayBorderRadius</actualResult>
2294+
</assertEquals>
2295+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidthOnStorefront">
2296+
<expectedResult type="int">0</expectedResult>
2297+
<actualResult type="variable">$overlayBorderRadiusStorefront</actualResult>
2298+
</assertEquals>
2299+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidth">
2300+
<expectedResult type="int">0</expectedResult>
2301+
<actualResult type="variable">$overlayBorderRadius2</actualResult>
2302+
</assertEquals>
2303+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidthOnStorefront">
2304+
<expectedResult type="int">0</expectedResult>
2305+
<actualResult type="variable">$overlayBorderRadiusStorefront2</actualResult>
2306+
</assertEquals>
2307+
</test>
2308+
<test name="BannerOverlayDoesNotHaveBorderRadiusAppliedOnCollageCenteredAppearance" extends="BannerOverlayHasConvertedBorderRadiusAppliedOnPosterAppearance">
2309+
<annotations>
2310+
<features value="PageBuilder"/>
2311+
<stories value="Banner"/>
2312+
<title value="Banner - Overlay does not have border radius applied on collage centered appearance"/>
2313+
<description value="As a content creator I do not want border radius of banner overlay with collage centered appearance to have a border radius applied to it so that I may be able to style it independently"/>
2314+
<severity value="MAJOR"/>
2315+
<useCaseId value="MC-3870"/>
2316+
<testCaseId value="MC-5253"/>
2317+
<group value="pagebuilder"/>
2318+
<group value="pagebuilder-banner"/>
2319+
<group value="pagebuilder-bannerCommon"/>
2320+
</annotations>
2321+
<before>
2322+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2323+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
2324+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
2325+
</before>
2326+
<after>
2327+
<closeTab stepKey="closeTab"/>
2328+
<actionGroup ref="logout" stepKey="logout"/>
2329+
</after>
2330+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
2331+
<argument name="property" value="PageBuilderBannerCollageCenteredProperty"/>
2332+
</actionGroup>
2333+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidth">
2334+
<expectedResult type="int">0</expectedResult>
2335+
<actualResult type="variable">$overlayBorderRadius</actualResult>
2336+
</assertEquals>
2337+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidthOnStorefront">
2338+
<expectedResult type="int">0</expectedResult>
2339+
<actualResult type="variable">$overlayBorderRadiusStorefront</actualResult>
2340+
</assertEquals>
2341+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidth">
2342+
<expectedResult type="int">0</expectedResult>
2343+
<actualResult type="variable">$overlayBorderRadius2</actualResult>
2344+
</assertEquals>
2345+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidthOnStorefront">
2346+
<expectedResult type="int">0</expectedResult>
2347+
<actualResult type="variable">$overlayBorderRadiusStorefront2</actualResult>
2348+
</assertEquals>
2349+
</test>
2350+
<test name="BannerOverlayDoesNotHaveBorderRadiusAppliedOnCollageRightAppearance" extends="BannerOverlayHasConvertedBorderRadiusAppliedOnPosterAppearance">
2351+
<annotations>
2352+
<features value="PageBuilder"/>
2353+
<stories value="Banner"/>
2354+
<title value="Banner - Overlay does not have border radius applied on collage right appearance"/>
2355+
<description value="As a content creator I do not want border radius of banner overlay with collage right appearance to have a border radius applied to it so that I may be able to style it independently"/>
2356+
<severity value="MAJOR"/>
2357+
<useCaseId value="MC-3870"/>
2358+
<testCaseId value="MC-5252"/>
2359+
<group value="pagebuilder"/>
2360+
<group value="pagebuilder-banner"/>
2361+
<group value="pagebuilder-bannerCommon"/>
2362+
</annotations>
2363+
<before>
2364+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2365+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
2366+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
2367+
</before>
2368+
<after>
2369+
<closeTab stepKey="closeTab"/>
2370+
<actionGroup ref="logout" stepKey="logout"/>
2371+
</after>
2372+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
2373+
<argument name="property" value="PageBuilderBannerCollageRightProperty"/>
2374+
</actionGroup>
2375+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidth">
2376+
<expectedResult type="int">0</expectedResult>
2377+
<actualResult type="variable">$overlayBorderRadius</actualResult>
2378+
</assertEquals>
2379+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidthOnStorefront">
2380+
<expectedResult type="int">0</expectedResult>
2381+
<actualResult type="variable">$overlayBorderRadiusStorefront</actualResult>
2382+
</assertEquals>
2383+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidth">
2384+
<expectedResult type="int">0</expectedResult>
2385+
<actualResult type="variable">$overlayBorderRadius2</actualResult>
2386+
</assertEquals>
2387+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidthOnStorefront">
2388+
<expectedResult type="int">0</expectedResult>
2389+
<actualResult type="variable">$overlayBorderRadiusStorefront2</actualResult>
2390+
</assertEquals>
2391+
</test>
2392+
<test name="BannerOverlayHasConvertedBorderRadiusAppliedOnPosterAppearance">
2393+
<annotations>
2394+
<features value="PageBuilder"/>
2395+
<stories value="Banner"/>
2396+
<title value="Banner - Overlay has converted border radius applied on poster appearance"/>
2397+
<description value="As a content creator I want border radius of banner overlay with poster appearance to have a different border radius than its parent wrapper so that it aligns snugly alongside it without exposing any gaps"/>
2398+
<severity value="MAJOR"/>
2399+
<useCaseId value="MC-3870"/>
2400+
<testCaseId value="MC-5237"/>
2401+
<group value="pagebuilder"/>
2402+
<group value="pagebuilder-banner"/>
2403+
<group value="pagebuilder-bannerCommon"/>
2404+
</annotations>
2405+
<before>
2406+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2407+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
2408+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
2409+
</before>
2410+
<after>
2411+
<closeTab stepKey="closeTab"/>
2412+
<actionGroup ref="logout" stepKey="logout"/>
2413+
</after>
2414+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
2415+
<argument name="contentType" value="PageBuilderBannerContentType"/>
2416+
</actionGroup>
2417+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
2418+
<argument name="group" value="PageBuilderBannerContentType"/>
2419+
</actionGroup>
2420+
<actionGroup ref="dragContentTypeToStage" stepKey="dragBannerIntoStage">
2421+
<argument name="contentType" value="PageBuilderBannerContentType"/>
2422+
</actionGroup>
2423+
<!-- Open edit panel and apply border radius/width on poster appearance where border radius > border width -->
2424+
<comment userInput="Open edit panel and apply border radius/width on poster appearance where border radius greater than border width" stepKey="commentOpenEditPanel"/>
2425+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
2426+
<argument name="contentType" value="PageBuilderBannerContentType"/>
2427+
</actionGroup>
2428+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
2429+
<argument name="property" value="PageBuilderBannerAppearance_Poster"/>
2430+
</actionGroup>
2431+
<actionGroup ref="selectSlideOutPanelField" stepKey="enterBorder">
2432+
<argument name="property" value="PageBuilderAdvancedBorderPropertyDouble"/>
2433+
</actionGroup>
2434+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBorderWidth">
2435+
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty10"/>
2436+
</actionGroup>
2437+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBorderRadius">
2438+
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty12"/>
2439+
</actionGroup>
2440+
<actionGroup ref="selectSlideOutPanelField" stepKey="enterBannerShowOverlayAlways">
2441+
<argument name="property" value="PageBuilderBannerShowContentOverlayAlwaysProperty"/>
2442+
</actionGroup>
2443+
<actionGroup ref="fillSlideOutPanelField" stepKey="enterOverlayColor">
2444+
<argument name="property" value="PageBuilderBannerOverlayColor_FF0000"/>
2445+
</actionGroup>
2446+
<actionGroup ref="fillSlideOutPanelField" stepKey="enterOverlayTransparency">
2447+
<argument name="property" value="PageBuilderBannerOverlayTransparencyProperty"/>
2448+
</actionGroup>
2449+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
2450+
<!-- Validate Stage where border radius > border width -->
2451+
<comment userInput="Validate Stage on poster appearance where border radius greater than border width" stepKey="commentValidateStage"/>
2452+
<seeElement selector="{{BannerOnBackend.overlay('1')}}" stepKey="seeOverlay"/>
2453+
<executeJS function="return parseInt(getComputedStyle(document.evaluate(&quot;{{BannerOnBackend.overlay('1')}}&quot;,document.body).iterateNext()).borderRadius, 10)" stepKey="overlayBorderRadius"/>
2454+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidth">
2455+
<expectedResult type="int">2</expectedResult>
2456+
<actualResult type="variable">$overlayBorderRadius</actualResult>
2457+
</assertEquals>
2458+
<!-- Validate Storefront where border radius > border width -->
2459+
<comment userInput="Validate Storefront where border radius greater than border width" stepKey="commentValidateStorefront"/>
2460+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
2461+
<openNewTab stepKey="openNewTab"/>
2462+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
2463+
<argument name="contentType" value="PageBuilderBannerContentType"/>
2464+
</actionGroup>
2465+
<executeJS function="return parseInt(getComputedStyle(document.evaluate(&quot;{{BannerOnFrontend.overlay('1')}}&quot;,document.body).iterateNext()).borderRadius, 10)" stepKey="overlayBorderRadiusStorefront"/>
2466+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidthOnStorefront">
2467+
<expectedResult type="int">2</expectedResult>
2468+
<actualResult type="variable">$overlayBorderRadiusStorefront</actualResult>
2469+
</assertEquals>
2470+
<switchToPreviousTab stepKey="switchBackToAdmin"/>
2471+
<reloadPage stepKey="refreshPage"/>
2472+
<waitForPageLoad stepKey="waitForPageRefresh"/>
2473+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
2474+
<!-- Open edit panel and apply border radius/width where border radius <= border width -->
2475+
<comment userInput="Open edit panel and apply border radius/width where border radius less than or equal to border width" stepKey="commentOpenEditPanel2"/>
2476+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
2477+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
2478+
<argument name="contentType" value="PageBuilderBannerContentType"/>
2479+
</actionGroup>
2480+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBorderRadius2">
2481+
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty1"/>
2482+
</actionGroup>
2483+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
2484+
<!-- Validate Stage on where border radius <= border width -->
2485+
<comment userInput="Validate Stage where border radius less than or equal to border width" stepKey="commentValidateStagePoster"/>
2486+
<executeJS function="return parseInt(getComputedStyle(document.evaluate(&quot;{{BannerOnBackend.overlay('1')}}&quot;,document.body).iterateNext()).borderRadius, 10)" stepKey="overlayBorderRadius2" />
2487+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidth">
2488+
<expectedResult type="int">0</expectedResult>
2489+
<actualResult type="variable">$overlayBorderRadius2</actualResult>
2490+
</assertEquals>
2491+
<!-- Validate Storefront where border radius <= border width -->
2492+
<comment userInput="Validate Storefront where border radius less than or equal to border width" stepKey="commentValidateStorefront2"/>
2493+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>
2494+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage3"/>
2495+
<switchToNextTab stepKey="switchBackToStorefront" />
2496+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront2">
2497+
<argument name="contentType" value="PageBuilderBannerContentType"/>
2498+
</actionGroup>
2499+
<executeJS function="return parseInt(getComputedStyle(document.evaluate(&quot;{{BannerOnFrontend.overlay('1')}}&quot;,document.body).iterateNext()).borderRadius, 10)" stepKey="overlayBorderRadiusStorefront2" />
2500+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidthOnStorefront">
2501+
<expectedResult type="int">0</expectedResult>
2502+
<actualResult type="variable">$overlayBorderRadiusStorefront2</actualResult>
2503+
</assertEquals>
2504+
</test>
22662505
</tests>

0 commit comments

Comments
 (0)