Skip to content

Commit 561d896

Browse files
committed
MC-14937: Complete Page Builder Analytics data collection
- fix static test failures
1 parent 832d304 commit 561d896

File tree

5 files changed

+5
-6
lines changed

5 files changed

+5
-6
lines changed

app/code/Magento/PageBuilder/Model/View/File/Collector/PageBuilder.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ public function __construct(
5656
*
5757
* @param \Magento\Framework\View\Design\ThemeInterface $theme
5858
* @param string $filePath
59+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
5960
* @return \Magento\Framework\View\File[]
6061
*/
6162
public function getFiles(ThemeInterface $theme, $filePath)

app/code/Magento/PageBuilderAnalytics/composer.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,10 @@
55
"magento/module-analytics": "*",
66
"magento/module-cms": "*",
77
"magento/module-catalog": "*",
8+
"magento/module-page-builder": "*",
89
"magento/framework": "*",
910
"php": "~7.1.3||~7.2.0"
1011
},
11-
"suggest": {
12-
"magento/module-page-builder": "*"
13-
},
1412
"type": "magento2-module",
1513
"license": [
1614
"proprietary"

dev/tests/integration/_files/Magento/TestModulePageBuilderAnalytics/etc/module.xml renamed to dev/tests/integration/_files/Magento/TestModuleCmsPageBuilderAnalytics/etc/module.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66
*/
77
-->
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
9-
<module name="Magento_TestModulePageBuilderAnalytics" active="true" />
9+
<module name="Magento_TestModuleCmsPageBuilderAnalytics" active="true" />
1010
</config>

dev/tests/integration/_files/Magento/TestModulePageBuilderAnalytics/registration.php renamed to dev/tests/integration/_files/Magento/TestModuleCmsPageBuilderAnalytics/registration.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@
88
use Magento\Framework\Component\ComponentRegistrar;
99

1010
$registrar = new ComponentRegistrar();
11-
if ($registrar->getPath(ComponentRegistrar::MODULE, 'Magento_TestModulePageBuilderAnalytics') === null) {
12-
ComponentRegistrar::register(ComponentRegistrar::MODULE, 'Magento_TestModulePageBuilderAnalytics', __DIR__);
11+
if ($registrar->getPath(ComponentRegistrar::MODULE, 'Magento_TestModuleCmsPageBuilderAnalytics') === null) {
12+
ComponentRegistrar::register(ComponentRegistrar::MODULE, 'Magento_TestModuleCmsPageBuilderAnalytics', __DIR__);
1313
}

0 commit comments

Comments
 (0)