Skip to content

Commit 4fb482e

Browse files
committed
Merge from 559_no-predefined-gutters
2 parents 9ca528e + da12d97 commit 4fb482e

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest/RowValidateAdvancedConfigurationDefaultValuesTest.xml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,12 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
8+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
109
<test name="RowValidateAdvancedConfigurationDefaultValuesTest">
1110
<annotations>
1211
<features value="PageBuilder"/>
1312
<stories value="Row"/>
14-
<title value="Validate Advanced Configuration Default Values"/>
13+
<title value="Row - Validate Advanced Configuration Default Values"/>
1514
<description value="Validate the default values for every attribute in the Advanced Configuration form and on Stage for Row."/>
1615
<severity value="BLOCKER"/>
1716
<useCaseId value="MAGETWO-83415"/>
@@ -67,6 +66,7 @@
6766
<argument name="property" value="PageBuilderPaddingProperty_Empty"/>
6867
</actionGroup>
6968
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
69+
7070
<!-- Validate Stage -->
7171
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
7272
<actionGroup ref="ValidateAdvancedConfigurationWithBorderColorActionGroup" stepKey="validateStage">
@@ -81,12 +81,13 @@
8181
</actionGroup>
8282
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="validateMarginStage">
8383
<argument name="selector" value="{{RowOnStage.affordance('1')}}"/>
84-
<argument name="expectedProperty" value="{{PageBuilderMarginsPropertyRowStage.value}}"/>
84+
<argument name="expectedProperty" value="{{PageBuilderMarginsPropertyRowDefault.value}}"/>
8585
<argument name="cssProperty" value="margin"/>
8686
</actionGroup>
8787
<actionGroup ref="exitPageBuilderFullScreen" stepKey="exitPageBuilderFullScreen"/>
8888
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
8989
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
90+
9091
<!-- Validate Stage After Save -->
9192
<comment userInput="Validate Stage After Save" stepKey="commentValidateStage2"/>
9293
<actionGroup ref="ValidateAdvancedConfigurationWithBorderColorActionGroup" stepKey="validateStage2">
@@ -101,12 +102,13 @@
101102
</actionGroup>
102103
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="validateMarginStageAfterSave">
103104
<argument name="selector" value="{{RowOnStage.affordance('1')}}"/>
104-
<argument name="expectedProperty" value="{{PageBuilderMarginsPropertyRowStage.value}}"/>
105+
<argument name="expectedProperty" value="{{PageBuilderMarginsPropertyRowDefault.value}}"/>
105106
<argument name="cssProperty" value="margin"/>
106107
</actionGroup>
107108
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
108109
<argument name="contentType" value="PageBuilderRowContentType"/>
109110
</actionGroup>
111+
110112
<!-- Validate Edit Panel After Save -->
111113
<comment userInput="Validate Edit Panel After Save" stepKey="commentValidateEditPanel2"/>
112114
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateAlignment2">
@@ -138,6 +140,7 @@
138140
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
139141
<argument name="contentType" value="PageBuilderRowContentType"/>
140142
</actionGroup>
143+
141144
<!-- Validate Storefront -->
142145
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
143146
<actionGroup ref="ValidateAdvancedConfigurationWithNoAlignmentActionGroup" stepKey="validateStorefront">

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_row_form.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@
175175
<field name="margins_and_padding">
176176
<argument name="data" xsi:type="array">
177177
<item name="config" xsi:type="array">
178-
<item name="default" xsi:type="string">{"margin":{"bottom":null,"left":null,"right":null,"top":null},"padding":{"bottom":null,"left":null,"right":null,"top":null}}</item>
178+
<item name="default" xsi:type="null" />
179179
</item>
180180
</argument>
181181
</field>

0 commit comments

Comments
 (0)