Skip to content

Commit 4f77c98

Browse files
author
Hwashiang Yu
committed
MC-4150: Widget placeholder and variable placeholder styling is broken on inline editing
- Added waits to reduce flakiness
1 parent d484384 commit 4f77c98

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1582,6 +1582,7 @@
15821582
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{SlideOnBackend.variablePlaceholder('1')}}&quot;, document.body).iterateNext()).getPropertyValue('background-color')" stepKey="getVariableStyle" />
15831583
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{SlideOnBackend.widgetPlaceholder('1')}}&quot;, document.body).iterateNext()).getPropertyValue('background-color')" stepKey="getWidgetStyle" />
15841584
<click selector="{{SlideOnBackend.tinymce('1')}}" stepKey="focusOnEditorArea2" after="commentValidateStageAfterSave"/>
1585+
<waitForPageLoad stepKey="waitForTextEditor2" after="focusOnEditorArea2"/>
15851586
<waitForElement selector="{{SlideOnBackend.variablePlaceholder('1')}}" stepKey="waitForVariableElement"/>
15861587
<waitForElement selector="{{SlideOnBackend.widgetPlaceholder('1')}}" stepKey="waitForWidgetElement"/>
15871588
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{SlideOnBackend.variablePlaceholder('1')}}&quot;, document.body).iterateNext()).getPropertyValue('background-color')" stepKey="getVariableStyleAfterSave" />

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2435,6 +2435,7 @@
24352435
<!--Input variable into stage-->
24362436
<comment userInput="Input variable into stage" stepKey="commentInputVariableIntoStage"/>
24372437
<click selector="{{TextOnStage.tinymce('1')}}" stepKey="focusOnEditorArea1"/>
2438+
<waitForPageLoad stepKey="waitForTextEditor1"/>
24382439
<actionGroup ref="addVariableToTinyMCEInline" stepKey="addVariableToTinyMCE">
24392440
<argument name="variable" value="TinyMCEVariableBaseURL"/>
24402441
</actionGroup>

0 commit comments

Comments
 (0)