Skip to content

Commit 4db8697

Browse files
author
joiecaquicla
committed
magento2/magento2-page-builder#636: Responsive breakpoint switcher - fixed failed functional tests
1 parent b778bb0 commit 4db8697

File tree

2 files changed

+121
-37
lines changed

2 files changed

+121
-37
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileBannerCollageCenteredAppearanceThroughBlockContentTypeTest.xml

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@
3333
<argument name="expectedOverlayWidth" value="{$widthOfWrapperMinusPaddingCMSBlockStage}"/>
3434
</actionGroup>
3535

36-
<seeElement selector="{{BannerOnBackend.collageMinimumHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinimumHeightCMSBlockStage"/>
36+
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="seeMinimumHeightCMSBlockStage">
37+
<argument name="selector" value="{{BannerOnBackend.wrapper('1')}}"/>
38+
<argument name="expectedProperty" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
39+
<argument name="cssProperty" value="minHeight"/>
40+
</actionGroup>
3741
<moveMouseOver selector="{{BannerOnBackend.appearance('1', PageBuilderAppearance_CollageCentered.value)}}" stepKey="moveMouseOverBannerCMSBlockStage"/>
3842
<executeJS function="return Math.abs(Math.round({$buttonLeftPositionCMSBlockStage}-{$overlayLeftPositionCMSBlockStage}-30))" stepKey="buttonMinusOverlayMinusPaddingCMSBlockStage"/>
3943

@@ -42,7 +46,11 @@
4246
<actionGroup ref="validateOverlayPositionCollageCenter" stepKey="validateOverlayPositionCMSBlockStageDesktop">
4347
<argument name="page" value="BannerOnBackend"/>
4448
</actionGroup>
45-
<seeElement selector="{{BannerOnBackend.collageMinimumHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinimumHeightCMSBlockStageDesktop"/>
49+
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="seeMinimumHeightCMSBlockStageDesktop">
50+
<argument name="selector" value="{{BannerOnBackend.wrapper('1')}}"/>
51+
<argument name="expectedProperty" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
52+
<argument name="cssProperty" value="minHeight"/>
53+
</actionGroup>
4654
<moveMouseOver selector="{{BannerOnBackend.appearance('1', PageBuilderAppearance_CollageCentered.value)}}" stepKey="moveMouseOverBannerCMSBlockStageDesktop"/>
4755
<executeJS function="return Math.abs(Math.round({$buttonLeftPositionCMSBlockStage}-{$overlayLeftPositionCMSBlockStage}-30))" stepKey="buttonMinusOverlayMinusPaddingCMSBlockStageDesktop"/>
4856

@@ -53,23 +61,35 @@
5361
<argument name="page" value="BannerOnFrontend"/>
5462
<argument name="expectedOverlayWidth" value="{$widthOfWrapperMinusPaddingCMSPageStage}"/>
5563
</actionGroup>
56-
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinimumHeightCMSPageStage"/>
64+
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="seeMinimumHeightCMSPageStage">
65+
<argument name="selector" value="{{BannerOnFrontend.wrapper('1')}}"/>
66+
<argument name="expectedProperty" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
67+
<argument name="cssProperty" value="minHeight"/>
68+
</actionGroup>
5769
<executeJS function="return Math.abs(Math.round({$buttonLeftPositionCMSPageStage}-{$overlayLeftPositionCMSPageStage}-30))" stepKey="buttonMinusOverlayMinusPaddingCMSPageStage"/>
5870

5971
<!-- Validate CMS Page Stage Desktop Viewport -->
6072
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderAppearance_CollageCentered.value)}}" stepKey="seeAppearanceCMSPageStageDesktop"/>
6173
<actionGroup ref="validateOverlayPositionCollageCenter" stepKey="validateOverlayPositionCMSPageStageDesktop">
6274
<argument name="page" value="BannerOnFrontend"/>
6375
</actionGroup>
64-
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinimumHeightCMSPageStageDesktop"/>
76+
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="seeMinimumHeightCMSPageStageDesktop">
77+
<argument name="selector" value="{{BannerOnFrontend.wrapper('1')}}"/>
78+
<argument name="expectedProperty" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
79+
<argument name="cssProperty" value="minHeight"/>
80+
</actionGroup>
6581
<executeJS function="return Math.abs(Math.round({$buttonLeftPositionCMSPageStage}-{$overlayLeftPositionCMSPageStage}-30))" stepKey="buttonMinusOverlayMinusPaddingCMSPageStageDesktop"/>
6682

6783
<!-- Validate CMS Page Storefront -->
6884
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderAppearance_CollageCentered.value)}}" stepKey="seeAppearanceCMSPageStorefront"/>
6985
<actionGroup ref="validateOverlayPositionCollageCenter" stepKey="validateOverlayPositionCMSPageStorefront">
7086
<argument name="page" value="BannerOnFrontend"/>
7187
</actionGroup>
72-
<seeElement selector="{{BannerOnFrontend.collageMinimumHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinimumHeightCMSPageStorefront"/>
88+
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="seeMinimumHeightCMSPageStorefront">
89+
<argument name="selector" value="{{BannerOnFrontend.wrapper('1')}}"/>
90+
<argument name="expectedProperty" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
91+
<argument name="cssProperty" value="minHeight"/>
92+
</actionGroup>
7393
<moveMouseOver selector="{{BannerOnFrontend.appearance('1', PageBuilderAppearance_CollageCentered.value)}}" stepKey="moveMouseOverBannerCMSPageStorefront"/>
7494
<executeJS function="return Math.abs(Math.round({$buttonLeftPositionCMSPageStorefront}-{$overlayLeftPositionCMSPageStorefront}-30))" stepKey="buttonMinusOverlayMinusPaddingCMSPageStorefront"/>
7595

0 commit comments

Comments
 (0)