Skip to content

Commit 4d8b9b7

Browse files
committed
#637: Form field/field group viewport scope - added new functional test for tab item
1 parent 0621e45 commit 4d8b9b7

File tree

3 files changed

+329
-1
lines changed

3 files changed

+329
-1
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/TabData.xml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,56 +63,79 @@
6363
<data key="section">general</data>
6464
<data key="fieldName">min_height</data>
6565
<data key="value">300</data>
66+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
6667
</entity>
6768
<entity name="PageBuilderTabMinimumHeightEmptyProperty" type="pagebuilder_tab_property">
6869
<data key="name">Minimum Height</data>
6970
<data key="section">general</data>
7071
<data key="fieldName">min_height</data>
7172
<data key="value"/>
73+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
74+
</entity>
75+
<entity name="PageBuilderTabMinimumHeightEmptyContainerProperty" type="pagebuilder_tab_property">
76+
<data key="name">Minimum Height</data>
77+
<data key="section">general</data>
78+
<data key="fieldName">min_height</data>
79+
<data key="value">220</data>
80+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
7281
</entity>
7382
<entity name="PageBuilderTabMinHeight0Property" type="pagebuilder_tab_property">
7483
<data key="name">Minimum Height</data>
7584
<data key="section">general</data>
7685
<data key="fieldName">min_height</data>
7786
<data key="value">0</data>
87+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
7888
</entity>
7989
<entity name="PageBuilderTabMinimumHeight200Property" type="pagebuilder_tab_property">
8090
<data key="name">Minimum Height</data>
8191
<data key="section">general</data>
8292
<data key="fieldName">min_height</data>
8393
<data key="value">200</data>
94+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
8495
</entity>
8596
<entity name="PageBuilderTabMinimumHeight300Property" type="pagebuilder_tab_property">
8697
<data key="name">Minimum Height</data>
8798
<data key="section">general</data>
8899
<data key="fieldName">min_height</data>
89100
<data key="value">300</data>
101+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
102+
</entity>
103+
<entity name="PageBuilderTabMinimumHeight500Property" type="pagebuilder_tab_property">
104+
<data key="name">Minimum Height</data>
105+
<data key="section">general</data>
106+
<data key="fieldName">min_height</data>
107+
<data key="value">500</data>
108+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
90109
</entity>
91110
<entity name="PageBuilderTabMinimumHeight600Property" type="pagebuilder_tab_property">
92111
<data key="name">Minimum Height</data>
93112
<data key="section">general</data>
94113
<data key="fieldName">min_height</data>
95114
<data key="value">600</data>
115+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
96116
</entity>
97117
<entity name="PageBuilderTabMinimumHeight1000Property" type="pagebuilder_tab_property">
98118
<data key="name">Minimum Height</data>
99119
<data key="section">general</data>
100120
<data key="fieldName">min_height</data>
101121
<data key="value">1000</data>
122+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
102123
</entity>
103124
<entity name="PageBuilderTabMinimumHeightProperty_NonNumeric" type="pagebuilder_tab_property">
104125
<data key="name">Minimum Height</data>
105126
<data key="section">general</data>
106127
<data key="fieldName">min_height</data>
107128
<data key="value">a</data>
108129
<data key="errorMessage">Please enter a valid number in this field.</data>
130+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
109131
</entity>
110132
<entity name="PageBuilderTabMinHeightProperty_Negative1" type="pagebuilder_tab_property">
111133
<data key="name">Minimum Height</data>
112134
<data key="section">general</data>
113135
<data key="fieldName">min_height</data>
114136
<data key="value">-1</data>
115137
<data key="errorMessage">Please enter a value greater than or equal to 0.</data>
138+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
116139
</entity>
117140
<!-- Vertical Alignment -->
118141
<entity name="PageBuilderTabVerticalAlignmentPropertyTop" type="pagebuilder_tab_property">

app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileTabGroupMinHeightTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@
281281
<argument name="expectedProperty" value="{{PageBuilderTabsMinHeightProperty_500.value}}"/>
282282
<argument name="cssProperty" value="minHeight"/>
283283
</actionGroup>
284-
<executeJS function="return document.evaluate('{{TabOnStorefront.base('1')}}', document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="firstMinHeightStorefrontMobile"/>
284+
<executeJS function="return document.evaluate('{{TabsOnStorefront.base('1')}}', document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().height" stepKey="firstMinHeightStorefrontMobile"/>
285285
<assertEquals stepKey="assertFirstMinHeightStorefrontMobile">
286286
<actualResult type="variable">firstMinHeightStorefrontMobile</actualResult>
287287
<expectedResult type="string">{{PageBuilderTabsMinHeightProperty_500.value}}</expectedResult>

0 commit comments

Comments
 (0)