Skip to content

Commit 4ce50d9

Browse files
committed
MC-35100 Track pages where Page Builder has been used
- Refactor: Extract code to Magento_PageBuilderAdminAnalytics module
1 parent 13885c9 commit 4ce50d9

File tree

5 files changed

+48
-9
lines changed

5 files changed

+48
-9
lines changed

app/code/Magento/PageBuilder/view/adminhtml/requirejs-config.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ var config = {
4040
},
4141
'Magento_PageBuilder/js/content-type/row/appearance/default/widget': {
4242
'Magento_PageBuilder/js/content-type/row/appearance/default/widget-mixin': true
43-
},
44-
'Magento_PageBuilder/js/events': {
45-
'Magento_PageBuilder/js/page-builder/events-mixin': true
4643
}
4744
}
4845
}
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?xml version="1.0"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9+
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
10+
<module name="Magento_PageBuilderAdminAnalytics">
11+
<sequence>
12+
<module name="Magento_AdminAnalytics"/>
13+
<module name="Magento_PageBuilder"/>
14+
</sequence>
15+
</module>
16+
</config>
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
7+
use \Magento\Framework\Component\ComponentRegistrar;
8+
9+
ComponentRegistrar::register(ComponentRegistrar::MODULE, 'Magento_PageBuilderAdminAnalytics', __DIR__);
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
/**
2+
* Copyright © Magento, Inc. All rights reserved.
3+
* See COPYING.txt for license details.
4+
*/
5+
6+
var config = {
7+
config: {
8+
mixins: {
9+
'Magento_PageBuilder/js/events': {
10+
'Magento_PageBuilderAdminAnalytics/js/page-builder/events-mixin': true
11+
}
12+
}
13+
}
14+
};

app/code/Magento/PageBuilder/view/adminhtml/web/js/page-builder/events-mixin.js renamed to app/code/Magento/PageBuilderAdminAnalytics/view/adminhtml/web/js/page-builder/events-mixin.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* See COPYING.txt for license details.
44
*/
55

6-
define([], function () {
6+
define(['underscore'], function (_underscore) {
77
'use strict';
88

99
return function (target) {
@@ -17,18 +17,21 @@ define([], function () {
1717
*/
1818

1919
target.trigger = function (name, args) {
20-
21-
originalTarget.call(originalTarget, name, args);
20+
originalTarget.apply([originalTarget, name, args]);
2221

2322
if (name.indexOf('readyAfter') !== -1 &&
24-
window.digitalData !== undefined &&
25-
typeof window.digitalData !== 'undefined'
23+
!_underscore.isUndefined(window.digitalData)
2624
) {
25+
console.log(222);
2726
window.digitalData.page.url = window.location.href;
2827
window.digitalData.page.attributes = {
2928
editedWithPageBuilder: 'true'
3029
};
31-
window._satellite.track('page');
30+
31+
if (!_underscore.isUndefined(window._satellite)) {
32+
console.log(333);
33+
window._satellite.track('page');
34+
}
3235
}
3336
};
3437

0 commit comments

Comments
 (0)