Skip to content

Commit 4ab1ebf

Browse files
committed
MC-3406: Explicit Background Attributes for Tab
- fix hiding for items inside tab - fix vertical alignment on storefront
1 parent ccc728d commit 4ab1ebf

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/tab-item/default/master.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<div attr="Object.assign({}, data.main.attributes(), { id: parent.id })"
99
ko-style="Object.assign(data.container.style(), data.main.style())"
1010
css="data.main.css">
11-
<div class="pagebuilder-mobile-hidden" attr="data.desktop_image.attributes" ko-style="data.desktop_image.style" css="data.desktop_image.css">
11+
<div class="pagebuilder-mobile-hidden" attr="data.desktop_image.attributes" ko-style="Object.assign(data.desktop_image.style(), data.container.style())" css="data.desktop_image.css">
1212
<render args="renderChildTemplate" />
1313
</div>
1414
<div class="pagebuilder-mobile-only" attr="data.mobile_image.attributes" ko-style="data.mobile_image.style" css="data.mobile_image.css">

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/tab-item/default/preview.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<if args="$parent.isContainer()">
1111
<div class="pagebuilder-drop-indicator"></div>
1212
</if>
13-
<div class="pagebuilder-content-type-wrapper" template="{ name: preview.previewTemplate, data: preview, afterRender: preview.dispatchAfterRenderEvent.bind(preview) }" attr="{ id: id }"></div>
13+
<div class="pagebuilder-content-type-wrapper" template="{ name: preview.previewTemplate, data: preview, afterRender: preview.dispatchAfterRenderEvent.bind(preview) }" attr="{ id: id }" css="{'pagebuilder-content-type-hidden': !preview.display()}"></div>
1414
<if args="$parent.isContainer() && $index() === $parent.parent.getChildren()().length - 1">
1515
<div class="pagebuilder-drop-indicator"></div>
1616
</if>

0 commit comments

Comments
 (0)