Skip to content

Commit 4a5176a

Browse files
AC-11662 CSP - improve script rendering
1 parent e4eff1d commit 4a5176a

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

app/code/Magento/PageBuilder/view/adminhtml/templates/stage/render.phtml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,7 @@ $script .= <<<SCRIPT
5050
require(['Magento_PageBuilder/js/master-format/render/frame'], function (listen) {
5151
listen({$pageBuilderConfig});
5252
});
53-
?>
5453
SCRIPT;
55-
56-
/* @noEscape */ echo $secureRenderer->renderTag('script', [], $script, false);
5754
?>
58-
55+
<?= /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false) ?>
5956
<div>Page Builder Render Frame</div>

app/code/Magento/PageBuilder/view/adminhtml/templates/wysiwyg_setup.phtml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ $script = <<<SCRIPT
2020
}
2121
}
2222
});
23-
?>
2423
SCRIPT;
2524
?>
2625
<?= /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false) ?>

app/code/Magento/PageBuilder/view/base/templates/googlemaps.phtml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,8 @@ $script = <<<SCRIPT
3232
}
3333
});
3434
SCRIPT;
35-
//phpcs:ignore
36-
echo /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false);
3735
?>
36+
<?= /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false) ?>
3837

3938
<?php
4039
/** Include the googleMaps dependency only if we have an API key set, this removes unnecessary calls to Google */

0 commit comments

Comments
 (0)