Skip to content

Commit 4a25365

Browse files
committed
MC-3799: Slide poster overlay does not cover entire slide in admin when switching appearances
- stabilization: handle opening of edit panel - stabilization: use generic padding data
1 parent 4ac3420 commit 4a25365

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1401,9 +1401,12 @@
14011401
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
14021402
<argument name="group" value="PageBuilderSliderContentType"/>
14031403
</actionGroup>
1404-
<actionGroup ref="dragContentTypeToStageAndExpectEditPanel" stepKey="dragSliderIntoStage">
1404+
<actionGroup ref="dragContentTypeToStage" stepKey="dragSliderIntoStage">
14051405
<argument name="contentType" value="PageBuilderSliderContentType"/>
14061406
</actionGroup>
1407+
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openSliderEditPanel">
1408+
<argument name="section" value="SlideOnBackend"/>
1409+
</actionGroup>
14071410
<!-- Fill Out Edit Panel: Appearance Poster -->
14081411
<comment userInput="Fill Out Edit Panel: Appearance Poster" stepKey="commentFillEditPanel"/>
14091412
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearancePropertyPoster">
@@ -1423,8 +1426,8 @@
14231426
<comment userInput="Validate Stage Overlay and Padding" stepKey="commentValidateOverlayPadding"/>
14241427
<seeElement selector="{{SlideOnBackend.showOverlay('1', PageBuilderSlideItemShowOverlay_Always.value)}}" stepKey="seeOverlayStateStage"/>
14251428
<seeElement selector="{{SlideOnBackend.overlayColorAndTransparency('1', PageBuilderSlideItemOverlayColor_HexGreen.rgb, PageBuilderSlideItemOverlayTransparency_70.decimal)}}" stepKey="seeOverlayColorAndTransparencyStage"/>
1426-
<seeElement selector="{{SlideOnBackend.posterPadding('1', PageBuilderSlideItemPosterPadding_Default.value)}}" stepKey="seePosterPadding" />
1427-
<dontSeeElement selector="{{SlideOnBackend.collagePadding('1', PageBuilderSlideItemPosterPadding_Default.value)}}" stepKey="dontSeeCollagePadding" />
1429+
<seeElement selector="{{SlideOnBackend.posterPadding('1', PageBuilderPaddingProperty40.value)}}" stepKey="seePosterPadding" />
1430+
<dontSeeElement selector="{{SlideOnBackend.collagePadding('1', PageBuilderPaddingProperty40.value)}}" stepKey="dontSeeCollagePadding" />
14281431
<!-- Change Appearance to Collage Left -->
14291432
<comment userInput="Change Appearance to Collage Left" stepKey="commentChangeAppearanceCollageLeft"/>
14301433
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditMenuOnStage">
@@ -1436,7 +1439,7 @@
14361439
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
14371440
<seeElement selector="{{SlideOnBackend.showOverlay('1', PageBuilderSlideItemShowOverlay_Always.value)}}" stepKey="seeOverlayStateStage2"/>
14381441
<seeElement selector="{{SlideOnBackend.overlayColorAndTransparency('1', PageBuilderSlideItemOverlayColor_HexGreen.rgb, PageBuilderSlideItemOverlayTransparency_70.decimal)}}" stepKey="seeOverlayColorAndTransparencyStage2"/>
1439-
<dontSeeElement selector="{{SlideOnBackend.posterPadding('1', PageBuilderSlideItemPosterPadding_Default.value)}}" stepKey="dontSeeDefaultPosterPadding" />
1442+
<dontSeeElement selector="{{SlideOnBackend.posterPadding('1', PageBuilderPaddingProperty40.value)}}" stepKey="dontSeeDefaultPosterPadding" />
14401443
<!-- Change Appearance back to Poster -->
14411444
<comment userInput="Change Appearance back to Poster" stepKey="commentChangeAppearanceBackToPoster"/>
14421445
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditMenuOnStage2">
@@ -1450,7 +1453,7 @@
14501453
<comment userInput="Validate Stage Overlay and Padding after appearance change" stepKey="commentValidateOverlayPadding2"/>
14511454
<seeElement selector="{{SlideOnBackend.showOverlay('1', PageBuilderSlideItemShowOverlay_Always.value)}}" stepKey="seeOverlayStateStage3"/>
14521455
<seeElement selector="{{SlideOnBackend.overlayColorAndTransparency('1', PageBuilderSlideItemOverlayColor_HexGreen.rgb, PageBuilderSlideItemOverlayTransparency_70.decimal)}}" stepKey="seeOverlayColorAndTransparencyStage3"/>
1453-
<seeElement selector="{{SlideOnBackend.posterPadding('1', PageBuilderSlideItemPosterPadding_Default.value)}}" stepKey="seePosterPadding2" />
1454-
<dontSeeElement selector="{{SlideOnBackend.collagePadding('1', PageBuilderSlideItemPosterPadding_Default.value)}}" stepKey="dontSeeCollagePadding2" />
1456+
<seeElement selector="{{SlideOnBackend.posterPadding('1', PageBuilderPaddingProperty40.value)}}" stepKey="seePosterPadding2" />
1457+
<dontSeeElement selector="{{SlideOnBackend.collagePadding('1', PageBuilderPaddingProperty40.value)}}" stepKey="dontSeeCollagePadding2" />
14551458
</test>
14561459
</tests>

0 commit comments

Comments
 (0)