Skip to content

Commit 49ee873

Browse files
yolouieseyolouiese
committed
#637: Form field/field group viewport scope - added new functional test for tab group, additional data and section
1 parent 2afb746 commit 49ee873

File tree

4 files changed

+352
-0
lines changed

4 files changed

+352
-0
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Data/CommonContentTypeData.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,23 @@
1313
<data key="fieldName">min_height</data>
1414
<data key="value"/>
1515
<data key="helperText">Minimum height can be a single number with any valid CSS unit (50px, 50%, 50em, 50vh) or a calculation (50% + 50px).</data>
16+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
1617
</entity>
1718
<entity name="PageBuilderMinHeightProperty_0" type="pagebuilder_min_height_property">
1819
<data key="name">Minimum Height</data>
1920
<data key="section">appearance_fieldset</data>
2021
<data key="fieldName">min_height</data>
2122
<data key="value">0</data>
2223
<data key="style">min-height: 0px</data>
24+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
2325
</entity>
2426
<entity name="PageBuilderMinHeightProperty_500" type="pagebuilder_min_height_property">
2527
<data key="name">Minimum Height</data>
2628
<data key="section">appearance_fieldset</data>
2729
<data key="fieldName">min_height</data>
2830
<data key="value">500</data>
2931
<data key="style">min-height: 500px</data>
32+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
3033
</entity>
3134
<entity name="PageBuilderMinHeightProperty_500px" type="pagebuilder_min_height_property">
3235
<data key="name">Minimum Height</data>
@@ -35,13 +38,15 @@
3538
<data key="value">500px</data>
3639
<data key="intValue">500</data>
3740
<data key="style">min-height: 500px</data>
41+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
3842
</entity>
3943
<entity name="PageBuilderMinHeightProperty_300" type="pagebuilder_min_height_property">
4044
<data key="name">Minimum Height</data>
4145
<data key="section">appearance_fieldset</data>
4246
<data key="fieldName">min_height</data>
4347
<data key="value">300</data>
4448
<data key="style">min-height: 300px</data>
49+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
4550
</entity>
4651
<entity name="PageBuilderMinHeightProperty_300px" type="pagebuilder_min_height_property">
4752
<data key="name">Minimum Height</data>
@@ -50,13 +55,15 @@
5055
<data key="value">300px</data>
5156
<data key="intValue">300</data>
5257
<data key="style">min-height: 300px</data>
58+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
5359
</entity>
5460
<entity name="PageBuilderMinHeightProperty_200" type="pagebuilder_min_height_property">
5561
<data key="name">Minimum Height</data>
5662
<data key="section">appearance_fieldset</data>
5763
<data key="fieldName">min_height</data>
5864
<data key="value">200</data>
5965
<data key="style">min-height: 200px</data>
66+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
6067
</entity>
6168
<entity name="PageBuilderMinHeightProperty_200px" type="pagebuilder_min_height_property">
6269
<data key="name">Minimum Height</data>
@@ -65,6 +72,7 @@
6572
<data key="value">200px</data>
6673
<data key="intValue">200</data>
6774
<data key="style">min-height: 200px</data>
75+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
6876
</entity>
6977
<entity name="PageBuilderMinHeightProperty_100px" type="pagebuilder_min_height_property">
7078
<data key="name">Minimum Height</data>
@@ -73,41 +81,47 @@
7381
<data key="value">100px</data>
7482
<data key="intValue">100</data>
7583
<data key="style">min-height: 100px</data>
84+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
7685
</entity>
7786
<entity name="PageBuilderMinHeightProperty_100vh" type="pagebuilder_min_height_property">
7887
<data key="name">Minimum Height</data>
7988
<data key="section">appearance_fieldset</data>
8089
<data key="fieldName">min_height</data>
8190
<data key="value">100vh</data>
8291
<data key="style">min-height: 100vh</data>
92+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
8393
</entity>
8494
<entity name="PageBuilderMinHeightProperty_300vh" type="pagebuilder_min_height_property">
8595
<data key="name">Minimum Height</data>
8696
<data key="section">appearance_fieldset</data>
8797
<data key="fieldName">min_height</data>
8898
<data key="value">300vh</data>
8999
<data key="style">min-height: 300vh</data>
100+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
90101
</entity>
91102
<entity name="PageBuilderMinHeightProperty_100vh_Minus_200px" type="pagebuilder_min_height_property">
92103
<data key="name">Minimum Height</data>
93104
<data key="section">appearance_fieldset</data>
94105
<data key="fieldName">min_height</data>
95106
<data key="value">calc(100vh - 200px)</data>
96107
<data key="style">min-height: calc(100vh - 200px)</data>
108+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
97109
</entity>
98110
<entity name="PageBuilderMinHeightProperty_NonNumeric" type="pagebuilder_min_height_property">
99111
<data key="name">Minimum Height</data>
100112
<data key="section">appearance_fieldset</data>
101113
<data key="fieldName">min_height</data>
102114
<data key="value">a</data>
103115
<data key="errorMessage">Please enter a valid number or calculation: Valid numbers must have an extension (px, %, pt, vh). Calculations must have white space around the + and - operators and cannot divide by zero.</data>
116+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
104117
</entity>
105118
<entity name="PageBuilderMinHeightProperty_Negative1" type="pagebuilder_min_height_property">
106119
<data key="name">Minimum Height</data>
107120
<data key="section">appearance_fieldset</data>
108121
<data key="fieldName">min_height</data>
109122
<data key="value">-1</data>
110123
<data key="errorMessage">Please enter a valid number or calculation: Valid numbers must have an extension (px, %, pt, vh). Calculations must have white space around the + and - operators and cannot divide by zero.</data>
124+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
111125
</entity>
112126
<!-- Vertical Alignment -->
113127
<entity name="PageBuilderVerticalAlignmentPropertyTop" type="pagebuilder_vertical_alignment_property">

‎app/code/Magento/PageBuilder/Test/Mftf/Data/TabsData.xml

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,23 +30,54 @@
3030
<data key="value">Tab 2</data>
3131
</entity>
3232
<!-- Minimum Height -->
33+
<entity name="PageBuilderTabsMinHeightProperty_Empty" type="pagebuilder_tabs_property">
34+
<data key="name">Minimum Height</data>
35+
<data key="section">general</data>
36+
<data key="fieldName">min_height</data>
37+
<data key="value"/>
38+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
39+
</entity>
40+
<entity name="PageBuilderTabsMinHeightProperty_0" type="pagebuilder_tabs_property">
41+
<data key="name">Minimum Height</data>
42+
<data key="section">general</data>
43+
<data key="fieldName">min_height</data>
44+
<data key="value">0</data>
45+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
46+
</entity>
47+
<entity name="PageBuilderTabsMinHeightProperty_80" type="pagebuilder_tabs_property">
48+
<data key="name">Minimum Height</data>
49+
<data key="section">general</data>
50+
<data key="fieldName">min_height</data>
51+
<data key="value">80</data>
52+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
53+
</entity>
54+
<entity name="PageBuilderTabsMinHeightProperty_200" type="pagebuilder_tabs_property">
55+
<data key="name">Minimum Height</data>
56+
<data key="section">general</data>
57+
<data key="fieldName">min_height</data>
58+
<data key="value">200</data>
59+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
60+
</entity>
3361
<entity name="PageBuilderTabsDefaultMinHeight" type="pagebuilder_tabs_property">
3462
<data key="name">Minimum Height</data>
3563
<data key="section">general</data>
3664
<data key="fieldName">min_height</data>
3765
<data key="value">300</data>
66+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
3867
</entity>
3968
<entity name="PageBuilderTabsDefinedMinHeight" type="pagebuilder_tabs_property">
4069
<data key="name">Minimum Height</data>
4170
<data key="section">general</data>
4271
<data key="fieldName">min_height</data>
4372
<data key="value">400</data>
73+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
4474
</entity>
4575
<entity name="PageBuilderTabsMinHeightProperty_500" type="pagebuilder_tabs_property">
4676
<data key="name">Minimum Height</data>
4777
<data key="section">general</data>
4878
<data key="fieldName">min_height</data>
4979
<data key="value">500</data>
80+
<data key="tooltipText">Style changes will only affect this breakpoint</data>
5081
</entity>
5182
<!-- Tab Navigation Alignment -->
5283
<entity name="PageBuilderTabsAlignmentDefault" type="pagebuilder_tabs_property">

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTabsSection/TabsOnStageSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,6 @@
2828
<element name="addNewTabButton" type="button" selector="//button/span[contains(text(), 'Add New Tab')]"/>
2929
<element name="tabsAlignment" type="text" selector="//ul[@role='tablist' and contains(@style,'text-align: {{arg1}}')]" parameterized="true" deprecated="Styles are not inline"/>
3030
<element name="tabsContentPath" type="button" selector="(//div[contains(@class,&quot;pagebuilder-tabs&quot;)]//descendant::*[contains(@class,&quot;tabs-content&quot;)])"/>
31+
<element name="tabsContentContainerIndex" type="button" selector="(//div[@data-content-type=&quot;tabs&quot;]//div[contains(@class,&quot;tabs-content&quot;)]//*[@role=&quot;tabpanel&quot;])[{{arg1}}]" parameterized="true"/>
3132
</section>
3233
</sections>

0 commit comments

Comments
 (0)